From patchwork Mon Jan 9 15:53:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 17902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FF1C61DB3 for ; Mon, 9 Jan 2023 15:53:59 +0000 (UTC) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by mx.groups.io with SMTP id smtpd.web11.75908.1673279634137605853 for ; Mon, 09 Jan 2023 07:53:54 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: 0leil.net, ip: 217.70.183.199, mailfrom: foss+yocto@0leil.net) Received: (Authenticated sender: foss@0leil.net) by mail.gandi.net (Postfix) with ESMTPSA id 69B13FF80A; Mon, 9 Jan 2023 15:53:50 +0000 (UTC) From: Quentin Schulz To: openembedded-core@lists.openembedded.org, Quentin Schulz Cc: Quentin Schulz Subject: [PATCH] packagegroup-core-boot: make init-ifupdown package a recommendation Date: Mon, 9 Jan 2023 16:53:40 +0100 Message-Id: <20230109-optional-ifupdown-v1-1-18a8f3aee85b@theobroma-systems.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Mailer: b4 0.11.2 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 09 Jan 2023 15:53:59 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/175692 From: Quentin Schulz init-ifupdown provides an /etc/network/interfaces, which disables interface management with networkmanager for example. If a network manager (such as networkmanager) is provided, there may not be a need for network related init scripts provided by init-ifupdown, so let's make it a recommendation so it can be easily removed in image recipes via the NO_RECOMMENDATIONS/BAD_RECOMMENDATIONS mechanism. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- Signed-off-by: Quentin Schulz --- meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: a134a7186b2266378bc0b08c134e169a943eedde change-id: 20230109-optional-ifupdown-f25f75924f58 Best regards, -- Quentin Schulz diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb index faf7bc0026..a7bad81023 100644 --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb @@ -18,7 +18,6 @@ EFI_PROVIDER ??= "grub-efi" SYSVINIT_SCRIPTS = "${@bb.utils.contains('MACHINE_FEATURES', 'rtc', '${VIRTUAL-RUNTIME_base-utils-hwclock}', '', d)} \ modutils-initscripts \ - init-ifupdown \ ${VIRTUAL-RUNTIME_initscripts} \ " @@ -38,4 +37,5 @@ RDEPENDS:${PN} = "\ RRECOMMENDS:${PN} = "\ ${VIRTUAL-RUNTIME_base-utils-syslog} \ - ${MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS}" + ${MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS} \ + ${@bb.utils.contains("DISTRO_FEATURES", "sysvinit", "init-ifupdown", "", d)}"