| Message ID | 20220202134233.2091916-3-ch@denx.de |
|---|---|
| State | New |
| Headers | show |
| Series | Update gstreamer recipes to 1.19.90 | expand |
Hi, Claudius Heine <ch@denx.de> escreveu no dia quarta, 2/02/2022 à(s) 13:42: > Signed-off-by: Claudius Heine <ch@denx.de> > --- > ...004-glimagesink-Downrank-to-marginal.patch | 32 ------------------- > ...b => gstreamer1.0-plugins-base_1.19.90.bb} | 5 ++- > 2 files changed, 2 insertions(+), 35 deletions(-) > delete mode 100644 > meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-glimagesink-Downrank-to-marginal.patch > rename meta/recipes-multimedia/gstreamer/{ > gstreamer1.0-plugins-base_1.18.5.bb => > gstreamer1.0-plugins-base_1.19.90.bb} (94%) > > diff --git > a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-glimagesink-Downrank-to-marginal.patch > b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-glimagesink-Downrank-to-marginal.patch > deleted file mode 100644 > index f45ea65ef3..0000000000 > --- > a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-glimagesink-Downrank-to-marginal.patch > +++ /dev/null > @@ -1,32 +0,0 @@ > -From 79841a02ee754eba736cb32aaf2ed2b2fc0483d4 Mon Sep 17 00:00:00 2001 > -From: Alexander Kanavin <alex.kanavin@gmail.com> > -Date: Thu, 24 Sep 2015 19:47:32 +0300 > -Subject: [PATCH 4/4] glimagesink: Downrank to marginal > - > -On desktop, where there is good OpenGL, xvimagesink will come up first, > -on other platforms, OpenGL can't be trusted because it's either software > (like > -in a VM) or broken (like on embedded)., so let ximagesink come above. > - > -Upstream-Status: Submitted [ > https://bugzilla.gnome.org/show_bug.cgi?id=751684] > - > -Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> > ---- > - ext/gl/gstopengl.c | 2 +- > - 1 file changed, 1 insertion(+), 1 deletion(-) > - > -diff --git a/ext/gl/gstopengl.c b/ext/gl/gstopengl.c > -index 302e845..463be9c 100644 > ---- a/ext/gl/gstopengl.c > -+++ b/ext/gl/gstopengl.c > -@@ -127,7 +127,7 @@ plugin_init (GstPlugin * plugin) > - #endif > - > - if (!gst_element_register (plugin, "glimagesink", > -- GST_RANK_SECONDARY, gst_gl_image_sink_bin_get_type ())) { > -+ GST_RANK_MARGINAL, gst_gl_image_sink_bin_get_type ())) { > - return FALSE; > - } > - > --- > -2.28.0 > - > diff --git a/meta/recipes-multimedia/gstreamer/ > gstreamer1.0-plugins-base_1.18.5.bb b/meta/recipes-multimedia/gstreamer/ > gstreamer1.0-plugins-base_1.19.90.bb > similarity index 94% > rename from meta/recipes-multimedia/gstreamer/ > gstreamer1.0-plugins-base_1.18.5.bb > rename to meta/recipes-multimedia/gstreamer/ > gstreamer1.0-plugins-base_1.19.90.bb > index 180241828f..5b02d4565a 100644 > --- a/meta/recipes-multimedia/gstreamer/ > gstreamer1.0-plugins-base_1.18.5.bb > +++ b/meta/recipes-multimedia/gstreamer/ > gstreamer1.0-plugins-base_1.19.90.bb > @@ -4,15 +4,14 @@ DESCRIPTION = "'Base' GStreamer plugins and helper > libraries" > HOMEPAGE = "https://gstreamer.freedesktop.org/" > BUGTRACKER = " > https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues" > LICENSE = "GPLv2+ & LGPLv2+" > -LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d" > +LIC_FILES_CHKSUM = "file://COPYING;md5=69333daa044cb77e486cc36129f7a770" > > SRC_URI = " > https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-${PV}.tar.xz > \ > > file://0001-ENGR00312515-get-caps-from-src-pad-when-query-caps.patch \ > file://0003-viv-fb-Make-sure-config.h-is-included.patch \ > file://0002-ssaparse-enhance-SSA-text-lines-parsing.patch \ > - file://0004-glimagesink-Downrank-to-marginal.patch \ > Why is this patch dropped? As Far as I know it is not merged upstream. > " > -SRC_URI[sha256sum] = > "960b7af4585700db0fdd5b843554e11e2564fed9e061f591fae88a7be6446fa3" > +SRC_URI[sha256sum] = > "667c5cbfae1873c8291b5911bedbf20ce92ee607b8b1b3d37120ed54e452db00" > > S = "${WORKDIR}/gst-plugins-base-${PV}" > > -- > 2.34.1 > >
Hi Jose, On 2022-02-02 18:57, Jose Quaresma wrote: [...] > SRC_URI = > "https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-${PV}.tar.xz > <https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-$%7BPV%7D.tar.xz> > \ > > file://0001-ENGR00312515-get-caps-from-src-pad-when-query-caps.patch \ > file://0003-viv-fb-Make-sure-config.h-is-included.patch \ > file://0002-ssaparse-enhance-SSA-text-lines-parsing.patch \ > - file://0004-glimagesink-Downrank-to-marginal.patch \ > > > Why is this patch dropped? As Far as I know it is not merged upstream. Good catch! Thanks. Not sure why I dropped it. I will add a rebased version to v2.
On Thu, 3 Feb 2022 at 10:03, Claudius Heine <ch@denx.de> wrote: > > file://0001-ENGR00312515-get-caps-from-src-pad-when-query-caps.patch > \ > > file://0003-viv-fb-Make-sure-config.h-is-included.patch > \ > > > file://0002-ssaparse-enhance-SSA-text-lines-parsing.patch \ > > - file://0004-glimagesink-Downrank-to-marginal.patch \ > > > > > > Why is this patch dropped? As Far as I know it is not merged upstream. > > Good catch! Thanks. Not sure why I dropped it. I will add a rebased > version to v2. > On the other hand I think it's something we do not need anymore. Alex
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-glimagesink-Downrank-to-marginal.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-glimagesink-Downrank-to-marginal.patch deleted file mode 100644 index f45ea65ef3..0000000000 --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-glimagesink-Downrank-to-marginal.patch +++ /dev/null @@ -1,32 +0,0 @@ -From 79841a02ee754eba736cb32aaf2ed2b2fc0483d4 Mon Sep 17 00:00:00 2001 -From: Alexander Kanavin <alex.kanavin@gmail.com> -Date: Thu, 24 Sep 2015 19:47:32 +0300 -Subject: [PATCH 4/4] glimagesink: Downrank to marginal - -On desktop, where there is good OpenGL, xvimagesink will come up first, -on other platforms, OpenGL can't be trusted because it's either software (like -in a VM) or broken (like on embedded)., so let ximagesink come above. - -Upstream-Status: Submitted [https://bugzilla.gnome.org/show_bug.cgi?id=751684] - -Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> ---- - ext/gl/gstopengl.c | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/ext/gl/gstopengl.c b/ext/gl/gstopengl.c -index 302e845..463be9c 100644 ---- a/ext/gl/gstopengl.c -+++ b/ext/gl/gstopengl.c -@@ -127,7 +127,7 @@ plugin_init (GstPlugin * plugin) - #endif - - if (!gst_element_register (plugin, "glimagesink", -- GST_RANK_SECONDARY, gst_gl_image_sink_bin_get_type ())) { -+ GST_RANK_MARGINAL, gst_gl_image_sink_bin_get_type ())) { - return FALSE; - } - --- -2.28.0 - diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.5.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.19.90.bb similarity index 94% rename from meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.5.bb rename to meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.19.90.bb index 180241828f..5b02d4565a 100644 --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.5.bb +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.19.90.bb @@ -4,15 +4,14 @@ DESCRIPTION = "'Base' GStreamer plugins and helper libraries" HOMEPAGE = "https://gstreamer.freedesktop.org/" BUGTRACKER = "https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues" LICENSE = "GPLv2+ & LGPLv2+" -LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d" +LIC_FILES_CHKSUM = "file://COPYING;md5=69333daa044cb77e486cc36129f7a770" SRC_URI = "https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-${PV}.tar.xz \ file://0001-ENGR00312515-get-caps-from-src-pad-when-query-caps.patch \ file://0003-viv-fb-Make-sure-config.h-is-included.patch \ file://0002-ssaparse-enhance-SSA-text-lines-parsing.patch \ - file://0004-glimagesink-Downrank-to-marginal.patch \ " -SRC_URI[sha256sum] = "960b7af4585700db0fdd5b843554e11e2564fed9e061f591fae88a7be6446fa3" +SRC_URI[sha256sum] = "667c5cbfae1873c8291b5911bedbf20ce92ee607b8b1b3d37120ed54e452db00" S = "${WORKDIR}/gst-plugins-base-${PV}"
Signed-off-by: Claudius Heine <ch@denx.de> --- ...004-glimagesink-Downrank-to-marginal.patch | 32 ------------------- ...b => gstreamer1.0-plugins-base_1.19.90.bb} | 5 ++- 2 files changed, 2 insertions(+), 35 deletions(-) delete mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0004-glimagesink-Downrank-to-marginal.patch rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-plugins-base_1.18.5.bb => gstreamer1.0-plugins-base_1.19.90.bb} (94%)