[05/12] gstreamer1.0-plugins-ugly: 1.18.5 -> 1.19.90

Message ID 20220202134233.2091916-6-ch@denx.de
State New
Headers show
Series Update gstreamer recipes to 1.19.90 | expand

Commit Message

Claudius Heine Feb. 2, 2022, 1:42 p.m. UTC
Feature `gpl` was added, which allows building gpl licensed codecs.

Signed-off-by: Claudius Heine <ch@denx.de>
---
 ...s-ugly_1.18.5.bb => gstreamer1.0-plugins-ugly_1.19.90.bb} | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-plugins-ugly_1.18.5.bb => gstreamer1.0-plugins-ugly_1.19.90.bb} (89%)

Comments

Jose Quaresma Feb. 2, 2022, 5:58 p.m. UTC | #1
Hi Claudius,

Claudius Heine <ch@denx.de> escreveu no dia quarta, 2/02/2022 à(s) 13:43:

> Feature `gpl` was added, which allows building gpl licensed codecs.
>
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>  ...s-ugly_1.18.5.bb => gstreamer1.0-plugins-ugly_1.19.90.bb} | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>  rename meta/recipes-multimedia/gstreamer/{
> gstreamer1.0-plugins-ugly_1.18.5.bb =>
> gstreamer1.0-plugins-ugly_1.19.90.bb} (89%)
>
> diff --git a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.18.5.bb b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.19.90.bb
> similarity index 89%
> rename from meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.18.5.bb
> rename to meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.19.90.bb
> index 9777aaee19..53d8d0ed07 100644
> --- a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.18.5.bb
> +++ b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.19.90.bb
> @@ -13,7 +13,7 @@ LICENSE_FLAGS = "commercial"
>  SRC_URI = " \
>
> https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-${PV}.tar.xz
> \
>              "
> -SRC_URI[sha256sum] =
> "df32803e98f8a9979373fa2ca7e05e62f977b1097576d3a80619d9f5c69f66d9"
> +SRC_URI[sha256sum] =
> "5242a42c3fad209030bd2e8630b08ae93821384c2278965764a039d31ab2a246"
>
>  S = "${WORKDIR}/gst-plugins-ugly-${PV}"
>
> @@ -23,7 +23,7 @@ GST_PLUGIN_SET_HAS_EXAMPLES = "0"
>
>  PACKAGECONFIG ??= " \
>      ${GSTREAMER_ORC} \
> -    a52dec mpeg2dec \
> +    a52dec mpeg2dec gpl \
>

This will require commercial licence support
https://docs.yoctoproject.org/dev-manual/common-tasks.html?highlight=license_flags#enabling-commercially-licensed-recipes


>  "
>
>  PACKAGECONFIG[a52dec]   = "-Da52dec=enabled,-Da52dec=disabled,liba52"
> @@ -33,6 +33,7 @@ PACKAGECONFIG[cdio]     =
> "-Dcdio=enabled,-Dcdio=disabled,libcdio"
>  PACKAGECONFIG[dvdread]  =
> "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread"
>  PACKAGECONFIG[mpeg2dec] =
> "-Dmpeg2dec=enabled,-Dmpeg2dec=disabled,mpeg2dec"
>  PACKAGECONFIG[x264]     = "-Dx264=enabled,-Dx264=disabled,x264"
> +PACKAGECONFIG[gpl]      = "-Dgpl=enabled,-Dgpl=disabled"
>
>  EXTRA_OEMESON += " \
>      -Ddoc=disabled \
> --
> 2.34.1
>
>
Claudius Heine Feb. 3, 2022, 9:27 a.m. UTC | #2
Hi Jose,

On 2022-02-02 18:58, Jose Quaresma wrote:
[...]
>     @@ -13,7 +13,7 @@ LICENSE_FLAGS = "commercial"
>       SRC_URI = " \
>     https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-${PV}.tar.xz
>     <https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-$%7BPV%7D.tar.xz>
>     \
>                   "
>     -SRC_URI[sha256sum] =
>     "df32803e98f8a9979373fa2ca7e05e62f977b1097576d3a80619d9f5c69f66d9"
>     +SRC_URI[sha256sum] =
>     "5242a42c3fad209030bd2e8630b08ae93821384c2278965764a039d31ab2a246"
> 
>       S = "${WORKDIR}/gst-plugins-ugly-${PV}"
> 
>     @@ -23,7 +23,7 @@ GST_PLUGIN_SET_HAS_EXAMPLES = "0"
> 
>       PACKAGECONFIG ??= " \
>           ${GSTREAMER_ORC} \
>     -    a52dec mpeg2dec \
>     +    a52dec mpeg2dec gpl \
> 
> 
> This will require commercial licence support
> https://docs.yoctoproject.org/dev-manual/common-tasks.html?highlight=license_flags#enabling-commercially-licensed-recipes 
> <https://docs.yoctoproject.org/dev-manual/common-tasks.html?highlight=license_flags#enabling-commercially-licensed-recipes>

Yes. I am not sure if I understand your point. The `LICENSE_FLAGS = 
"commercial"` is already set in the recipe, see first line of this diff.

regards,
Claudius

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.18.5.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.19.90.bb
similarity index 89%
rename from meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.18.5.bb
rename to meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.19.90.bb
index 9777aaee19..53d8d0ed07 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.18.5.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.19.90.bb
@@ -13,7 +13,7 @@  LICENSE_FLAGS = "commercial"
 SRC_URI = " \
             https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-${PV}.tar.xz \
             "
-SRC_URI[sha256sum] = "df32803e98f8a9979373fa2ca7e05e62f977b1097576d3a80619d9f5c69f66d9"
+SRC_URI[sha256sum] = "5242a42c3fad209030bd2e8630b08ae93821384c2278965764a039d31ab2a246"
 
 S = "${WORKDIR}/gst-plugins-ugly-${PV}"
 
@@ -23,7 +23,7 @@  GST_PLUGIN_SET_HAS_EXAMPLES = "0"
 
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
-    a52dec mpeg2dec \
+    a52dec mpeg2dec gpl \
 "
 
 PACKAGECONFIG[a52dec]   = "-Da52dec=enabled,-Da52dec=disabled,liba52"
@@ -33,6 +33,7 @@  PACKAGECONFIG[cdio]     = "-Dcdio=enabled,-Dcdio=disabled,libcdio"
 PACKAGECONFIG[dvdread]  = "-Ddvdread=enabled,-Ddvdread=disabled,libdvdread"
 PACKAGECONFIG[mpeg2dec] = "-Dmpeg2dec=enabled,-Dmpeg2dec=disabled,mpeg2dec"
 PACKAGECONFIG[x264]     = "-Dx264=enabled,-Dx264=disabled,x264"
+PACKAGECONFIG[gpl]      = "-Dgpl=enabled,-Dgpl=disabled"
 
 EXTRA_OEMESON += " \
     -Ddoc=disabled \