| Message ID | cover.1667525891.git.cp0613@linux.alibaba.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
The synchronous submission is located in https://github.com/openembedded/openembedded-core/pull/82
Hello, On 04/11/2022 10:02:08+0800, cp0613 wrote: > The following changes since commit 6050d1f74c02495490d982ead2993b6b3c9cc04a: > are available in the Git repository at: > > https://github.com/cp0613/openembedded-core brotli > https://github.com/cp0613/openembedded-core/tree/brotli > > cp0613 (1): > add python3-brotli_1.0.9 in meta/recipes-devtools/python This fails on the autobuilders: The following recipes do not have a HOMEPAGE. Please add an entry for HOMEPAGE in the recipe. python3-brotli (/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/recipes-devtools/python/python3-brotli_1.0.9.bb) The following recipes do not have a maintainer assigned to them. Please add an entry to meta/conf/distro/include/maintainers.inc file. python3-brotli (/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/recipes-devtools/python/python3-brotli_1.0.9.bb) > > .../python/python3-brotli_1.0.9.bb | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 meta/recipes-devtools/python/python3-brotli_1.0.9.bb > > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#172658): https://lists.openembedded.org/g/openembedded-core/message/172658 > Mute This Topic: https://lists.openembedded.org/mt/94798159/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 4 Nov 2022, at 02:02, cp0613 via lists.openembedded.org <cp0613=linux.alibaba.com@lists.openembedded.org> wrote: > > The following changes since commit 6050d1f74c02495490d982ead2993b6b3c9cc04a: > are available in the Git repository at: > > https://github.com/cp0613/openembedded-core brotli > https://github.com/cp0613/openembedded-core/tree/brotli We take patches sent via git-send-email, so please resend using that. However, there’s a high bar to getting a python module into oe-core instead of meta-python. Why do you think this module should be in oe-core, and not in meta-python? Ross
+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=941ee9cd1609382f946352712a319b4b”
Relative paths are relative to S, so this can be just file://LICENSE.
+# there is no valid file in pypi, so download from github
+SRC_URI = "http://codeload.github.com/google/brotli/tar.gz/v${PV};downloadfilename=brotli-${PV}.tar.gz”
+SRC_URI[sha256sum] = "f9e8d81d0405ba66d181529af42a3354f838c939095ff99930da6aa9cdf6fe46"
That looks like a dynamically generated git archive, which means the checksum will change over time.
If there is no static tarball, use the git: fetcher.
Ross
On Fri, 4 Nov 2022 at 17:20, Ross Burton <ross.burton@arm.com> wrote: > +LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=941ee9cd1609382f946352712a319b4b” > > Relative paths are relative to S, so this can be just file://LICENSE. > > +# there is no valid file in pypi, so download from github > +SRC_URI = "http://codeload.github.com/google/brotli/tar.gz/v${PV};downloadfilename=brotli-${PV}.tar.gz” > +SRC_URI[sha256sum] = "f9e8d81d0405ba66d181529af42a3354f838c939095ff99930da6aa9cdf6fe46" > > That looks like a dynamically generated git archive, which means the checksum will change over time. > > If there is no static tarball, use the git: fetcher. There is: https://pypi.org/project/Brotli/#files You just need to set the filename suffix correctly (pypi class has a facility for it) so it doesn't try to fetch with the default suffix. Alex
Re-adding oe-core to the CC as this discussion should be on the list. I suggest you add the recipe to meta-python then. Ross > On 5 Nov 2022, at 07:58, cp0613 <cp0613@linux.alibaba.com> wrote: > > Thanks. This is my first submission and there may be some operation is wrong. I will continue to try git-send-email. > > The reason for using python3-brotli is that this library is dependent on many other projects. However, it cannot be installed directly through pip3 on the RISCV platform. Therefore, we use yocto to compile it. We find that many python bb are here, so we add them here.