diff mbox series

[1/2] CI: add explanatory comments to variables

Message ID 20240129181401.2170364-1-ross.burton@arm.com
State New
Headers show
Series [1/2] CI: add explanatory comments to variables | expand

Commit Message

Ross Burton Jan. 29, 2024, 6:14 p.m. UTC 
From: Ross Burton <ross.burton@arm.com>

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .gitlab-ci.yml | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

Comments

Jon Mason Jan. 30, 2024, 11:31 a.m. UTC | #1 
On Mon, 29 Jan 2024 18:14:00 +0000, ross.burton@arm.com wrote:
> 


Applied, thanks!

[1/2] CI: add explanatory comments to variables
      commit: 8b94fee2058d52ef450508ba1dde0e1df2d08c12
[2/2] CI: allow the runner to set a NVD API key
      commit: 60202ad84d3d3531e79107a8281ef3502ccfa156

Best regards,
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 4c6ce14a..4e4c1283 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,16 +1,23 @@ 
 image: ${MIRROR_GHCR}/siemens/kas/kas:4.0
 
 variables:
+  # These are needed as the k8s executor doesn't respect the container
+  # entrypoint by default
+  FF_KUBERNETES_HONOR_ENTRYPOINT: 1
+  FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY: 0
+  # The default value for KUBERNETES_CPU_REQUEST
   CPU_REQUEST: ""
+  # The default machine tag for the build jobs
   DEFAULT_TAG: ""
+  # The machine tag for the ACS test jobs
+  ACS_TAG: ""
+  # The directory to use as the persistent cache (the root for DL_DIR, SSTATE_DIR, etc)
   CACHE_DIR: $CI_BUILDS_DIR/persist
+  # The container mirror to use
   MIRROR_GHCR: ghcr.io
-  # These are needed as the k8s executor doesn't respect the container entrypoint
-  # by default
-  FF_KUBERNETES_HONOR_ENTRYPOINT: 1
-  FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY: 0
+  # Whether to run the SystemReady ACS tests
   ACS_TEST: 0
-  ACS_TAG: ""
+  # The list of extra Kas fragments to be used when building
   EXTRA_KAS_FILES: ""
 
 stages: