| Message ID | 20230908114439.13213-1-r-gunasekaran@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,kirkstone,v2] kernel-rdepends: Remove PRU Ethernet firmwares for legacy devices | expand |
On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: > Remove the PRU Ethernet firmwares from being packaged for > AM33x, AM43x and AM57x. > Commit messages should give the "why", we can read the code. Are we dropping support for PRUETH from these boards? I still use this, I'm sure others do too. Andrew > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > Changes from v1: > -------------- > * Corrected the commit message. > > meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > index 266a7ef5..317ab1b1 100644 > --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" > > # Add run-time dependency for PRU Ethernet firmware to the rootfs > -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" > -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" > -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" > > base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#16932): https://lists.yoctoproject.org/g/meta-ti/message/16932 > Mute This Topic: https://lists.yoctoproject.org/mt/101234600/3619733 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Andrew, On 9/8/23 7:49 PM, Andrew Davis wrote: > On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: >> Remove the PRU Ethernet firmwares from being packaged for >> AM33x, AM43x and AM57x. >> > > Commit messages should give the "why", we can read the code. I will provide reasoning in the v2. > > Are we dropping support for PRUETH from these boards? I still > use this, I'm sure others do too. > PRUETH drivers for these devices are not upstreamed and PRUTETH will not be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still being worked on. So I wanted to remove these firmwares from being packaged. > Andrew > >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >> --- >> Changes from v1: >> -------------- >> * Corrected the commit message. >> >> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >> index 266a7ef5..317ab1b1 100644 >> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" >> # Add run-time dependency for PRU Ethernet firmware to the rootfs >> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" >> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" >> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >> >> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#16932): https://lists.yoctoproject.org/g/meta-ti/message/16932 >> Mute This Topic: https://lists.yoctoproject.org/mt/101234600/3619733 >> Group Owner: meta-ti+owner@lists.yoctoproject.org >> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
On 9/10/2023 11:28 PM, Ravi Gunasekaran wrote: > Andrew, > > On 9/8/23 7:49 PM, Andrew Davis wrote: >> On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: >>> Remove the PRU Ethernet firmwares from being packaged for >>> AM33x, AM43x and AM57x. >>> >> >> Commit messages should give the "why", we can read the code. > > I will provide reasoning in the v2. > >> >> Are we dropping support for PRUETH from these boards? I still >> use this, I'm sure others do too. >> > > PRUETH drivers for these devices are not upstreamed and PRUTETH will not > be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still > being worked on. So I wanted to remove these firmwares from being packaged. What does upstreaming support have to do with this? The drivers are available in what are we ship now. And if people are currently using this software today then removing it seems like the wrong thing to do. What am I missing? >> Andrew >> >>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>> --- >>> Changes from v1: >>> -------------- >>> * Corrected the commit message. >>> >>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>> index 266a7ef5..317ab1b1 100644 >>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" >>> # Add run-time dependency for PRU Ethernet firmware to the rootfs >>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" >>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" >>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>> >>> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f >>> >>> >>> >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> View/Reply Online (#16932): https://lists.yoctoproject.org/g/meta-ti/message/16932 >>> Mute This Topic: https://lists.yoctoproject.org/mt/101234600/3619733 >>> Group Owner: meta-ti+owner@lists.yoctoproject.org >>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com] >>> -=-=-=-=-=-=-=-=-=-=-=- >>> >
On Mon, Sep 11, 2023 at 09:58:23AM +0530, Ravi Gunasekaran via lists.yoctoproject.org wrote: > Andrew, > > On 9/8/23 7:49 PM, Andrew Davis wrote: > > On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: > >> Remove the PRU Ethernet firmwares from being packaged for > >> AM33x, AM43x and AM57x. > >> > > > > Commit messages should give the "why", we can read the code. > > I will provide reasoning in the v2. > > > > > Are we dropping support for PRUETH from these boards? I still > > use this, I'm sure others do too. > > > > PRUETH drivers for these devices are not upstreamed and PRUTETH will not > be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still > being worked on. So I wanted to remove these firmwares from being packaged. So, besides PRU ETH, what about SW, HSR and PRP firmwares that are being removed here? > >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > >> --- > >> Changes from v1: > >> -------------- > >> * Corrected the commit message. > >> > >> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- > >> 1 file changed, 3 deletions(-) > >> > >> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >> index 266a7ef5..317ab1b1 100644 > >> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" > >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" > >> # Add run-time dependency for PRU Ethernet firmware to the rootfs > >> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" > >> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" > >> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" > >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" > >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" > >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" > >> > >> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f
On 9/11/23 9:02 PM, Ryan Eatmon wrote: > > > On 9/10/2023 11:28 PM, Ravi Gunasekaran wrote: >> Andrew, >> >> On 9/8/23 7:49 PM, Andrew Davis wrote: >>> On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: >>>> Remove the PRU Ethernet firmwares from being packaged for >>>> AM33x, AM43x and AM57x. >>>> >>> >>> Commit messages should give the "why", we can read the code. >> >> I will provide reasoning in the v2. >> >>> >>> Are we dropping support for PRUETH from these boards? I still >>> use this, I'm sure others do too. >>> >> >> PRUETH drivers for these devices are not upstreamed and PRUTETH will not >> be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still >> being worked on. So I wanted to remove these firmwares from being packaged. > > What does upstreaming support have to do with this? The drivers are available in what are we ship now. And if people are currently using this software today then removing it seems like the wrong thing to do. What am I missing? By "what we ship now", do you mean in the SDK? The drivers will be not present in SDK 9.x refresh release for these devices. So I didn't want these firmwares to be packaged as it might give an impression that we somehow support the feature. If there is any other way to prevent the packaging of these firmwares in the SDK, please let me know. > > >>> Andrew >>> >>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>>> --- >>>> Changes from v1: >>>> -------------- >>>> * Corrected the commit message. >>>> >>>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- >>>> 1 file changed, 3 deletions(-) >>>> >>>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>> index 266a7ef5..317ab1b1 100644 >>>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" >>>> # Add run-time dependency for PRU Ethernet firmware to the rootfs >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>>> >>>> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f >>>> >>>> >>>> >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> Links: You receive all messages sent to this group. >>>> View/Reply Online (#16932): https://lists.yoctoproject.org/g/meta-ti/message/16932 >>>> Mute This Topic: https://lists.yoctoproject.org/mt/101234600/3619733 >>>> Group Owner: meta-ti+owner@lists.yoctoproject.org >>>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com] >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> >> >
On 9/11/23 10:35 PM, Denys Dmytriyenko wrote: > On Mon, Sep 11, 2023 at 09:58:23AM +0530, Ravi Gunasekaran via lists.yoctoproject.org wrote: >> Andrew, >> >> On 9/8/23 7:49 PM, Andrew Davis wrote: >>> On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: >>>> Remove the PRU Ethernet firmwares from being packaged for >>>> AM33x, AM43x and AM57x. >>>> >>> >>> Commit messages should give the "why", we can read the code. >> >> I will provide reasoning in the v2. >> >>> >>> Are we dropping support for PRUETH from these boards? I still >>> use this, I'm sure others do too. >>> >> >> PRUETH drivers for these devices are not upstreamed and PRUTETH will not >> be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still >> being worked on. So I wanted to remove these firmwares from being packaged. > > So, besides PRU ETH, what about SW, HSR and PRP firmwares that are being > removed here? Ah ok. I get your perspective. SW, HSR and PRP are different ethernet modes and they have their respective firmwares. In driver space, it is just PRUETH driver and it loads different types of ethernet firmware based on the configuration. I used PRUETH as an umbrella term as that's what is used in our documentation. Based on Ryan's feedback on the approach to remove these firmwares, I will reword the commit message to give this view in v2 > > >>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>>> --- >>>> Changes from v1: >>>> -------------- >>>> * Corrected the commit message. >>>> >>>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- >>>> 1 file changed, 3 deletions(-) >>>> >>>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>> index 266a7ef5..317ab1b1 100644 >>>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" >>>> # Add run-time dependency for PRU Ethernet firmware to the rootfs >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>>> >>>> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f
On 9/11/2023 11:44 PM, Ravi Gunasekaran wrote: > > > On 9/11/23 9:02 PM, Ryan Eatmon wrote: >> >> >> On 9/10/2023 11:28 PM, Ravi Gunasekaran wrote: >>> Andrew, >>> >>> On 9/8/23 7:49 PM, Andrew Davis wrote: >>>> On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: >>>>> Remove the PRU Ethernet firmwares from being packaged for >>>>> AM33x, AM43x and AM57x. >>>>> >>>> >>>> Commit messages should give the "why", we can read the code. >>> >>> I will provide reasoning in the v2. >>> >>>> >>>> Are we dropping support for PRUETH from these boards? I still >>>> use this, I'm sure others do too. >>>> >>> >>> PRUETH drivers for these devices are not upstreamed and PRUTETH will not >>> be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still >>> being worked on. So I wanted to remove these firmwares from being packaged. >> >> What does upstreaming support have to do with this? The drivers are available in what are we ship now. And if people are currently using this software today then removing it seems like the wrong thing to do. What am I missing? > > By "what we ship now", do you mean in the SDK? The drivers will be not present in SDK 9.x refresh release for these devices. > So I didn't want these firmwares to be packaged as it might give an impression that we somehow support the feature. > If there is any other way to prevent the packaging of these firmwares in the SDK, please let me know. You should be able to add a bbappend file in the SDK layer and remove the values you do not want. Something like: linux-ti-staging_%.bbappend --------------------------- RDEPENDS:${KERNEL_PACKAGE_NAME}-base:remove:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:remove:ti43x = " prueth-fw pruhsr-fw pruprp-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:remove:ti33x = " prueth-fw pruhsr-fw pruprp-fw" That way you are not "breaking" the CoreSDK, but you are modifying what is built and released for your installer. >> >> >>>> Andrew >>>> >>>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>>>> --- >>>>> Changes from v1: >>>>> -------------- >>>>> * Corrected the commit message. >>>>> >>>>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- >>>>> 1 file changed, 3 deletions(-) >>>>> >>>>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>> index 266a7ef5..317ab1b1 100644 >>>>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" >>>>> # Add run-time dependency for PRU Ethernet firmware to the rootfs >>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" >>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" >>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>>>> >>>>> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f >>>>> >>>>> >>>>> >>>>> -=-=-=-=-=-=-=-=-=-=-=- >>>>> Links: You receive all messages sent to this group. >>>>> View/Reply Online (#16932): https://lists.yoctoproject.org/g/meta-ti/message/16932 >>>>> Mute This Topic: https://lists.yoctoproject.org/mt/101234600/3619733 >>>>> Group Owner: meta-ti+owner@lists.yoctoproject.org >>>>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com] >>>>> -=-=-=-=-=-=-=-=-=-=-=- >>>>> >>> >> >
On Tue, Sep 12, 2023 at 10:25:38AM +0530, Ravi Gunasekaran wrote: > > > On 9/11/23 10:35 PM, Denys Dmytriyenko wrote: > > On Mon, Sep 11, 2023 at 09:58:23AM +0530, Ravi Gunasekaran via lists.yoctoproject.org wrote: > >> Andrew, > >> > >> On 9/8/23 7:49 PM, Andrew Davis wrote: > >>> On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: > >>>> Remove the PRU Ethernet firmwares from being packaged for > >>>> AM33x, AM43x and AM57x. > >>>> > >>> > >>> Commit messages should give the "why", we can read the code. > >> > >> I will provide reasoning in the v2. > >> > >>> > >>> Are we dropping support for PRUETH from these boards? I still > >>> use this, I'm sure others do too. > >>> > >> > >> PRUETH drivers for these devices are not upstreamed and PRUTETH will not > >> be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still > >> being worked on. So I wanted to remove these firmwares from being packaged. > > > > So, besides PRU ETH, what about SW, HSR and PRP firmwares that are being > > removed here? > > Ah ok. I get your perspective. > > SW, HSR and PRP are different ethernet modes and they have their respective firmwares. > In driver space, it is just PRUETH driver and it loads different types of ethernet > firmware based on the configuration. I used PRUETH as an umbrella term as that's what > is used in our documentation. > > Based on Ryan's feedback on the approach to remove these firmwares, > I will reword the commit message to give this view in v2 Thanks for the explanation - indeed, a bit more details in the commit message would help. > >>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > >>>> --- > >>>> Changes from v1: > >>>> -------------- > >>>> * Corrected the commit message. > >>>> > >>>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- > >>>> 1 file changed, 3 deletions(-) > >>>> > >>>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>> index 266a7ef5..317ab1b1 100644 > >>>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" > >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" > >>>> # Add run-time dependency for PRU Ethernet firmware to the rootfs > >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" > >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" > >>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" > >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" > >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" > >>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" > >>>> > >>>> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f
On 9/12/2023 6:58 PM, Ryan Eatmon wrote: > > > On 9/11/2023 11:44 PM, Ravi Gunasekaran wrote: >> >> >> On 9/11/23 9:02 PM, Ryan Eatmon wrote: >>> >>> >>> On 9/10/2023 11:28 PM, Ravi Gunasekaran wrote: >>>> Andrew, >>>> >>>> On 9/8/23 7:49 PM, Andrew Davis wrote: >>>>> On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote: >>>>>> Remove the PRU Ethernet firmwares from being packaged for >>>>>> AM33x, AM43x and AM57x. >>>>>> >>>>> >>>>> Commit messages should give the "why", we can read the code. >>>> >>>> I will provide reasoning in the v2. >>>> >>>>> >>>>> Are we dropping support for PRUETH from these boards? I still >>>>> use this, I'm sure others do too. >>>>> >>>> >>>> PRUETH drivers for these devices are not upstreamed and PRUTETH will not >>>> be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still >>>> being worked on. So I wanted to remove these firmwares from being packaged. >>> >>> What does upstreaming support have to do with this? The drivers are >>> available in what are we ship now. And if people are currently using this >>> software today then removing it seems like the wrong thing to do. What am I >>> missing? >> >> By "what we ship now", do you mean in the SDK? The drivers will be not >> present in SDK 9.x refresh release for these devices. >> So I didn't want these firmwares to be packaged as it might give an >> impression that we somehow support the feature. >> If there is any other way to prevent the packaging of these firmwares in the >> SDK, please let me know. > > You should be able to add a bbappend file in the SDK layer and remove the > values you do not want. Something like: > > linux-ti-staging_%.bbappend > --------------------------- > > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:remove:am57xx = " prueth-fw prusw-fw > pruhsr-fw pruprp-fw" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:remove:ti43x = " prueth-fw pruhsr-fw > pruprp-fw" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:remove:ti33x = " prueth-fw pruhsr-fw > pruprp-fw" > > > That way you are not "breaking" the CoreSDK, but you are modifying what is > built and released for your installer. > Thanks for your suggestion. I will send out a patch to meta-processor-sdk. > >>> >>> >>>>> Andrew >>>>> >>>>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>>>>> --- >>>>>> Changes from v1: >>>>>> -------------- >>>>>> * Corrected the commit message. >>>>>> >>>>>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- >>>>>> 1 file changed, 3 deletions(-) >>>>>> >>>>>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>>> b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>>> index 266a7ef5..317ab1b1 100644 >>>>>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>>> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " >>>>>> vpdma-fw" >>>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" >>>>>> # Add run-time dependency for PRU Ethernet firmware to the rootfs >>>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw >>>>>> prusw-fw pruhsr-fw pruprp-fw" >>>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw >>>>>> pruhsr-fw pruprp-fw" >>>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw >>>>>> pruhsr-fw pruprp-fw" >>>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" >>>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " >>>>>> prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " >>>>>> prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" >>>>>> >>>>>> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f >>>>>> >>>>>> >>>>>> >>>>>> -=-=-=-=-=-=-=-=-=-=-=- >>>>>> Links: You receive all messages sent to this group. >>>>>> View/Reply Online (#16932): >>>>>> https://lists.yoctoproject.org/g/meta-ti/message/16932 >>>>>> Mute This Topic: https://lists.yoctoproject.org/mt/101234600/3619733 >>>>>> Group Owner: meta-ti+owner@lists.yoctoproject.org >>>>>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com] >>>>>> -=-=-=-=-=-=-=-=-=-=-=- >>>>>> >>>> >>> >> >
diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc index 266a7ef5..317ab1b1 100644 --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " vpdma-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw" # Add run-time dependency for PRU Ethernet firmware to the rootfs -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw pruhsr-fw pruprp-fw" -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw pruprp-fw" -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw pruprp-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2"
Remove the PRU Ethernet firmwares from being packaged for AM33x, AM43x and AM57x. Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> --- Changes from v1: -------------- * Corrected the commit message. meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 --- 1 file changed, 3 deletions(-) base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f