Message ID | 20230824091810.1795629-1-alexis.lothore@bootlin.com |
---|---|
State | Accepted, archived |
Commit | b2c1d8a83a3b2134a8f9a445cbf00103e63ed0b3 |
Headers | show |
Series | oeqa/utils/gitarchive: replace warning with info when reading local tags | expand |
On Thu, 2023-08-24 at 11:18 +0200, Alexis Lothoré via lists.openembedded.org wrote: > From: Alexis Lothoré <alexis.lothore@bootlin.com> > > Whenever a script needs to list tags, if it falls back to the third method > (reading local tags only), it emits a warning. While this warning is useful > for future diagnostic if some tagging issues re-appear, it makes buildperf > autobuilds status as "Passed with warnings", which is not desirable > > Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com> > --- > See [1]: buildperf build has completed without any major issue, but is > still flaggued as "Passed with warnings" because of the log.warning in > gitarchive > > [1] https://autobuilder.yoctoproject.org/typhoon/#/builders/133/builds/2135 > --- > meta/lib/oeqa/utils/gitarchive.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/lib/oeqa/utils/gitarchive.py b/meta/lib/oeqa/utils/gitarchive.py > index ac36ecb3a9ca..64448f47d94e 100644 > --- a/meta/lib/oeqa/utils/gitarchive.py > +++ b/meta/lib/oeqa/utils/gitarchive.py > @@ -128,7 +128,7 @@ def get_tags(repo, log, pattern=None, url=None): > tags_refs = repo.run_cmd(cmd) > tags = ["".join(d.split()[1].split('/', 2)[2:]) for d in tags_refs.splitlines()] > else: > - log.warning("Read local tags only, some remote tags may be missed") > + log.info("Read local tags only, some remote tags may be missed") > cmd = ["tag"] > if pattern: > cmd += ["-l", pattern] Thanks for getting to the bottom of this! I merged them directly so we could see the effect on the buildperf worker and you looked at the results before I managed to report back which was helpful! :) Cheers, Richard
Hi Richard, On 8/25/23 08:41, Richard Purdie wrote: > On Thu, 2023-08-24 at 11:18 +0200, Alexis Lothoré via > lists.openembedded.org wrote: >> From: Alexis Lothoré <alexis.lothore@bootlin.com> >> >> Whenever a script needs to list tags, if it falls back to the third method >> (reading local tags only), it emits a warning. While this warning is useful >> for future diagnostic if some tagging issues re-appear, it makes buildperf >> autobuilds status as "Passed with warnings", which is not desirable >> >> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com> >> --- >> See [1]: buildperf build has completed without any major issue, but is >> still flaggued as "Passed with warnings" because of the log.warning in >> gitarchive >> >> [1] https://autobuilder.yoctoproject.org/typhoon/#/builders/133/builds/2135 >> --- >> meta/lib/oeqa/utils/gitarchive.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/lib/oeqa/utils/gitarchive.py b/meta/lib/oeqa/utils/gitarchive.py >> index ac36ecb3a9ca..64448f47d94e 100644 >> --- a/meta/lib/oeqa/utils/gitarchive.py >> +++ b/meta/lib/oeqa/utils/gitarchive.py >> @@ -128,7 +128,7 @@ def get_tags(repo, log, pattern=None, url=None): >> tags_refs = repo.run_cmd(cmd) >> tags = ["".join(d.split()[1].split('/', 2)[2:]) for d in tags_refs.splitlines()] >> else: >> - log.warning("Read local tags only, some remote tags may be missed") >> + log.info("Read local tags only, some remote tags may be missed") >> cmd = ["tag"] >> if pattern: >> cmd += ["-l", pattern] > > Thanks for getting to the bottom of this! I merged them directly so we > could see the effect on the buildperf worker and you looked at the > results before I managed to report back which was helpful! : Thanks for the quick merges ! And sorry for the mess of the last days builds buildperf worker seems indeed to behave correctly again ([1]), but I only took a look at the build general status since I am not so familiar with those, please do not hesitate to ping me if I am missing any more specific issue which could remain regarding the tagging patches. [1] https://autobuilder.yoctoproject.org/typhoon/#/builders/133/builds/2138 > > Cheers, > > Richard > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#186692): https://lists.openembedded.org/g/openembedded-core/message/186692 > Mute This Topic: https://lists.openembedded.org/mt/100932169/7394887 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexis.lothore@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/lib/oeqa/utils/gitarchive.py b/meta/lib/oeqa/utils/gitarchive.py index ac36ecb3a9ca..64448f47d94e 100644 --- a/meta/lib/oeqa/utils/gitarchive.py +++ b/meta/lib/oeqa/utils/gitarchive.py @@ -128,7 +128,7 @@ def get_tags(repo, log, pattern=None, url=None): tags_refs = repo.run_cmd(cmd) tags = ["".join(d.split()[1].split('/', 2)[2:]) for d in tags_refs.splitlines()] else: - log.warning("Read local tags only, some remote tags may be missed") + log.info("Read local tags only, some remote tags may be missed") cmd = ["tag"] if pattern: cmd += ["-l", pattern]