Message ID | 20230309081036.3179583-3-zboszor@gmail.com |
---|---|
State | Under Review |
Headers | show |
Series | [meta-oe,1/3] opencl-icd-loader: Add RPROVIDES:${PN} = "virtual/opencl-icd" | expand |
> -----Original Message----- > From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Zoltan Boszormenyi > Sent: den 9 mars 2023 09:11 > To: openembedded-devel@lists.openembedded.org > Cc: Zoltán Böszörményi <zboszor@gmail.com> > Subject: [oe] [meta-oe][PATCH 3/3] meta-oe/conf/layer.conf: Add PREFERRED_[R]PROVIDER_virtual/opencl-icd > > Select opencl-icd-loader as the preferred provider for both > build and runtime. > > Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> > --- > meta-oe/conf/layer.conf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta-oe/conf/layer.conf b/meta-oe/conf/layer.conf > index a1f50879e..aee1fa786 100644 > --- a/meta-oe/conf/layer.conf > +++ b/meta-oe/conf/layer.conf > @@ -50,6 +50,8 @@ PREFERRED_RPROVIDER_libdevmapper = "lvm2" > PREFERRED_PROVIDER_android-tools-conf ?= "android-tools-conf" > # Configures whether coreutils or uutils-coreutils is used. > PREFERRED_PROVIDER_coreutils = "coreutils" > +PREFERRED_PROVIDER_virtual/opencl-icd ?= "opencl-icd-loader" > +PREFERRED_RPROVIDER_virtual/opencl-icd ?= "opencl-icd-loader" There are no runtime dependencies on virtual/opencl-icd in meta-openembedded. Runtime dependencies on virtual/... are also considered wrong as they do not work as expected (they only work as long as you do not try to create a package feed AFAIUI, which is why OE-Core uses VIRTUAL-RUNTIME_... instead). So why do you need to set PREFERRED_RPROVIDER_virtual/opencl-icd (and add the corresponding RPROVIDES:${PN} to ocl-icd and opencl-icd-loader)? > > SIGGEN_EXCLUDERECIPES_ABISAFE += " \ > fbset-modes \ > -- > 2.39.2 //Peter
Zoltan: Any comments to my question below? //Peter > -----Original Message----- > From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Peter Kjellerstedt > Sent: den 26 april 2023 19:30 > To: Zoltan Boszormenyi <zboszor@gmail.com> > Cc: openembedded-devel@lists.openembedded.org > Subject: Re: [oe] [meta-oe][PATCH 3/3] meta-oe/conf/layer.conf: Add PREFERRED_[R]PROVIDER_virtual/opencl-icd > > > -----Original Message----- > > From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Zoltan Boszormenyi > > Sent: den 9 mars 2023 09:11 > > To: openembedded-devel@lists.openembedded.org > > Cc: Zoltán Böszörményi <zboszor@gmail.com> > > Subject: [oe] [meta-oe][PATCH 3/3] meta-oe/conf/layer.conf: Add PREFERRED_[R]PROVIDER_virtual/opencl-icd > > > > Select opencl-icd-loader as the preferred provider for both > > build and runtime. > > > > Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> > > --- > > meta-oe/conf/layer.conf | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/meta-oe/conf/layer.conf b/meta-oe/conf/layer.conf > > index a1f50879e..aee1fa786 100644 > > --- a/meta-oe/conf/layer.conf > > +++ b/meta-oe/conf/layer.conf > > @@ -50,6 +50,8 @@ PREFERRED_RPROVIDER_libdevmapper = "lvm2" > > PREFERRED_PROVIDER_android-tools-conf ?= "android-tools-conf" > > # Configures whether coreutils or uutils-coreutils is used. > > PREFERRED_PROVIDER_coreutils = "coreutils" > > +PREFERRED_PROVIDER_virtual/opencl-icd ?= "opencl-icd-loader" > > +PREFERRED_RPROVIDER_virtual/opencl-icd ?= "opencl-icd-loader" > > There are no runtime dependencies on virtual/opencl-icd in meta-openembedded. > Runtime dependencies on virtual/... are also considered wrong as they > do not work as expected (they only work as long as you do not try to > create a package feed AFAIUI, which is why OE-Core uses VIRTUAL-RUNTIME_... > instead). So why do you need to set PREFERRED_RPROVIDER_virtual/opencl-icd > (and add the corresponding RPROVIDES:${PN} to ocl-icd and opencl-icd-loader)? > > > > > SIGGEN_EXCLUDERECIPES_ABISAFE += " \ > > fbset-modes \ > > -- > > 2.39.2 > > //Peter
2023. 04. 26. 19:29 keltezéssel, Peter Kjellerstedt írta: >> -----Original Message----- >> From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Zoltan Boszormenyi >> Sent: den 9 mars 2023 09:11 >> To: openembedded-devel@lists.openembedded.org >> Cc: Zoltán Böszörményi <zboszor@gmail.com> >> Subject: [oe] [meta-oe][PATCH 3/3] meta-oe/conf/layer.conf: Add PREFERRED_[R]PROVIDER_virtual/opencl-icd >> >> Select opencl-icd-loader as the preferred provider for both >> build and runtime. >> >> Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> >> --- >> meta-oe/conf/layer.conf | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta-oe/conf/layer.conf b/meta-oe/conf/layer.conf >> index a1f50879e..aee1fa786 100644 >> --- a/meta-oe/conf/layer.conf >> +++ b/meta-oe/conf/layer.conf >> @@ -50,6 +50,8 @@ PREFERRED_RPROVIDER_libdevmapper = "lvm2" >> PREFERRED_PROVIDER_android-tools-conf ?= "android-tools-conf" >> # Configures whether coreutils or uutils-coreutils is used. >> PREFERRED_PROVIDER_coreutils = "coreutils" >> +PREFERRED_PROVIDER_virtual/opencl-icd ?= "opencl-icd-loader" >> +PREFERRED_RPROVIDER_virtual/opencl-icd ?= "opencl-icd-loader" > There are no runtime dependencies on virtual/opencl-icd in meta-openembedded. > Runtime dependencies on virtual/... are also considered wrong as they > do not work as expected (they only work as long as you do not try to > create a package feed AFAIUI, which is why OE-Core uses VIRTUAL-RUNTIME_... > instead). So why do you need to set PREFERRED_RPROVIDER_virtual/opencl-icd > (and add the corresponding RPROVIDES:${PN} to ocl-icd and opencl-icd-loader)? See this mail thread: https://lists.openembedded.org/g/openembedded-core/topic/97477512#178183 > >> SIGGEN_EXCLUDERECIPES_ABISAFE += " \ >> fbset-modes \ >> -- >> 2.39.2 > //Peter >
diff --git a/meta-oe/conf/layer.conf b/meta-oe/conf/layer.conf index a1f50879e..aee1fa786 100644 --- a/meta-oe/conf/layer.conf +++ b/meta-oe/conf/layer.conf @@ -50,6 +50,8 @@ PREFERRED_RPROVIDER_libdevmapper = "lvm2" PREFERRED_PROVIDER_android-tools-conf ?= "android-tools-conf" # Configures whether coreutils or uutils-coreutils is used. PREFERRED_PROVIDER_coreutils = "coreutils" +PREFERRED_PROVIDER_virtual/opencl-icd ?= "opencl-icd-loader" +PREFERRED_RPROVIDER_virtual/opencl-icd ?= "opencl-icd-loader" SIGGEN_EXCLUDERECIPES_ABISAFE += " \ fbset-modes \
Select opencl-icd-loader as the preferred provider for both build and runtime. Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> --- meta-oe/conf/layer.conf | 2 ++ 1 file changed, 2 insertions(+)