From patchwork Fri May 13 09:40:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiaqing Zhao X-Patchwork-Id: 7995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC5E6C433EF for ; Fri, 13 May 2022 09:40:49 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.6252.1652434844592587848 for ; Fri, 13 May 2022 02:40:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=joiVOCmG; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.115, mailfrom: jiaqing.zhao@linux.intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652434844; x=1683970844; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IhZfbsTkcfFZTBqI1ZWlf9/pDHM+12tyNJP0folu3BE=; b=joiVOCmGwjPeKeHZ9NDM2D95ZLlakmwgiIOuy2jfNVt9119FeaXHQWXv Euhds//jEsIAbkg6NbNDBimYLGz6l+GeJVIIHNogKWZM5s23hjXVVL0l8 74H3za73DKER+sf0kZtYPk0O/lyWKZdA938D1bi1gPKHmL2iDW50uY8J5 oxL/UOtnVOL8iovn9lwQUKNUhbvjd9WKwce3xj1lAC2YmS7vyE8kOnWKt gGznaUBdG9Z9o5wD+woyUV6MgD65jnxIOlr+tnO0zteMuMQH9j/eGY2KS DrVJ2hqJXY8eL7kz0+H5/KcS7dftVa7CQC4JNYSeqfeQfjggwDeF9H+Uj w==; X-IronPort-AV: E=McAfee;i="6400,9594,10345"; a="270399117" X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="270399117" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 02:40:44 -0700 X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="595144089" Received: from unknown (HELO jiaqingz-bmcdev-container.sh.intel.com) ([10.239.138.232]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 02:40:42 -0700 From: Jiaqing Zhao To: openembedded-core@lists.openembedded.org Cc: davide.gardenal@huawei.com, Jiaqing Zhao , Richard Purdie Subject: [kirkstone] [PATCH v3 1/3] sed: Specify shell for "nobody" user in run-ptest Date: Fri, 13 May 2022 17:40:14 +0800 Message-Id: <20220513094016.3345337-2-jiaqing.zhao@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220513094016.3345337-1-jiaqing.zhao@linux.intel.com> References: <20220513094016.3345337-1-jiaqing.zhao@linux.intel.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 13 May 2022 09:40:49 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/165549 ptest testsuite/panic-tests.sh of sed need to be run as a non-root user so that the expected "sed: couldn't open temporary file : Permission denied" error can be generated. After disabling default shell for "nobody", a shell needs to be specified for running ptest. Signed-off-by: Jiaqing Zhao Signed-off-by: Richard Purdie (cherry picked from commit c6d7216772f76af4429fdaaca518858cf014293f) --- meta/recipes-extended/sed/sed/run-ptest | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-extended/sed/sed/run-ptest b/meta/recipes-extended/sed/sed/run-ptest index 993d7d5d75..0460c7961f 100644 --- a/meta/recipes-extended/sed/sed/run-ptest +++ b/meta/recipes-extended/sed/sed/run-ptest @@ -2,4 +2,4 @@ chown nobody testsuite chown nobody ../ptest -su nobody -c "make test-suite.log" +su nobody -s /bin/sh -c "make test-suite.log" From patchwork Fri May 13 09:40:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiaqing Zhao X-Patchwork-Id: 7996 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC81C433FE for ; Fri, 13 May 2022 09:40:49 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.6288.1652434846878843779 for ; Fri, 13 May 2022 02:40:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WLWKbNNB; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.115, mailfrom: jiaqing.zhao@linux.intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652434846; x=1683970846; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bhsO+lCuLQ/dPyFEga4BoB9exhO40HuzCU1Ida2bhIU=; b=WLWKbNNBZs0PKgSoT9/cnlgbird7eQfWEiGghqv++7iRmGQSDOAVs2Fz YmwQTcQ4jwxGYujnk0vKkcEzBM+0p2Icyvcfo0wR/T3HNVa+QH32xE0HE 1PyAsGu+AtCLQ3ZeuGDUYzCYzA0f7tzr4DKtwAdyo5S/zSlyzYgMhq+cS ICA/7Nn0bk1iI5PXoxWTATOn9/opXrGy/bDL4FLlLw4L1bkL+QCn+G8mF 1asvefArwa4tOCM74FUYXQmM9xipumCSTKtYxlN083VDJE9Bcv1e7S9XH jmGRrZPnmgujC5frlI7auxtUkwyV3HqloXM4sCQX/rQ5/8fB/V4hLJBCm A==; X-IronPort-AV: E=McAfee;i="6400,9594,10345"; a="270399121" X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="270399121" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 02:40:45 -0700 X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="595144113" Received: from unknown (HELO jiaqingz-bmcdev-container.sh.intel.com) ([10.239.138.232]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 02:40:44 -0700 From: Jiaqing Zhao To: openembedded-core@lists.openembedded.org Cc: davide.gardenal@huawei.com, Jiaqing Zhao , Richard Purdie Subject: [kirkstone] [PATCH v3 2/3] strace: Don't run ptest as "nobody" Date: Fri, 13 May 2022 17:40:15 +0800 Message-Id: <20220513094016.3345337-3-jiaqing.zhao@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220513094016.3345337-1-jiaqing.zhao@linux.intel.com> References: <20220513094016.3345337-1-jiaqing.zhao@linux.intel.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 13 May 2022 09:40:49 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/165550 strace ptests can run successfully with root user, there is no need to run as "nobody". The ptest results are the same. Signed-off-by: Jiaqing Zhao Signed-off-by: Richard Purdie (cherry picked from commit 5ab213178c011152e29dfb0a80251c5e5ab79900) --- meta/recipes-devtools/strace/strace/run-ptest | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/meta/recipes-devtools/strace/strace/run-ptest b/meta/recipes-devtools/strace/strace/run-ptest index 02bb91e07f..86daed9220 100755 --- a/meta/recipes-devtools/strace/strace/run-ptest +++ b/meta/recipes-devtools/strace/strace/run-ptest @@ -3,11 +3,7 @@ set -u export TIMEOUT_DURATION=240 -chown nobody tests -chown nobody tests/* -chown nobody ../ptest - -su nobody -c "make -B -C tests -k test-suite.log" +make -B -C tests -k test-suite.log res=$? if [ $res -ne 0 ]; then cat tests/test-suite.log From patchwork Fri May 13 09:40:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiaqing Zhao X-Patchwork-Id: 7997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D67F0C43217 for ; Fri, 13 May 2022 09:40:49 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.6288.1652434846878843779 for ; Fri, 13 May 2022 02:40:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=iE3yRjpj; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.115, mailfrom: jiaqing.zhao@linux.intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652434848; x=1683970848; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VYQyYejM5juxuY+tLnKxG4yQwZ529kKImW1FZ8x6YYk=; b=iE3yRjpjkknEC7q7jbC3YvqKVcoUoSP5nrEFBUn9FEUUfZPYdib5ZtqX sCHU335mx8K85KhcILXXcLAaxjFVWwMwCJL2ux760hiU4zC0BXrJ0r49S JGBQ5VepPT2aMrrE4wehfv7LNIJOsjerF30hW+AZ0Bh3Tyju7pM9bakdm 7PFZSltbdri/KNkRfdcIRBnFMMojy2fTV2kpXmlsdO0/w4PSDspATzTqi FLwKnkWbtYACg4vPiAmBdQf+OywGqCFplZ++H3vM2xbPicdBxY46LIM8u HzdyUnMwG20Tl7LCZZOyf1EtE1G0nrPNR78Favfun/tFPLT0siLNmjD9f Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10345"; a="270399133" X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="270399133" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 02:40:47 -0700 X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="595144130" Received: from unknown (HELO jiaqingz-bmcdev-container.sh.intel.com) ([10.239.138.232]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 02:40:45 -0700 From: Jiaqing Zhao To: openembedded-core@lists.openembedded.org Cc: davide.gardenal@huawei.com, Davide Gardenal , Jiaqing Zhao , Richard Purdie Subject: [kirkstone] [PATCH v3 3/3] base-passwd: Disable shell for default users Date: Fri, 13 May 2022 17:40:16 +0800 Message-Id: <20220513094016.3345337-4-jiaqing.zhao@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220513094016.3345337-1-jiaqing.zhao@linux.intel.com> References: <20220513094016.3345337-1-jiaqing.zhao@linux.intel.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 13 May 2022 09:40:49 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/165551 From: Davide Gardenal Change the shell of all global static users other than root (which retains /bin/sh) and sync (as /bin/sync is rather harmless) to /sbin/nologin (as /usr/sbin/nologin does not exist in openembedded) Upstream-Status: Backport [https://launchpad.net/ubuntu/+source/base-passwd/3.5.30] Signed-off-by: Jiaqing Zhao Signed-off-by: Richard Purdie (cherry picked from commit ba3bc4d7a0a39a96f6e8d340e1b2654d47475f07) Signed-off-by: Davide Gardenal --- .../base-passwd/disable-shell.patch | 57 +++++++++++++++++++ .../base-passwd/base-passwd_3.5.29.bb | 1 + 2 files changed, 58 insertions(+) create mode 100644 meta/recipes-core/base-passwd/base-passwd/disable-shell.patch diff --git a/meta/recipes-core/base-passwd/base-passwd/disable-shell.patch b/meta/recipes-core/base-passwd/base-passwd/disable-shell.patch new file mode 100644 index 0000000000..bfaa786018 --- /dev/null +++ b/meta/recipes-core/base-passwd/base-passwd/disable-shell.patch @@ -0,0 +1,57 @@ +From 91e0db96741359173ddf2be083aafcc1a3c32472 Mon Sep 17 00:00:00 2001 +From: Jiaqing Zhao +Date: Mon, 18 Apr 2022 11:22:43 +0800 +Subject: [PATCH] Disable shell for default users + +Change the shell of all global static users other than root (which +retains /bin/sh) and sync (as /bin/sync is rather harmless) to +/sbin/nologin (as /usr/sbin/nologin does not exist in openembedded) + +Upstream-Status: Backport [https://launchpad.net/ubuntu/+source/base-passwd/3.5.30] +Signed-off-by: Jiaqing Zhao +--- + passwd.master | 32 ++++++++++++++++---------------- + 1 file changed, 16 insertions(+), 16 deletions(-) + +diff --git a/passwd.master b/passwd.master +index e1c32ff..0cd5ffd 100644 +--- a/passwd.master ++++ b/passwd.master +@@ -1,18 +1,18 @@ + root::0:0:root:/root:/bin/sh +-daemon:*:1:1:daemon:/usr/sbin:/bin/sh +-bin:*:2:2:bin:/bin:/bin/sh +-sys:*:3:3:sys:/dev:/bin/sh ++daemon:*:1:1:daemon:/usr/sbin:/sbin/nologin ++bin:*:2:2:bin:/bin:/sbin/nologin ++sys:*:3:3:sys:/dev:/sbin/nologin + sync:*:4:65534:sync:/bin:/bin/sync +-games:*:5:60:games:/usr/games:/bin/sh +-man:*:6:12:man:/var/cache/man:/bin/sh +-lp:*:7:7:lp:/var/spool/lpd:/bin/sh +-mail:*:8:8:mail:/var/mail:/bin/sh +-news:*:9:9:news:/var/spool/news:/bin/sh +-uucp:*:10:10:uucp:/var/spool/uucp:/bin/sh +-proxy:*:13:13:proxy:/bin:/bin/sh +-www-data:*:33:33:www-data:/var/www:/bin/sh +-backup:*:34:34:backup:/var/backups:/bin/sh +-list:*:38:38:Mailing List Manager:/var/list:/bin/sh +-irc:*:39:39:ircd:/var/run/ircd:/bin/sh +-gnats:*:41:41:Gnats Bug-Reporting System (admin):/var/lib/gnats:/bin/sh +-nobody:*:65534:65534:nobody:/nonexistent:/bin/sh ++games:*:5:60:games:/usr/games:/sbin/nologin ++man:*:6:12:man:/var/cache/man:/sbin/nologin ++lp:*:7:7:lp:/var/spool/lpd:/sbin/nologin ++mail:*:8:8:mail:/var/mail:/sbin/nologin ++news:*:9:9:news:/var/spool/news:/sbin/nologin ++uucp:*:10:10:uucp:/var/spool/uucp:/sbin/nologin ++proxy:*:13:13:proxy:/bin:/sbin/nologin ++www-data:*:33:33:www-data:/var/www:/sbin/nologin ++backup:*:34:34:backup:/var/backups:/sbin/nologin ++list:*:38:38:Mailing List Manager:/var/list:/sbin/nologin ++irc:*:39:39:ircd:/var/run/ircd:/sbin/nologin ++gnats:*:41:41:Gnats Bug-Reporting System (admin):/var/lib/gnats:/sbin/nologin ++nobody:*:65534:65534:nobody:/nonexistent:/sbin/nologin +-- +2.32.0 + diff --git a/meta/recipes-core/base-passwd/base-passwd_3.5.29.bb b/meta/recipes-core/base-passwd/base-passwd_3.5.29.bb index 9a27ad3ab5..ef7792ae49 100644 --- a/meta/recipes-core/base-passwd/base-passwd_3.5.29.bb +++ b/meta/recipes-core/base-passwd/base-passwd_3.5.29.bb @@ -14,6 +14,7 @@ SRC_URI = "https://launchpad.net/debian/+archive/primary/+files/${BPN}_${PV}.tar file://input.patch \ file://disable-docs.patch \ file://kvm.patch \ + file://disable-shell.patch \ " SRC_URI[md5sum] = "6beccac48083fe8ae5048acd062e5421"