From patchwork Mon Oct 23 16:46:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "chris.laplante@agilent.com" X-Patchwork-Id: 32798 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02113C001E0 for ; Mon, 23 Oct 2023 16:46:43 +0000 (UTC) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.70]) by mx.groups.io with SMTP id smtpd.web11.126225.1698079595068530041 for ; Mon, 23 Oct 2023 09:46:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@agilent.com header.s=selector1 header.b=qAM32L30; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: agilent.com, ip: 40.107.92.70, mailfrom: chris.laplante@agilent.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TXNh5pJ4Pyox0obu1WD8MpStD3zxkcupLVNi4W1TkuXxhsbu9yVZkhnge2zDBh1PMpU2ISn1ZCt0UNw418nw3sZ1OljWUqcHNS6ZcddSBFP0xu+YYI5crn48bhXQpGYcnUrpF0jKy/GRCvFwsimiAA9rfHhbRG/qN8/4vhzzL2RIAjjtFAoAkAXQbluSvgRI9qmtYW1r9vKuD19XpGv9pWhIqDII88k6Cx3kmgBlzKhzAaGL6VKZoc/wTR/Y/R6VqEoF2Yce0gCEvHogyYiDcU7JdJ3jogDJP12NX/PSqDyBZPqAIyq87RYfzR6TDw+/Lx3mH6K+XDHMClLjz6wjqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XSaDzWKqqO7zig0Oho7D3eauz+CV/eJq4s2/E3nFgCU=; b=k0Uks78pi942wG4MlGAlYRUok4cRaxdnsDGcx0DZBw4F01j3ftb/rRyI18KrUUzd1VvEjHOJ1AKnSWXnFQNUMsF1d77z4dZ4ZQoduR/G974tdez//759RHxUOVPBPFnZxQIViVytZL7TOW7ljShm2CvmKc+Ur8haA55b9jo+Vmkl5IeWyyYs7kLxAtRRS88Xq00NLxubqr8NqbKUAD/aTxQ3pXcsgXqAj2+MahZrtSPCAeFBL9OootZ/qpeVH4IBaxUOOimRpDo+TDVBywoCevfWIr8WSbRofp21pT2saYzsibPRg78Nx9hcaPATN6TAwWTQYV/ZG+dpstl+G4+18A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.25.218.41) smtp.rcpttodomain=lists.openembedded.org smtp.mailfrom=agilent.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=agilent.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agilent.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XSaDzWKqqO7zig0Oho7D3eauz+CV/eJq4s2/E3nFgCU=; b=qAM32L30wkogrm/Js0quKx7ZJo7NwPn46wgVqPWsogRoyIBOrAlBs15Vjpx/sOWnvB+8mTVmWRcjmg2bn9uztxzmt+X/7sIHxY8stcQuSaXeBFFrAI096KL9osZBtpH/Ab6iEGnMkh6F+Zq0Aw3jvQS2/khDuOJYg0Kk6gQAOWZGE9td3hlqp88pgbT9hfbrwyH4zL8tFZz7GVWxTFQounk7M5v4gRkqDeDEi51QC5oebB19qJ73ggo+sENDUI5XdPRBMz3M7wVdP/o9ynaD8bkmQ3myk+0pYrmjpNg+1oonT8GrPHyC1cMIZqAJxL9UuiHRfZVUB/7Feru5anv8+w== Received: from BN9PR03CA0481.namprd03.prod.outlook.com (2603:10b6:408:130::6) by DM6PR12MB4450.namprd12.prod.outlook.com (2603:10b6:5:28e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31; Mon, 23 Oct 2023 16:46:32 +0000 Received: from BN8NAM12FT110.eop-nam12.prod.protection.outlook.com (2603:10b6:408:130:cafe::9) by BN9PR03CA0481.outlook.office365.com (2603:10b6:408:130::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Mon, 23 Oct 2023 16:46:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.25.218.41) smtp.mailfrom=agilent.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=agilent.com; Received-SPF: Pass (protection.outlook.com: domain of agilent.com designates 192.25.218.41 as permitted sender) receiver=protection.outlook.com; client-ip=192.25.218.41; helo=edgeappmail.agilent.com; pr=C Received: from edgeappmail.agilent.com (192.25.218.41) by BN8NAM12FT110.mail.protection.outlook.com (10.13.182.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16 via Frontend Transport; Mon, 23 Oct 2023 16:46:31 +0000 Received: from chris-virtual-machine.localdomain (192.25.126.5) by edgeappmail.agilent.com (192.25.218.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 23 Oct 2023 10:46:23 -0600 From: To: CC: Chris Laplante Subject: [PATCH v2 1/2] codeparser/utils: clean up more deprecated AST usages Date: Mon, 23 Oct 2023 12:46:12 -0400 Message-ID: <20231023164613.1441846-1-chris.laplante@agilent.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM12FT110:EE_|DM6PR12MB4450:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fa38c65-2f3d-4513-8a1f-08dbd3e79c99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UvH1tqAVR2UTKFNrC3OcODPKwQn1eJsheRCAbr2lkrcDFj/BjEjoDBA9lFtmA3vNbH9tAN3ICwm8JqN2CoCFtpuh9MvjmWoLbR1ker8RNdZjCZZ2eYqBdkos/AioOkRfonbPo3WG7ZoU7VRfZtTql2skkcASP/TdhTuKDcWZemckdbrgDLDX30GuVt2baydHNehwOPPRFwuDZf5PwLLLSJtDox64JEM887azKqgOG3McALLDwEXUm+ibHI5vP77VvkvcqzfN7uOk8AnDnUqKKrVuL7fLdlUu0sJZPqBfcHNsCP8XNxRF9XoqHR11NgpsCow2YziXLapUGCxfzVejxMDVKmKJe0ljpL/FYdItLuYTrLKd2+/VU6eUmI3hBrFW0l3bAmv5ChNFFSyc/NTFUEHnXHDQ3SlDMqVtt9FfIvKvIDrWkZDwBjQKcxs4lSMIr8Z0x33ARksqQzOpmS31DgawII7Hk5oSNnbFr27TZpX594EmEdYSZWrMJ7eYiSvhG82aP2QET7WCDbX5dDwgsRp5FQp0Y5Bv2T7qcBvXCWe6lJFPwl/NzTPY1a5myjdZUkWLfVXDd3u5WcgHESWShiCgtHh5TY84+NwW9yGUvM2WsCEUvI0/Sr+3732s9g17WzpiN5md4Zxh7yZHvO5JnaHlihM69tYO5bfB1rGJqbI+yVuOcG5NNiTugQ68R6py9RYyCeg7TOMRSOAMxlsZaS9lriKpPIrWVW5531b1qI0= X-Forefront-Antispam-Report: CIP:192.25.218.41;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edgeappmail.agilent.com;PTR:exch.smtp.agilent.com;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(376002)(346002)(396003)(136003)(230922051799003)(451199024)(82310400011)(64100799003)(186009)(1800799009)(46966006)(36840700001)(40470700004)(40460700003)(40480700001)(86362001)(70206006)(41300700001)(6916009)(316002)(6666004)(5660300002)(478600001)(8676002)(36756003)(8936002)(4326008)(36860700001)(2906002)(2876002)(356005)(7636003)(1076003)(26005)(2616005)(956004)(336012)(426003)(107886003)(47076005)(82740400003)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: agilent.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:46:31.9865 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2fa38c65-2f3d-4513-8a1f-08dbd3e79c99 X-MS-Exchange-CrossTenant-Id: a9c0bc09-8b46-4206-9351-2ba12fb4a5c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a9c0bc09-8b46-4206-9351-2ba12fb4a5c0;Ip=[192.25.218.41];Helo=[edgeappmail.agilent.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN8NAM12FT110.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4450 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 23 Oct 2023 16:46:42 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/15275 From: Chris Laplante Also introduces bb.utils.ast_node_str_value method to simplify handling of AST str nodes. Signed-off-by: Chris Laplante --- lib/bb/codeparser.py | 22 ++++++++++------------ lib/bb/utils.py | 10 ++++++++++ 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/lib/bb/codeparser.py b/lib/bb/codeparser.py index cd39409434..92ed31fa5f 100644 --- a/lib/bb/codeparser.py +++ b/lib/bb/codeparser.py @@ -256,19 +256,18 @@ class PythonParser(): def visit_Call(self, node): name = self.called_node_name(node.func) if name and (name.endswith(self.getvars) or name.endswith(self.getvarflags) or name in self.containsfuncs or name in self.containsanyfuncs): - if isinstance(node.args[0], ast.Constant) and isinstance(node.args[0].value, str): - varname = node.args[0].value - if name in self.containsfuncs and isinstance(node.args[1], ast.Str): + if (varname := bb.utils.ast_node_str_value(node.args[0])) is not None: + if name in self.containsfuncs and bb.utils.ast_node_str_value(node.args[1]) is not None: if varname not in self.contains: self.contains[varname] = set() - self.contains[varname].add(node.args[1].s) - elif name in self.containsanyfuncs and isinstance(node.args[1], ast.Str): + self.contains[varname].add(node.args[1].value) + elif name in self.containsanyfuncs and bb.utils.ast_node_str_value(node.args[1]) is not None: if varname not in self.contains: self.contains[varname] = set() - self.contains[varname].update(node.args[1].s.split()) + self.contains[varname].update(node.args[1].value.split()) elif name.endswith(self.getvarflags): - if isinstance(node.args[1], ast.Str): - self.references.add('%s[%s]' % (varname, node.args[1].s)) + if bb.utils.ast_node_str_value(node.args[1]) is not None: + self.references.add('%s[%s]' % (varname, node.args[1].value)) else: self.warn(node.func, node.args[1]) else: @@ -276,8 +275,7 @@ class PythonParser(): else: self.warn(node.func, node.args[0]) elif name and name.endswith(".expand"): - if isinstance(node.args[0], ast.Str): - value = node.args[0].s + if (value := bb.utils.ast_node_str_value(node.args[0])) is not None: d = bb.data.init() parser = d.expandWithRefs(value, self.name) self.references |= parser.references @@ -287,8 +285,8 @@ class PythonParser(): self.contains[varname] = set() self.contains[varname] |= parser.contains[varname] elif name in self.execfuncs: - if isinstance(node.args[0], ast.Str): - self.var_execs.add(node.args[0].s) + if bb.utils.ast_node_str_value(node.args[0]) is not None: + self.var_execs.add(node.args[0].value) else: self.warn(node.func, node.args[0]) elif name and isinstance(node.func, (ast.Name, ast.Attribute)): diff --git a/lib/bb/utils.py b/lib/bb/utils.py index b401fa5ec7..0ac304163c 100644 --- a/lib/bb/utils.py +++ b/lib/bb/utils.py @@ -11,6 +11,7 @@ import re, fcntl, os, string, stat, shutil, time import sys import errno import logging +import ast import bb import bb.msg import locale @@ -33,6 +34,7 @@ import random import socket import struct import tempfile +from typing import Optional from subprocess import getstatusoutput from contextlib import contextmanager from ctypes import cdll @@ -1863,3 +1865,11 @@ def lock_timeout(lock): yield held finally: lock.release() + +def ast_node_str_value(node: ast.AST) -> Optional[str]: + """ + Returns node value if it is an `ast.Constant` str; None otherwise + """ + if isinstance(node, ast.Constant) and isinstance(node.value, str): + return node.value + return None From patchwork Mon Oct 23 16:46:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "chris.laplante@agilent.com" X-Patchwork-Id: 32797 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA5AC004C0 for ; Mon, 23 Oct 2023 16:46:43 +0000 (UTC) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.126226.1698079596810496921 for ; Mon, 23 Oct 2023 09:46:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@agilent.com header.s=selector1 header.b=qlV516Aq; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: agilent.com, ip: 40.107.236.40, mailfrom: chris.laplante@agilent.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMewdd7Dpgrgr/3FCKooUATJaXjZC6dxerZjAwq78Fn0jgJTymIoCwhL4ZD2Zl4Yt3Blcl4NUM67qdqqs1rDLHoWTGUa+ntezhQpLVgZ5uPl0cR0Ll5kaXCwpIKgct1FlhUpeSy7oqevZ2L/ms2yzzHZdb0SLVSyZLO60MjWvOqoDBFxmnxAsWVjqQWrZgn1qkCEBRq9WHffVoOsKDzv3MjpM1dTXoxTh1po9culUHj/iq2si3ktn74Ekc4avY/x56RBnAQgZonATXTkFzVwH/HSK4JnhNgnKS5narcBlZjGrOXgnLpEc+Y0Sm7LBtJ4aAsuX1s8PjgqHDwA+VOumA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZeiB2NZXWvA9Gg/E0O0NVN7vEgBi3GXmcr+E4WdRow=; b=VWyFpx0KeCbCpmXmA6qh3ZNxniRDmdU7UrNDGNBGlesPXJY6pKyQ65Yy/ITY3elzHHPKtkrU/Be8wSpUFXIhIdb3PGFFksVyDWjpleKcYkkdXnbX8ZBZjWq7oii0UPR0onZbQzIO0yh8brs+CEokKIrwtdAuePPu19KW0mecJXEjKoQTLi1jqAONvjr93CwJXJ0uMOvJg1tqvZeEllEXufDqCjv5aJrLQofWPFYodgOfTj2Ijh3lr92BAH6NNx740cTEAjLy7aW88blEZHBT65dr01p+VhvCo3lJxmmHPC7/GkpKY5GlWyrJOUzwqniPNKKlCPX2pJ29Oa6hpOm7JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.25.218.41) smtp.rcpttodomain=lists.openembedded.org smtp.mailfrom=agilent.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=agilent.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agilent.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZeiB2NZXWvA9Gg/E0O0NVN7vEgBi3GXmcr+E4WdRow=; b=qlV516Aq5XSSf1PQal3MfmmZExUAD7m5KTyTonZ1g0yJq2+DJyPKEWElo0RaoUW7CVZ19Huo9qRwU1KY3ruYJus/x4paSA3Dfg5jqeSa/g2J/gZL2D+tfAXKBPMmAEL/csWGdnIUmxqIULlmcQT+1p6d9G127Igz1cfVgdp3w6si/AB+O9zPtLg8gYUjzIOXhkju64H0onP7BVrz8cUg1NR70ZYq2kxVvLS126+FTZ18MOfiybBPtxlYbyf73x5CRKfdwDDm5ReCCUIP768X8z3Wc0Fawn1lzCcjkSSVWpCCHuQYBkqC5A0rliNHBVctrpMe3BEWFZhyAUTf+3TP1A== Received: from BN8PR04CA0016.namprd04.prod.outlook.com (2603:10b6:408:70::29) by PH7PR12MB7212.namprd12.prod.outlook.com (2603:10b6:510:207::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Mon, 23 Oct 2023 16:46:34 +0000 Received: from BN8NAM12FT022.eop-nam12.prod.protection.outlook.com (2603:10b6:408:70:cafe::f8) by BN8PR04CA0016.outlook.office365.com (2603:10b6:408:70::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Mon, 23 Oct 2023 16:46:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.25.218.41) smtp.mailfrom=agilent.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=agilent.com; Received-SPF: Pass (protection.outlook.com: domain of agilent.com designates 192.25.218.41 as permitted sender) receiver=protection.outlook.com; client-ip=192.25.218.41; helo=edgeappmail.agilent.com; pr=C Received: from edgeappmail.agilent.com (192.25.218.41) by BN8NAM12FT022.mail.protection.outlook.com (10.13.183.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.18 via Frontend Transport; Mon, 23 Oct 2023 16:46:33 +0000 Received: from chris-virtual-machine.localdomain (192.25.126.5) by edgeappmail.agilent.com (192.25.218.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 23 Oct 2023 10:46:24 -0600 From: To: CC: Chris Laplante Subject: [PATCH v2 2/2] codegen: cleanup deprecated AST usages Date: Mon, 23 Oct 2023 12:46:13 -0400 Message-ID: <20231023164613.1441846-2-chris.laplante@agilent.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023164613.1441846-1-chris.laplante@agilent.com> References: <20231023164613.1441846-1-chris.laplante@agilent.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM12FT022:EE_|PH7PR12MB7212:EE_ X-MS-Office365-Filtering-Correlation-Id: 771a8ed3-089f-44e0-893d-08dbd3e79d89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LioDDTPVCCwlRVV2GIZGemOWTdCPHxpIbgaUSHBtLj6PkFHydYOd1K1hG2aEdDPDe3stkDdkPBIEFWs+bLR12OuIXkwnFqigBoC9TMk/fK0MJd7VCTFhxY5O53fPiagGSBQuusbxXLF3MdD4U0whwh/h5n8l2f4OlXp1qk4RdDQy7NDPV1fHbx22kSx98V/jCq3QPmErLFG2X+6+K3K8Dvqit3siwDFIxjwKIj9pRb6gxkPJfsNk5RsWwwEufzpfKw8tkE9PD0MmFv6oZKTLhVqtVxbNcBfUBW9ujbgdw12tPYtBQE+S2y01Y0WdmTN0bHdHQ14TCdImFhrSKq5yNB+U74P5akXyU06ZPmKAwQzVPviqcK7wB/OrwA/X1o9l0LVbCkAUTHfBaKF25yBAJwc8lm1eUaukLKvuO1mFPDz2kfDpKuoRqxAaJW4Xebe9clidJP9bqhKe3vWX3miF6wINUsO6/rzlg6rleMnURF3N93geq2iChcNgEZmaN5GMHl3sdvZCLe0xeOKQ2bY5ny7fKEmR481eEskJDGIAnS+rCm5w3LFc/oBwIxWyLaxG49KeRc5QdWVl1vrjqQhNqpoTjxkdUctf1pHCnnvMhIYAc9X3iNsyOAsMTl+4wuvqrTzWb+rTgmpjIwzUlmrRfIQtRZ5HR9FDeMq8sElmkBPEuwBZ7AmquvJ9S0n+48cnLU1hHaPkhOwTh8c+bFDMiXE5HAy0Hw/S4Pq8dvRMeCa3u3/kt8ciwOJ5w8k8Mpbl X-Forefront-Antispam-Report: CIP:192.25.218.41;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edgeappmail.agilent.com;PTR:exch.smtp.agilent.com;CAT:NONE;SFS:(13230031)(4636009)(136003)(376002)(39860400002)(396003)(346002)(230922051799003)(82310400011)(1800799009)(186009)(451199024)(64100799003)(40470700004)(36840700001)(46966006)(26005)(2906002)(4744005)(2876002)(41300700001)(40460700003)(86362001)(5660300002)(36756003)(36860700001)(8676002)(8936002)(4326008)(956004)(70206006)(107886003)(6666004)(478600001)(7636003)(1076003)(316002)(82740400003)(356005)(6916009)(2616005)(83380400001)(40480700001)(426003)(336012)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: agilent.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:46:33.5593 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 771a8ed3-089f-44e0-893d-08dbd3e79d89 X-MS-Exchange-CrossTenant-Id: a9c0bc09-8b46-4206-9351-2ba12fb4a5c0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a9c0bc09-8b46-4206-9351-2ba12fb4a5c0;Ip=[192.25.218.41];Helo=[edgeappmail.agilent.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN8NAM12FT022.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7212 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 23 Oct 2023 16:46:43 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/15276 From: Chris Laplante This code is just completely dead as of Python 3.8, like the comment says. Signed-off-by: Chris Laplante --- lib/codegen.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/lib/codegen.py b/lib/codegen.py index 6955a7ada5..018b283177 100644 --- a/lib/codegen.py +++ b/lib/codegen.py @@ -392,19 +392,7 @@ class SourceGenerator(NodeVisitor): def visit_Name(self, node): self.write(node.id) - def visit_Str(self, node): - self.write(repr(node.s)) - - def visit_Bytes(self, node): - self.write(repr(node.s)) - - def visit_Num(self, node): - self.write(repr(node.n)) - def visit_Constant(self, node): - # Python 3.8 deprecated visit_Num(), visit_Str(), visit_Bytes(), - # visit_NameConstant() and visit_Ellipsis(). They can be removed once we - # require 3.8+. self.write(repr(node.value)) def visit_Tuple(self, node):