From patchwork Thu Apr 27 07:35:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kanavin X-Patchwork-Id: 23068 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6675EC77B7E for ; Thu, 27 Apr 2023 07:35:41 +0000 (UTC) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web10.14865.1682580936171306454 for ; Thu, 27 Apr 2023 00:35:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=g2zBesz+; spf=pass (domain: gmail.com, ip: 209.85.128.49, mailfrom: alex.kanavin@gmail.com) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-3f09b4a1584so55596335e9.2 for ; Thu, 27 Apr 2023 00:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682580934; x=1685172934; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MVZ7P8nu3gHOdYnH7PabS1edKddumbrCw7vxRb07xdg=; b=g2zBesz+Jcf2Nuve839qBGK3HPWJG1TKNKVZRTJFng90+cRfs9W1CNun3LiyBQVbWZ awEzzNusLmCTTAZt8Axll7h82H6C4IA/g6cynVNNULXm+8xC+FCsUZZFcJciUXqCMqFg f7hXbxMEMZTJZs98MoYTGf5s+05uSIJTAaAOD8uvWpAHlKr5GUvEShmrwDPM1zoNvSai 7aTFwpRZUsBlfdUcce9OHc/6yA1s+/WJPyOSSkpoI6qez1QzImHaUEFoTBDyjuL2XHDt 7RhkVqaY2JC0Ae2eNNk97+VJHswfBUKwQDDF0541KV5necjsbJ98QZhD0deAPJKNmOJW l8NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682580934; x=1685172934; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MVZ7P8nu3gHOdYnH7PabS1edKddumbrCw7vxRb07xdg=; b=WqdJSbH80bhALwkndPEZuN6uEgklYVYJ70KS0IZfV/cRVb62Jo0qyCAPDp46/UKMDI AIeoOFC3O1J6I3hANuLW9tTGmOY2731PWOphVMJRzgKXFnfDr7UkymJbCflaPpzg5kYJ VRF+k050R3cO4Esg8ubyqovrRBcmvBYy2gcwRiaBkAVVkascNCO8UI8xxiB97rb8MVnz crXg1CPn1i2sv/vYwBenTwHryLu+c60bfKzt72R4ww0MeVwl8BTJVSEwneOgzZuS8IS9 TM3Jdmqqq6LS8/F9m1X8K/LgKt5M0+2iERKk7jpjAfrtrIwSf86LaYOefGcmAPkGR804 hrBQ== X-Gm-Message-State: AC+VfDzfrvtgSv6m4Dcr+hJWPRw0tBqYkX3reG8cFGQFdzKEMBVvALSQ X6d/TKjlIC/IlhMBOoewECxDYFYfEfU= X-Google-Smtp-Source: ACHHUZ6fBv8ITQXgGlFt9jU/Q/7L4WTuBfQK7EKHoiSujlAPXq/rOAWQ9Y2ms30zLZj+oA5691XPcA== X-Received: by 2002:adf:cc90:0:b0:2f6:ece3:76a with SMTP id p16-20020adfcc90000000b002f6ece3076amr543959wrj.8.1682580934270; Thu, 27 Apr 2023 00:35:34 -0700 (PDT) Received: from Zen2.lab.linutronix.de. (drugstore.linutronix.de. [80.153.143.164]) by smtp.gmail.com with ESMTPSA id r4-20020adfdc84000000b002f598008d50sm17678411wrj.34.2023.04.27.00.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 00:35:33 -0700 (PDT) From: Alexander Kanavin X-Google-Original-From: Alexander Kanavin To: openembedded-core@lists.openembedded.org Cc: Alexander Kanavin Subject: [PATCH 1/5] insane.bbclass: add a SUMMARY/HOMEPAGE check (oe-core recipes only) Date: Thu, 27 Apr 2023 09:35:24 +0200 Message-Id: <20230427073528.3956414-1-alex@linutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 27 Apr 2023 07:35:41 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/180475 This was done in a selftest, but that is too late and creates friction in integration as errors are not seen until autobuilder fails. Bonus fix: SUMMARY check wasn't even working, as in the absence of one set in the recipe there is a default value set from bitbake.conf. I left DESCRIPTION check out for now, as many recipes don't actually have it, and it's set from SUMMARY (plus a dot) if absent. Signed-off-by: Alexander Kanavin --- meta/classes-global/insane.bbclass | 27 +++++++++++++++- meta/lib/oeqa/selftest/cases/distrodata.py | 36 ---------------------- 2 files changed, 26 insertions(+), 37 deletions(-) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index ee34d5208d1..64ad76c48e9 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -44,7 +44,7 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ already-stripped installed-vs-shipped ldflags compile-host-path \ install-host-path pn-overrides unknown-configure-option \ useless-rpaths rpaths staticdev empty-dirs \ - patch-fuzz patch-status-core\ + patch-fuzz patch-status-core missing-metadata \ " # Add usrmerge QA check based on distro feature ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" @@ -1481,6 +1481,28 @@ python do_qa_unpack() { unpack_check_src_uri(d.getVar('PN'), d) } +python do_qa_fetch() { + def test_missing_metadata(d): + fn = d.getVar("FILE") + if not '/meta/recipes-' in fn: + # We are only interested in OE-Core + return + pn = d.getVar('BPN') + srcfile = d.getVar('SRC_URI').split() + # Check that SUMMARY is not the same as the default from bitbake.conf + if d.getVar('SUMMARY') == d.expand("${PN} version ${PV}-${PR}"): + oe.qa.handle_error("missing-metadata", "Recipe {} in {} does not contain a SUMMARY. Please add an entry.".format(pn, fn), d) + if not d.getVar('HOMEPAGE'): + if srcfile and srcfile[0].startswith('file') or not d.getVar('SRC_URI'): + # We are only interested in recipes SRC_URI fetched from external sources + pass + else: + oe.qa.handle_error("missing-metadata", "Recipe {} in {} does not contain a HOMEPAGE. Please add an entry.".format(pn, fn), d) + + test_missing_metadata(d) + oe.qa.exit_if_errors(d) +} + # Check for patch fuzz do_patch[postfuncs] += "do_qa_patch " @@ -1492,6 +1514,9 @@ do_configure[postfuncs] += "do_qa_configure " # Check does S exist. do_unpack[postfuncs] += "do_qa_unpack" +# Check basic recipe metadata (e.g. SUMMARY/HOMEPAGE/RECIPE_MAINTAINER) +do_fetch[postfuncs] += "do_qa_fetch" + python () { import re diff --git a/meta/lib/oeqa/selftest/cases/distrodata.py b/meta/lib/oeqa/selftest/cases/distrodata.py index b5554a6c3c3..b443f2d3af6 100644 --- a/meta/lib/oeqa/selftest/cases/distrodata.py +++ b/meta/lib/oeqa/selftest/cases/distrodata.py @@ -39,42 +39,6 @@ but their recipes claim otherwise by setting UPSTREAM_VERSION_UNKNOWN. Please re """ + "\n".join(regressed_successes) self.assertTrue(len(regressed_failures) == 0 and len(regressed_successes) == 0, msg) - def test_missing_homepg(self): - """ - Summary: Test for oe-core recipes that don't have a HOMEPAGE or DESCRIPTION - Expected: All oe-core recipes should have a DESCRIPTION entry - Expected: All oe-core recipes should have a HOMEPAGE entry except for recipes that are not fetched from external sources. - Product: oe-core - """ - with bb.tinfoil.Tinfoil() as tinfoil: - tinfoil.prepare(config_only=False) - no_description = [] - no_homepage = [] - for fn in tinfoil.all_recipe_files(variants=False): - if not '/meta/recipes-' in fn: - # We are only interested in OE-Core - continue - rd = tinfoil.parse_recipe_file(fn, appends=False) - pn = rd.getVar('BPN') - srcfile = rd.getVar('SRC_URI').split() - #Since DESCRIPTION defaults to SUMMARY if not set, we are only interested in recipes without DESCRIPTION or SUMMARY - if not (rd.getVar('SUMMARY') or rd.getVar('DESCRIPTION')): - no_description.append((pn, fn)) - if not rd.getVar('HOMEPAGE'): - if srcfile and srcfile[0].startswith('file') or not rd.getVar('SRC_URI'): - # We are only interested in recipes SRC_URI fetched from external sources - continue - no_homepage.append((pn, fn)) - if no_homepage: - self.fail(""" -The following recipes do not have a HOMEPAGE. Please add an entry for HOMEPAGE in the recipe. -""" + "\n".join(['%s (%s)' % i for i in no_homepage])) - - if no_description: - self.fail(""" -The following recipes do not have a DESCRIPTION. Please add an entry for DESCRIPTION in the recipe. -""" + "\n".join(['%s (%s)' % i for i in no_description])) - def test_maintainers(self): """ Summary: Test that oe-core recipes have a maintainer and entries in maintainers list have a recipe From patchwork Thu Apr 27 07:35:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kanavin X-Patchwork-Id: 23067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A63C77B61 for ; Thu, 27 Apr 2023 07:35:41 +0000 (UTC) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web10.14866.1682580936782471914 for ; Thu, 27 Apr 2023 00:35:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=GkVvJ2d0; spf=pass (domain: gmail.com, ip: 209.85.221.49, mailfrom: alex.kanavin@gmail.com) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-2f4214b430aso5064918f8f.0 for ; Thu, 27 Apr 2023 00:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682580935; x=1685172935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=83n04SOHuZEp1nNmaQVjQvrdyN8elF/dTdwG8GljROA=; b=GkVvJ2d0otVIJbLBpfVyaNfLrYJEzZOpit4S6y++HxfRBawuYoKjg5BmzvZCKBiB8t xSHFOnyDv1aaC0cE7qDh5Rly02styi2M6RYOGxApeVfVHHvh9enbLqJFPs/14bWvU24u J8hpwFy42Z5EyC+AY897Cd5sJhdwMC9KRqb1bPxF6CBJvLPWyiN7fCxbZ53YHSE+YYjl Yx7o3T8PMJ6joUELS24Ic6Z/3HhaxjcSgmcPfFzotSNUrQLVtKsWHPa8WjRs4rWKbF8W wqv+5ZIVfcW/ePwluoQLzXxlhPOQJeoDnzjTIHe91DOX4KZ0XCMm4VQosBLGozZkd5VH Q/uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682580935; x=1685172935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=83n04SOHuZEp1nNmaQVjQvrdyN8elF/dTdwG8GljROA=; b=InSceB6xAtqrCn9hWRFq2chlxcPfXx7nU8P0udHd0as4kA9vmOGhnfIN6Tetsww6GU 9d3HLQa/Fbe9DGs0k4MB1NHwCgSuD3jD1hp98LX1IkMlwurl81QUCNmqmOZ8/0dh1tbz U3MvzCbpERiO75wNCEe7hj3v/+er47kcQMt3f/+CntI61NgEtaWwiYxtS3lcEhL6Ae/7 U7xLAWYqx9UJ7qb0WapbsGkYWOemT1ggaix/aJNA94CFnzIU8Sd5S5+RSrjBn4B433lR oevvOZy5JqQil+wZTNwDWmThv6eOb4tKWewYeoWKrz6ZVoGpoVOc/sb/er9gHBYiiE49 b6Ng== X-Gm-Message-State: AC+VfDyL3M556LI0cbydSd5NaFWoMq3rZ0+rY39Q9PLDzd39bLkDeOGt n+j+zL+Zs8ZdE3obl4k6NYkg67f+fjE= X-Google-Smtp-Source: ACHHUZ727lRmRJBL4hDDyLvVD32+IVkaEjMHJgP3sAa8ShB/R+2DKhrJfzpdHxUiNb3FJuhCm8WLkg== X-Received: by 2002:a5d:6884:0:b0:2f2:b71a:40cb with SMTP id h4-20020a5d6884000000b002f2b71a40cbmr506729wru.56.1682580935095; Thu, 27 Apr 2023 00:35:35 -0700 (PDT) Received: from Zen2.lab.linutronix.de. (drugstore.linutronix.de. [80.153.143.164]) by smtp.gmail.com with ESMTPSA id r4-20020adfdc84000000b002f598008d50sm17678411wrj.34.2023.04.27.00.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 00:35:34 -0700 (PDT) From: Alexander Kanavin X-Google-Original-From: Alexander Kanavin To: openembedded-core@lists.openembedded.org Cc: Alexander Kanavin Subject: [PATCH 2/5] selftest/distrodata: clean up exception lists in recipe maintainers test Date: Thu, 27 Apr 2023 09:35:25 +0200 Message-Id: <20230427073528.3956414-2-alex@linutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230427073528.3956414-1-alex@linutronix.de> References: <20230427073528.3956414-1-alex@linutronix.de> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 27 Apr 2023 07:35:41 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/180476 Specifically: - add missing maintainer.inc entries for initramfs-module-*, systemd-machine-units and target-sdk-provides-dummy and drop them from exception list. - remove rust from exception list for unbuildable-by-default recipes as it is now buildable. - add missing maintainer.inc entry for libx11-compose-data and cve-update-nvd2-native; as they are also unbuildable by default, they needs to be in exception list as well. Signed-off-by: Alexander Kanavin --- meta/conf/distro/include/maintainers.inc | 7 +++++++ meta/lib/oeqa/selftest/cases/distrodata.py | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc index 682ec2cfdfb..66f8eb6af3e 100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -129,6 +129,7 @@ RECIPE_MAINTAINER:pn-cryptodev-tests = "Robert Yang " RECIPE_MAINTAINER:pn-cups = "Chen Qi " RECIPE_MAINTAINER:pn-curl = "Robert Joslyn " RECIPE_MAINTAINER:pn-cve-update-db-native = "Ross Burton " +RECIPE_MAINTAINER:pn-cve-update-nvd2-native = "Ross Burton " RECIPE_MAINTAINER:pn-cwautomacros = "Ross Burton " RECIPE_MAINTAINER:pn-db = "Unassigned " RECIPE_MAINTAINER:pn-dbus = "Chen Qi " @@ -278,6 +279,9 @@ RECIPE_MAINTAINER:pn-initramfs-live-install = "Anuj Mittal """ def is_exception(pkg): - exceptions = ["packagegroup-", "initramfs-", "systemd-machine-units", "target-sdk-provides-dummy"] + exceptions = ["packagegroup-",] for i in exceptions: if i in pkg: return True return False def is_maintainer_exception(entry): - exceptions = ["musl", "newlib", "linux-yocto", "linux-dummy", "mesa-gl", "libgfortran", - "cve-update-db-native", "rust"] + exceptions = ["musl", "newlib", "linux-yocto", "linux-dummy", "mesa-gl", "libgfortran", "libx11-compose-data", + "cve-update-db-native","cve-update-nvd2-native",] for i in exceptions: if i in entry: return True From patchwork Thu Apr 27 07:35:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kanavin X-Patchwork-Id: 23065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AE7C7EE23 for ; Thu, 27 Apr 2023 07:35:41 +0000 (UTC) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.web10.14867.1682580937290441352 for ; Thu, 27 Apr 2023 00:35:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=f6PilRS2; spf=pass (domain: gmail.com, ip: 209.85.221.46, mailfrom: alex.kanavin@gmail.com) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-2fddb442d47so7395965f8f.2 for ; Thu, 27 Apr 2023 00:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682580936; x=1685172936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uDYJVna9fwgZouc742hq3janvmGHmyu/RZqxVMr7O4o=; b=f6PilRS23P/Ns7FEIDfglyYXGXb0nwmyCe/C3Deu65+dGZ57kjbDIruHhipbjb+05d 0Jk9aXNy2EiRxoV3d/xakbBh4lXh9nBtA5zVsZtZLWqB5IWi4Fxh9ymYQrEY8BZgHIr1 7paCPvCha3gvmTdMrhoK3OM1z6Zs18kPN5fwvYT7TUwNs7eGM74gse5EG7SkU5xx3tUI MfbAhJxvRueVwhv5pecQipFeqt4fMlx3qZ0ZX2nubrV4wGlHuEGCLPtqDgsm6h2Twm9h 7UGCnx+a2QNbstEBncu8NYLJYa0syWDlbg3W4ENWK8mVIxTTj7iIDeFFHGUjSAI69tsa zugQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682580936; x=1685172936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uDYJVna9fwgZouc742hq3janvmGHmyu/RZqxVMr7O4o=; b=VaFrd/mPA0miMNRs4BQZBDDxG1TbDdGSNP83rvisWPyytIgXoDQNAOaPM/ETTNeV/o s6NRMMaAPgp6yCXUidV2an6wX9fzXXSa3MxhtjMk49ZyFtCP/FxRieoYAFMZVH/cy6Mf ML9Qias+SU9FbJaQ2b52j5+kHASznCwfPsYA6WLrZpAv0PC/pk+TZfU4ghbJrBByER+J qur0Q1eQxQgkatDUZ6hTaWt3b7YHa6RkwRhTFldyKHFh/zrSykWx+8wxnU6tq/9w+uqd qaoLlWIGhOnKUys8Stx7SbmKf2VJUMJq9wZl0iVQSudpo+voMCwddye6zj8Gb2Mn5SFq 5B4A== X-Gm-Message-State: AC+VfDz8nQzBtwHTGtdxFM9olTBGrfi80ijbgvvdqLrJ5VhwIgg+gaC0 PFhZ3cuqE6iag1XWCdBPVeQIRwASTP8= X-Google-Smtp-Source: ACHHUZ5bDxiutF/XwJNTYr7AtzQNcZBBf6rXHuTdFqmM0J9JwUcgoldZmvwpSYFMEXZdPkEdLyRpiA== X-Received: by 2002:adf:efca:0:b0:2ef:eba4:e208 with SMTP id i10-20020adfefca000000b002efeba4e208mr520789wrp.45.1682580935635; Thu, 27 Apr 2023 00:35:35 -0700 (PDT) Received: from Zen2.lab.linutronix.de. (drugstore.linutronix.de. [80.153.143.164]) by smtp.gmail.com with ESMTPSA id r4-20020adfdc84000000b002f598008d50sm17678411wrj.34.2023.04.27.00.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 00:35:35 -0700 (PDT) From: Alexander Kanavin X-Google-Original-From: Alexander Kanavin To: openembedded-core@lists.openembedded.org Cc: Alexander Kanavin Subject: [PATCH 3/5] insane.bbclass: add a RECIPE_MAINTAINER check (oe-core recipes only) Date: Thu, 27 Apr 2023 09:35:26 +0200 Message-Id: <20230427073528.3956414-3-alex@linutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230427073528.3956414-1-alex@linutronix.de> References: <20230427073528.3956414-1-alex@linutronix.de> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 27 Apr 2023 07:35:41 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/180477 Absent maintainer entries are as well a frequent source of friction, as they are checked only in selftest, and so aren't revealed until autobuilder runs. The selftest is retained as it also checks for obsolete entries in maintainers.inc (not possible to do in insane class). Signed-off-by: Alexander Kanavin --- meta/classes-global/insane.bbclass | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 64ad76c48e9..0847fb0807a 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -1499,7 +1499,19 @@ python do_qa_fetch() { else: oe.qa.handle_error("missing-metadata", "Recipe {} in {} does not contain a HOMEPAGE. Please add an entry.".format(pn, fn), d) + def test_missing_maintainer(d): + fn = d.getVar("FILE") + if not '/meta/recipes-' in fn: + # We are only interested in OE-Core + return + pn = d.getVar("PN") + if pn.endswith("-native") or pn.startswith("nativesdk-"): + return + if not d.getVar('RECIPE_MAINTAINER'): + oe.qa.handle_error("missing-metadata", "Recipe {} in {} does not have an assigned maintainer. Please add an entry into meta/conf/distro/include/maintainers.inc.".format(pn, fn), d) + test_missing_metadata(d) + test_missing_maintainer(d) oe.qa.exit_if_errors(d) } From patchwork Thu Apr 27 07:35:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kanavin X-Patchwork-Id: 23066 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BAEC7EE22 for ; Thu, 27 Apr 2023 07:35:41 +0000 (UTC) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.groups.io with SMTP id smtpd.web11.14808.1682580937717752169 for ; Thu, 27 Apr 2023 00:35:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=Wat/VfpQ; spf=pass (domain: gmail.com, ip: 209.85.221.48, mailfrom: alex.kanavin@gmail.com) Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-304935cc79bso2586654f8f.2 for ; Thu, 27 Apr 2023 00:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682580936; x=1685172936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A6m+FhGGlEwpf0aqPOhZ4hnLtuTn7FKXifaglrOzU5M=; b=Wat/VfpQiwGfXEcORy/bbMtxD4Qh1LgmS3Dcbv6qu6p6FhuZg2gWROQrupCEVjODrE /vthp/NZ4FMn5/RYfrTQuOZ1MxLkXz9tvxmpJ1QYMLog5FDR5syoAG6K1/KSLGwsl/GR Dog1d6a50rMtoqZVHP0MAXiVgHe3w8fMfriU4FI4gLcrTY4k2a7JK1p9AdtC/IE3r7ws Y7qxVPWXCN6dJHItqTTr/hsxVGv5iD5fz0jjRHzjIp4bv9i9ohgO5Mnn6Zrvq9iZULIt 3YIaJ3O+aoptCXIcT7G6O7P7Q2Mk7vjxc2H4ALKTIzqHsSvxILlmyFCbyYn8vtakWKPn StPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682580936; x=1685172936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A6m+FhGGlEwpf0aqPOhZ4hnLtuTn7FKXifaglrOzU5M=; b=brri9vgMVWg0p80l6IMN+XCD/jFQNekoJfu8qeF8I8sUD/f1xKpI1xsKdJ/UkV/hiy hbC0ZDugiYdvGW9YtM694xEsihnw9Th5FX7QVtix3bHGlNajcjV8NNNFidhylaoPTcQY hLUDvUfGLLS6Ct4G6pcHkwNpYOWnwdeXhCEEWBgFO+Oh2T+eP9K5xOiW02DA/JPmIg/k UKA3tIkr07TTt760DjM5qyPim6kJG6/7wC/ZkUQZBMp040WU10vR4JiFsqOPT8a1ZDAl CaRP6EQqtNfKqsez5/wcXmtll8zSgJAUEVagVBSReMXRrcduRS7lHEu9M61HtFhLZsZi HGPw== X-Gm-Message-State: AC+VfDwn4RBq7lllzeTYNdwLVGfylZif9rE13Vgyi6SVq6URfnvy9TJj 4U7WvsLKnOodhVFyzDobNo4vT9hWeVw= X-Google-Smtp-Source: ACHHUZ4IDklXVKZ9QcRtmrvm6bXk1PjHpXuCbI0c0jh7K8f/YndEKk3Oo4xLttlxPnD9jLnwfKAv4g== X-Received: by 2002:a5d:5543:0:b0:301:5615:26e4 with SMTP id g3-20020a5d5543000000b00301561526e4mr609832wrw.32.1682580936150; Thu, 27 Apr 2023 00:35:36 -0700 (PDT) Received: from Zen2.lab.linutronix.de. (drugstore.linutronix.de. [80.153.143.164]) by smtp.gmail.com with ESMTPSA id r4-20020adfdc84000000b002f598008d50sm17678411wrj.34.2023.04.27.00.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 00:35:35 -0700 (PDT) From: Alexander Kanavin X-Google-Original-From: Alexander Kanavin To: openembedded-core@lists.openembedded.org Cc: Alexander Kanavin Subject: [PATCH 4/5] dhcpcd: use git instead of tarballs Date: Thu, 27 Apr 2023 09:35:27 +0200 Message-Id: <20230427073528.3956414-4-alex@linutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230427073528.3956414-1-alex@linutronix.de> References: <20230427073528.3956414-1-alex@linutronix.de> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 27 Apr 2023 07:35:41 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/180478 As announced here: https://roy.marples.name/downloads/dhcpcd/ Signed-off-by: Alexander Kanavin --- meta/recipes-connectivity/dhcpcd/dhcpcd_9.4.1.bb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/meta/recipes-connectivity/dhcpcd/dhcpcd_9.4.1.bb b/meta/recipes-connectivity/dhcpcd/dhcpcd_9.4.1.bb index 579fa95df70..21b2eebbd8a 100644 --- a/meta/recipes-connectivity/dhcpcd/dhcpcd_9.4.1.bb +++ b/meta/recipes-connectivity/dhcpcd/dhcpcd_9.4.1.bb @@ -9,9 +9,7 @@ HOMEPAGE = "http://roy.marples.name/projects/dhcpcd/" LICENSE = "BSD-2-Clause" LIC_FILES_CHKSUM = "file://LICENSE;md5=d148485768fe85b9f1072b186a7e9b4d" -UPSTREAM_CHECK_URI = "https://roy.marples.name/downloads/dhcpcd/" - -SRC_URI = "https://roy.marples.name/downloads/${BPN}/${BPN}-${PV}.tar.xz \ +SRC_URI = "git://github.com/NetworkConfiguration/dhcpcd;protocol=https;branch=dhcpcd-9 \ file://0001-remove-INCLUDEDIR-to-prevent-build-issues.patch \ file://0001-20-resolv.conf-improve-the-sitation-of-working-with-.patch \ file://0001-privsep-Allow-getrandom-sysctl-for-newer-glibc.patch \ @@ -22,7 +20,8 @@ SRC_URI = "https://roy.marples.name/downloads/${BPN}/${BPN}-${PV}.tar.xz \ file://0001-dhcpcd.8-Fix-conflict-error-when-enable-multilib.patch \ " -SRC_URI[sha256sum] = "819357634efed1ea5cf44ec01b24d3d3f8852fec8b4249925dcc5667c54e376c" +SRCREV = "3c458fc7fa4146029a1e4f9e98cd7e7adf03081a" +S = "${WORKDIR}/git" inherit pkgconfig autotools-brokensep systemd useradd From patchwork Thu Apr 27 07:35:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kanavin X-Patchwork-Id: 23064 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F39C77B73 for ; Thu, 27 Apr 2023 07:35:41 +0000 (UTC) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web10.14868.1682580938212200603 for ; Thu, 27 Apr 2023 00:35:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=mkmQjA1s; spf=pass (domain: gmail.com, ip: 209.85.221.49, mailfrom: alex.kanavin@gmail.com) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-2f625d52275so7801023f8f.3 for ; Thu, 27 Apr 2023 00:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682580936; x=1685172936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tejhb0MF7MxTxKccMJ7sbE6FNwLXCA+cX5fBTyBBP3A=; b=mkmQjA1seNel6NWZPe4bQUZlkWGrPeGYMbadkpnLOFeKR+c8p69Gq17BBPOqz9BeVb gShH4GAcVs9JnKh3qV/tH7voXkFMhF9iOrvm0Wkn9ySFXFTNkRPdEWSlt8DeLjz3C4kM BzcpnOmzzCXCTm0GarXPR9hEjVK1cWAAZ8fEjhBXCQ2JwaIfbPQpSnkKa0UoVLt9k8ya d+gAR5Kd0E/7ll+etEr+7M6jP66Z4tNHhJu6m2LAiffoWLyb8dB65hBdfDMhtS4gWx35 aSKGj1ZNnR3ZR3B5KA72QnvUenXUpHninTu64okFK7TqOv3gF8SXxborxj4hlIClhecS w55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682580936; x=1685172936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tejhb0MF7MxTxKccMJ7sbE6FNwLXCA+cX5fBTyBBP3A=; b=FHLKRQ+KLSMyRofInBmgA1QGMCMVQhTJx3SBDSGK9wxGGBkI7DCYDxxJ096UeNh15/ FW5aWRm9jYJPkIw3yg0fF8aLvaJfhwa7YMTn48jKyrECvhXlItxwCqUno/Xvr6KLikFN jD7/ibkb8EAEhIqpeAS6H15BNUyd1N8McroED1Ba8VATd1JeQX5ReXOee29u65YsoLDK XpQV4PO4UJRD3SC02/ALfkLygmj/1d0ytF+MoTV6vYCVljnqjs7+X0aKe4hOBodZyZs+ PDYLWL6K3ID3YAgh8YdwVmBRET+qdBIhcEB16dFEZ7VyhKHlgJuAMPX1VrxgODmlaFGL P2qQ== X-Gm-Message-State: AC+VfDxsPfXKPz4lGlusArokQ6AXUOgtSDtfVnKeWYMkSoImg93+FYj4 Ug4fOYJUVT4a310cz9oYNhrwKzDCn54= X-Google-Smtp-Source: ACHHUZ6PMFMw0CgvOUged69zrc379EzyfE1nA55bhmotVq7YQ8wdAxSxG6zoN8fwcNaQQwRxWwMjdw== X-Received: by 2002:adf:ef84:0:b0:2fb:5296:cd19 with SMTP id d4-20020adfef84000000b002fb5296cd19mr524676wro.53.1682580936684; Thu, 27 Apr 2023 00:35:36 -0700 (PDT) Received: from Zen2.lab.linutronix.de. (drugstore.linutronix.de. [80.153.143.164]) by smtp.gmail.com with ESMTPSA id r4-20020adfdc84000000b002f598008d50sm17678411wrj.34.2023.04.27.00.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 00:35:36 -0700 (PDT) From: Alexander Kanavin X-Google-Original-From: Alexander Kanavin To: openembedded-core@lists.openembedded.org Cc: Alexander Kanavin Subject: [PATCH 5/5] perl: patch out build paths from native binaries Date: Thu, 27 Apr 2023 09:35:28 +0200 Message-Id: <20230427073528.3956414-5-alex@linutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230427073528.3956414-1-alex@linutronix.de> References: <20230427073528.3956414-1-alex@linutronix.de> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 27 Apr 2023 07:35:41 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/180479 Signed-off-by: Alexander Kanavin --- meta/recipes-devtools/perl/perl_5.36.0.bb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meta/recipes-devtools/perl/perl_5.36.0.bb b/meta/recipes-devtools/perl/perl_5.36.0.bb index 4d8a919d1ee..b8dba00f188 100644 --- a/meta/recipes-devtools/perl/perl_5.36.0.bb +++ b/meta/recipes-devtools/perl/perl_5.36.0.bb @@ -109,6 +109,10 @@ do_configure:class-native() { -Ui_xlocale \ -Alddlflags=' ${LDFLAGS}' \ ${PACKAGECONFIG_CONFARGS} + + # This prevents leakage of build paths into perl-native binaries, which + # causes non-deterministic troubles when those paths no longer exist or aren't accessible. + sed -i -e "s,${STAGING_LIBDIR},/completelyboguspath,g" config.h } do_configure:append() {