| Message ID | 20230817155143.2578874-1-charlie.johnston@ni.com |
|---|---|
| Headers | show |
| Series | Add packagefeed class documentation. | expand |
Hi Charlie On 17.08.23 at 17:50, Charlie Johnston wrote: > Alongside adding the new packagefeed recipe class to oe-core, the documentation needs updated as well. > This patchset adds documentation for the new class, task, and variables and then updates existing > references to the package-index task and package feeds as applicable. > > Patch set was tested via a local build to confirm no warnings or errors and hand-tested in a browsers > to ensure proper formatting. > > As mentioned above, this patch set is dependent on the oe-core patchset being accepted. Many thanks for these great updates! There were just 3 trailing whitespaces in Patch 1, but everything looks good. Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com> No need to update. I fixed the whitespaces in my branch. Unless a new iteration is necessary. Don't hesitate to ping me when your changes make it to openembedded-core. Thanks again, Cheers Michael.
Hi Charlie On 18.08.23 at 11:43, Michael Opdenacker wrote: > Hi Charlie > > On 17.08.23 at 17:50, Charlie Johnston wrote: >> Alongside adding the new packagefeed recipe class to oe-core, the >> documentation needs updated as well. >> This patchset adds documentation for the new class, task, and >> variables and then updates existing >> references to the package-index task and package feeds as applicable. >> >> Patch set was tested via a local build to confirm no warnings or >> errors and hand-tested in a browsers >> to ensure proper formatting. >> >> As mentioned above, this patch set is dependent on the oe-core >> patchset being accepted. > > > Many thanks for these great updates! > There were just 3 trailing whitespaces in Patch 1, but everything > looks good. > Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com> > > No need to update. I fixed the whitespaces in my branch. Unless a new > iteration is necessary. > Don't hesitate to ping me when your changes make it to openembedded-core. I haven't seen your patches getting merged. Did they eventually get rejected, or did you just lack the time to submit them one more time as a reminder? Cheers Michael.