diff mbox series

[kirkstone,2.0,4/4] bitbake-diffsigs: break on first dependent task difference

Message ID 89f13cd4a927a73de98998c27082c63b07671525.1676388410.git.steve@sakoman.com
State Accepted, archived
Commit 89f13cd4a927a73de98998c27082c63b07671525
Headers show
Series [kirkstone,2.0,1/4] siggen: Fix inefficient string concatenation | expand

Commit Message

Steve Sakoman Feb. 14, 2023, 3:28 p.m. UTC 
From: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>

compare_sigfiles() recursively calculates differences on all dependent
tasks with changed hashes. This is done in arbitrary/alphabetical order, and
only the last of those results is returned, while everything else is discarded.

This changes the behavior to instead return the first difference and not calculate
any more, which significantly speeds up diffs of tasks with many dependencies.

Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit ea6a676c9aa2864c2eff40eea41ba09ce903a651)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 lib/bb/siggen.py | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index cea3a538..0a9ce0ed 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -1028,6 +1028,7 @@  def compare_sigfiles(a, b, recursecb=None, color=False, collapsed=False):
                             # If a dependent hash changed, might as well print the line above and then defer to the changes in
                             # that hash since in all likelyhood, they're the same changes this task also saw.
                             output = [output[-1]] + recout
+                            break
 
     a_taint = a_data.get('taint', None)
     b_taint = b_data.get('taint', None)