diff mbox series

[04/11] server/process: Improve exception and idle function logging

Message ID 20221231165849.964169-5-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 9cf3102dc36513124fe5ead2f1e448b51833b6ac
Headers show
Series Bitbake server thread enabling | expand

Commit Message

Richard Purdie Dec. 31, 2022, 4:58 p.m. UTC 
Currently if the idle functions loop suffers a traceback, it is
silently dropped and there is no log message to say what happened.
This change at least means the traceback is in the cooker log, making
some debugging possible.

Add some logging to show when handlers are added/removed to allow
a better idea of what the server code is doing from the server log
file.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 lib/bb/server/process.py | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 91eb6e0ad9..eba28ad983 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -106,6 +106,7 @@  class ProcessServer():
         """Register a function to be called while the server is idle"""
         assert hasattr(function, '__call__')
         self._idlefuns[function] = data
+        serverlog("Registering idle function %s" % str(function))
 
     def run(self):
 
@@ -361,6 +362,7 @@  class ProcessServer():
             try:
                 retval = function(self, data, False)
                 if retval is False:
+                    serverlog("Removing idle function %s" % str(function))
                     del self._idlefuns[function]
                     nextsleep = None
                 elif retval is True:
@@ -378,6 +380,7 @@  class ProcessServer():
                 if not isinstance(exc, bb.BBHandledException):
                     logger.exception('Running idle function')
                 del self._idlefuns[function]
+                serverlog("Exception %s broke the idle_thread, exiting" % traceback.format_exc())
                 self.quit = True
 
         # Create new heartbeat event?
@@ -395,6 +398,7 @@  class ProcessServer():
                 except Exception as exc:
                     if not isinstance(exc, bb.BBHandledException):
                         logger.exception('Running heartbeat function')
+                    serverlog("Exception %s broke in idle_commands, exiting" % traceback.format_exc())
                     self.quit = True
         if nextsleep and bb.event._heartbeat_enabled and now + nextsleep > self.next_heartbeat:
             # Shorten timeout so that we we wake up in time for