diff mbox series

[2/6] siggen: Minor code improvement

Message ID 20221220151604.415637-2-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 513e6c4e9233e0d0bc31e1169077fdbf9aaf4ec3
Headers show
Series [1/6] knotty: Ping the server/cooker periodically | expand

Commit Message

Richard Purdie Dec. 20, 2022, 3:16 p.m. UTC 
Tweak the code to remove duplication and only set if the attribute isn't
already there to avoid overwriting.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 lib/bb/siggen.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index f551c74890..0e79404f76 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -273,11 +273,11 @@  class SignatureGeneratorBasic(SignatureGenerator):
         super().setup_datacache_from_datastore(mcfn, d)
 
         mc = bb.runqueue.mc_from_tid(mcfn)
-        setattr(self.datacaches[mc], "siggen_varvals", {})
+        for attr in ["siggen_varvals", "siggen_taskdeps", "siggen_gendeps"]:
+            if not hasattr(self.datacaches[mc], attr):
+                setattr(self.datacaches[mc], attr, {})
         self.datacaches[mc].siggen_varvals[mcfn] = d.getVar("__siggen_varvals")
-        setattr(self.datacaches[mc], "siggen_taskdeps", {})
         self.datacaches[mc].siggen_taskdeps[mcfn] = d.getVar("__siggen_taskdeps")
-        setattr(self.datacaches[mc], "siggen_gendeps", {})
         self.datacaches[mc].siggen_gendeps[mcfn] = d.getVar("__siggen_gendeps")
 
     def rundep_check(self, fn, recipename, task, dep, depname, dataCaches):