mbox series

[1.46,0/6] Backport multiconfig deferred fixes

Message ID 20230215104321.1665505-1-fabio.berton@criticaltechworks.com
Headers show
Series Backport multiconfig deferred fixes | expand

Message

Fabio Berton Feb. 15, 2023, 10:43 a.m. UTC 
This series is a backport to improve multiconfig builds in 1.46 branch. Without
these patches, some tasks run more than once for the native recipe, for example,
the do_patch task tries to apply the same patch to each machine.  With these
patches I can't see any duplicate tasks, and it looks like the task was properly
deferred by bitbake.

Richard Purdie (6):
  runqueue: Fix multiconfig deferred task sstate validity caching issue
  runqueue: Handle deferred task rehashing in multiconfig builds
  runqueue: Improve multiconfig deferred task issues
  runqueue: Avoid deadlock avoidance task graph corruption
  runqueue: Fix issues with multiconfig deferred task deadlock messages
  runqueue: Ensure deferred tasks are sorted by multiconfig

 lib/bb/runqueue.py | 88 +++++++++++++++++++++++++++++-----------------
 1 file changed, 55 insertions(+), 33 deletions(-)

Comments

Richard Purdie Feb. 17, 2023, 3:08 p.m. UTC | #1 
On Wed, 2023-02-15 at 10:43 +0000, Fabio Berton via
lists.openembedded.org wrote:
> This series is a backport to improve multiconfig builds in 1.46 branch. Without
> these patches, some tasks run more than once for the native recipe, for example,
> the do_patch task tries to apply the same patch to each machine.  With these
> patches I can't see any duplicate tasks, and it looks like the task was properly
> deferred by bitbake.
> 
> Richard Purdie (6):
>   runqueue: Fix multiconfig deferred task sstate validity caching issue
>   runqueue: Handle deferred task rehashing in multiconfig builds
>   runqueue: Improve multiconfig deferred task issues
>   runqueue: Avoid deadlock avoidance task graph corruption
>   runqueue: Fix issues with multiconfig deferred task deadlock messages
>   runqueue: Ensure deferred tasks are sorted by multiconfig
> 
>  lib/bb/runqueue.py | 88 +++++++++++++++++++++++++++++-----------------
>  1 file changed, 55 insertions(+), 33 deletions(-)
> 


For the record, I'm happier fixing this in 1.46 now that we tracked
down that last issue ("Ensure deferred tasks are sorted by
multiconfig") since that was the real bug that was causing a lot of the
problems.

Cheers,

Richard