| Message ID | 20220629113459.8666-1-ranjitsinh.rathod@kpit.com |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [master,kirkstone] ruby: Add ruby-native dependency for nativesdk class | expand |
Ping On Wed, 29 Jun, 2022, 5:08 pm Ranjitsinh Rathod, <ranjitsinh.rathod@kpit.com> wrote: > We need to add ruby-native dependency for nativesdk class too > to fix the compilation issue > Earlier this dependency is part of DEPENDS variable but the below > commit removes it from DEPENDS and add only for > DEPENDS_append_class-target which triggers the failure in > nativesdk-ruby:do_compile task > Link: > https://git.yoctoproject.org/poky/commit/?h=dunfell&id=6060b500b952754c595fdf5de5de35c886e0e1d5 > > Signed-off-by: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com> > Signed-off-by: Ranjitsinh Rathod <ranjitsinhrathod1991@gmail.com> > --- > meta/recipes-devtools/ruby/ruby.inc | 1 + > meta/recipes-devtools/ruby/ruby_3.1.2.bb | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/ruby/ruby.inc > b/meta/recipes-devtools/ruby/ruby.inc > index ebff5efd1f..efa40331e0 100644 > --- a/meta/recipes-devtools/ruby/ruby.inc > +++ b/meta/recipes-devtools/ruby/ruby.inc > @@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = > "file://COPYING;md5=5b8c87559868796979806100db3f3805 \ > > DEPENDS = "zlib openssl libyaml gdbm readline libffi" > DEPENDS:append:class-target = " ruby-native" > +DEPENDS:append:class-nativesdk = " ruby-native" > > SHRT_VER = "${@oe.utils.trim_version("${PV}", 2)}" > SRC_URI = " > http://cache.ruby-lang.org/pub/ruby/${SHRT_VER}/ruby-${PV}.tar.gz \ > diff --git a/meta/recipes-devtools/ruby/ruby_3.1.2.bb > b/meta/recipes-devtools/ruby/ruby_3.1.2.bb > index 38ba46731b..a9e6765939 100644 > --- a/meta/recipes-devtools/ruby/ruby_3.1.2.bb > +++ b/meta/recipes-devtools/ruby/ruby_3.1.2.bb > @@ -104,4 +104,4 @@ FILES:${PN}-ptest:append:class-target = "\ > ${libdir}/ruby/${SHRT_VER}.0/*/-test- \ > " > > -BBCLASSEXTEND = "native" > +BBCLASSEXTEND = "native nativesdk" > -- > 2.17.1 > > This message contains information that may be privileged or confidential > and is the property of the KPIT Technologies Ltd. It is intended only for > the person to whom it is addressed. If you are not the intended recipient, > you are not authorized to read, print, retain copy, disseminate, > distribute, or use this message or any part thereof. If you receive this > message in error, please notify the sender immediately and delete all > copies of this message. KPIT Technologies Ltd. does not accept any > liability for virus infected mails. >
On Wed, 2022-06-29 at 17:04 +0530, Ranjitsinh Rathod via lists.openembedded.org wrote: > We need to add ruby-native dependency for nativesdk class too > to fix the compilation issue This commit message is backwards. There is no nativesdk BBCLASSEXTEND for ruby so you can't need the ruby-native dependency for it. > Earlier this dependency is part of DEPENDS variable but the below > commit removes it from DEPENDS and add only for > DEPENDS_append_class-target which triggers the failure in > nativesdk-ruby:do_compile task > Link: https://git.yoctoproject.org/poky/commit/?h=dunfell&id=6060b500b952754c595fdf5de5de35c886e0e1d5 No, that commit didn't break anything since there isn't a BBCLASSEXTEND here. There is also no mention in your patch that you're adding it? You need to say why we need a BBCLASSEXTEND here. The DEPENDS change would logically follow from that. Cheers, Richard > > Signed-off-by: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com> > Signed-off-by: Ranjitsinh Rathod <ranjitsinhrathod1991@gmail.com> > --- > meta/recipes-devtools/ruby/ruby.inc | 1 + > meta/recipes-devtools/ruby/ruby_3.1.2.bb | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/ruby/ruby.inc b/meta/recipes-devtools/ruby/ruby.inc > index ebff5efd1f..efa40331e0 100644 > --- a/meta/recipes-devtools/ruby/ruby.inc > +++ b/meta/recipes-devtools/ruby/ruby.inc > @@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=5b8c87559868796979806100db3f3805 \ > > DEPENDS = "zlib openssl libyaml gdbm readline libffi" > DEPENDS:append:class-target = " ruby-native" > +DEPENDS:append:class-nativesdk = " ruby-native" > > SHRT_VER = "${@oe.utils.trim_version("${PV}", 2)}" > SRC_URI = "http://cache.ruby-lang.org/pub/ruby/${SHRT_VER}/ruby-${PV}.tar.gz \ > diff --git a/meta/recipes-devtools/ruby/ruby_3.1.2.bb b/meta/recipes-devtools/ruby/ruby_3.1.2.bb > index 38ba46731b..a9e6765939 100644 > --- a/meta/recipes-devtools/ruby/ruby_3.1.2.bb > +++ b/meta/recipes-devtools/ruby/ruby_3.1.2.bb > @@ -104,4 +104,4 @@ FILES:${PN}-ptest:append:class-target = "\ > ${libdir}/ruby/${SHRT_VER}.0/*/-test- \ > " > > -BBCLASSEXTEND = "native" > +BBCLASSEXTEND = "native nativesdk" > -- > 2.17.1 > > This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails. > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#167373): https://lists.openembedded.org/g/openembedded-core/message/167373 > Mute This Topic: https://lists.openembedded.org/mt/92062913/1686473 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [richard.purdie@linuxfoundation.org] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/recipes-devtools/ruby/ruby.inc b/meta/recipes-devtools/ruby/ruby.inc index ebff5efd1f..efa40331e0 100644 --- a/meta/recipes-devtools/ruby/ruby.inc +++ b/meta/recipes-devtools/ruby/ruby.inc @@ -15,6 +15,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=5b8c87559868796979806100db3f3805 \ DEPENDS = "zlib openssl libyaml gdbm readline libffi" DEPENDS:append:class-target = " ruby-native" +DEPENDS:append:class-nativesdk = " ruby-native" SHRT_VER = "${@oe.utils.trim_version("${PV}", 2)}" SRC_URI = "http://cache.ruby-lang.org/pub/ruby/${SHRT_VER}/ruby-${PV}.tar.gz \ diff --git a/meta/recipes-devtools/ruby/ruby_3.1.2.bb b/meta/recipes-devtools/ruby/ruby_3.1.2.bb index 38ba46731b..a9e6765939 100644 --- a/meta/recipes-devtools/ruby/ruby_3.1.2.bb +++ b/meta/recipes-devtools/ruby/ruby_3.1.2.bb @@ -104,4 +104,4 @@ FILES:${PN}-ptest:append:class-target = "\ ${libdir}/ruby/${SHRT_VER}.0/*/-test- \ " -BBCLASSEXTEND = "native" +BBCLASSEXTEND = "native nativesdk"