lib/oe/utils: 'Fix' oe.utils.contains() behaviour

Submitted by Richard Purdie on July 25, 2011, 6:19 p.m. | Patch ID: 8461


Message ID 1311617951.2344.193.camel@rex
State New, archived
Headers show

Commit Message

Richard Purdie July 25, 2011, 6:19 p.m.
Currently oe.utils.contains(X, "A", true, false) will return true for substring matches,
e.g. if X = "ABC". This is not what most users expect from the function.

In the common OE use of this function there is the case of "touchscreen" and "screen" being
used as independent variables. Whilst it could be argued there isn't a problem in that
specific case (touchscreens are usually on screens), there is no substring usage of this
function is OE-Core so this patch changes the behaviour to match only full strings.

It also fixes a bug where duplicate entries would confuse multiple matches, e.g.
contains(X, ["A", "B"], ...) would match X = "A A" which is clearly wrong.

Signed-off-by: Richard Purdie <>

Patch hide | download patch | download mbox

diff --git a/meta/lib/oe/ b/meta/lib/oe/
index 4287eee..b3473d3 100644
--- a/meta/lib/oe/
+++ b/meta/lib/oe/
@@ -35,16 +35,15 @@  def version_less_or_equal(variable, checkvalue, truevalue, falsevalue, d):
         return falsevalue
 def contains(variable, checkvalues, truevalue, falsevalue, d):
-    val =,d,1)
+    val = d.getVar(variable, True)
     if not val:
         return falsevalue
-    matches = 0
-    if type(checkvalues).__name__ == "str":
-        checkvalues = [checkvalues]
-    for value in checkvalues:
-        if val.find(value) != -1:
-            matches = matches + 1
-    if matches == len(checkvalues):
+    val = set(val.split())
+    if isinstance(checkvalues, basestring):
+        checkvalues = set(checkvalues.split())
+    else:
+        checkvalues = set(checkvalues)
+    if checkvalues.issubset(val):
         return truevalue
     return falsevalue