[kirkstone,3/3] devmem2: update SRC_URI according to redirect

Message ID 20220512234307.1189721-3-denis@denix.org
State Rejected, archived
Delegated to: Armin Kuster
Headers show
Series [kirkstone,1/3] devmem2: reinstate previous patches, removed by mistake | expand

Commit Message

Denys Dmytriyenko May 12, 2022, 11:43 p.m. UTC
From: Michael Opdenacker <michael.opdenacker@bootlin.com>

http://www.free-electrons.com now redirects to https://bootlin.com

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Denys Dmytriyenko <denis@denix.org>
---
 meta-oe/recipes-support/devmem2/devmem2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin Jansa May 25, 2022, 6:03 p.m. UTC | #1
Anyone willing to create a repo for this on github instead of patching this
in metadata?

This is another reproducer for do_patch issue described here
https://lists.yoctoproject.org/g/yocto/message/56602

On Fri, May 13, 2022 at 1:43 AM Denys Dmytriyenko <denis@denix.org> wrote:

> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
>
> http://www.free-electrons.com now redirects to https://bootlin.com
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Signed-off-by: Denys Dmytriyenko <denis@denix.org>
> ---
>  meta-oe/recipes-support/devmem2/devmem2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/devmem2/devmem2.bb
> b/meta-oe/recipes-support/devmem2/devmem2.bb
> index ba7aad8ab..70d413521 100644
> --- a/meta-oe/recipes-support/devmem2/devmem2.bb
> +++ b/meta-oe/recipes-support/devmem2/devmem2.bb
> @@ -3,7 +3,7 @@ LICENSE = "GPL-2.0-or-later"
>  LIC_FILES_CHKSUM =
> "file://devmem2.c;endline=38;md5=a9eb9f3890384519f435aedf986297cf"
>  PR = "r7"
>
> -SRC_URI = "
> http://www.free-electrons.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c
> \
> +SRC_URI = "
> https://bootlin.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c \
>             file://devmem2-fixups-2.patch;apply=yes;striplevel=0 \
>
> file://0001-devmem.c-ensure-word-is-32-bit-and-add-support-for-6.patch \
>
> file://0001-devmem2-support-different-page-sizes-at-run-time.patch \
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#97085):
> https://lists.openembedded.org/g/openembedded-devel/message/97085
> Mute This Topic: https://lists.openembedded.org/mt/91070560/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Denys Dmytriyenko May 25, 2022, 6:08 p.m. UTC | #2
Sure, I can do that and put it in the repo, since I've made few patches on top 
of it... Before I do that, are there any objections? Bootlin?


On Wed, May 25, 2022 at 08:03:58PM +0200, Martin Jansa wrote:
> Anyone willing to create a repo for this on github instead of patching this
> in metadata?
> 
> This is another reproducer for do_patch issue described here
> https://lists.yoctoproject.org/g/yocto/message/56602
> 
> On Fri, May 13, 2022 at 1:43 AM Denys Dmytriyenko <denis@denix.org> wrote:
> 
> > From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> >
> > http://www.free-electrons.com now redirects to https://bootlin.com
> >
> > Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > Signed-off-by: Denys Dmytriyenko <denis@denix.org>
> > ---
> >  meta-oe/recipes-support/devmem2/devmem2.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-support/devmem2/devmem2.bb
> > b/meta-oe/recipes-support/devmem2/devmem2.bb
> > index ba7aad8ab..70d413521 100644
> > --- a/meta-oe/recipes-support/devmem2/devmem2.bb
> > +++ b/meta-oe/recipes-support/devmem2/devmem2.bb
> > @@ -3,7 +3,7 @@ LICENSE = "GPL-2.0-or-later"
> >  LIC_FILES_CHKSUM =
> > "file://devmem2.c;endline=38;md5=a9eb9f3890384519f435aedf986297cf"
> >  PR = "r7"
> >
> > -SRC_URI = "
> > http://www.free-electrons.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c
> > \
> > +SRC_URI = "
> > https://bootlin.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c \
> >             file://devmem2-fixups-2.patch;apply=yes;striplevel=0 \
> >
> > file://0001-devmem.c-ensure-word-is-32-bit-and-add-support-for-6.patch \
> >
> > file://0001-devmem2-support-different-page-sizes-at-run-time.patch \
> > --
> > 2.25.1
Martin Jansa May 25, 2022, 6:09 p.m. UTC | #3
The history of this is deep :)

https://git.openembedded.org/openembedded/log/packages/devmem2?h=master
https://git.openembedded.org/openembedded/log/recipes/devmem2?h=master
https://git.openembedded.org/meta-openembedded/log/meta-oe/recipes-support/devmem2

On Wed, May 25, 2022 at 8:04 PM Martin Jansa via lists.openembedded.org
<Martin.Jansa=gmail.com@lists.openembedded.org> wrote:

> Anyone willing to create a repo for this on github instead of patching
> this in metadata?
>
> This is another reproducer for do_patch issue described here
> https://lists.yoctoproject.org/g/yocto/message/56602
>
> On Fri, May 13, 2022 at 1:43 AM Denys Dmytriyenko <denis@denix.org> wrote:
>
>> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
>>
>> http://www.free-electrons.com now redirects to https://bootlin.com
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> Signed-off-by: Denys Dmytriyenko <denis@denix.org>
>> ---
>>  meta-oe/recipes-support/devmem2/devmem2.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-support/devmem2/devmem2.bb
>> b/meta-oe/recipes-support/devmem2/devmem2.bb
>> index ba7aad8ab..70d413521 100644
>> --- a/meta-oe/recipes-support/devmem2/devmem2.bb
>> +++ b/meta-oe/recipes-support/devmem2/devmem2.bb
>> @@ -3,7 +3,7 @@ LICENSE = "GPL-2.0-or-later"
>>  LIC_FILES_CHKSUM =
>> "file://devmem2.c;endline=38;md5=a9eb9f3890384519f435aedf986297cf"
>>  PR = "r7"
>>
>> -SRC_URI = "
>> http://www.free-electrons.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c
>> \
>> +SRC_URI = "
>> https://bootlin.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c \
>>             file://devmem2-fixups-2.patch;apply=yes;striplevel=0 \
>>
>> file://0001-devmem.c-ensure-word-is-32-bit-and-add-support-for-6.patch \
>>
>> file://0001-devmem2-support-different-page-sizes-at-run-time.patch \
>> --
>> 2.25.1
>>
>>
>>
>>
>>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#97270):
> https://lists.openembedded.org/g/openembedded-devel/message/97270
> Mute This Topic: https://lists.openembedded.org/mt/91070560/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Khem Raj May 25, 2022, 6:32 p.m. UTC | #4
On Wed, May 25, 2022 at 11:08 AM Denys Dmytriyenko <denis@denix.org> wrote:
>
> Sure, I can do that and put it in the repo, since I've made few patches on top
> of it... Before I do that, are there any objections? Bootlin?

I would suggest to cross post with buildroot and see if there is
interest in using it from
a separate repository.

>
>
> On Wed, May 25, 2022 at 08:03:58PM +0200, Martin Jansa wrote:
> > Anyone willing to create a repo for this on github instead of patching this
> > in metadata?
> >
> > This is another reproducer for do_patch issue described here
> > https://lists.yoctoproject.org/g/yocto/message/56602
> >
> > On Fri, May 13, 2022 at 1:43 AM Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > > From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > >
> > > http://www.free-electrons.com now redirects to https://bootlin.com
> > >
> > > Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > Signed-off-by: Denys Dmytriyenko <denis@denix.org>
> > > ---
> > >  meta-oe/recipes-support/devmem2/devmem2.bb | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta-oe/recipes-support/devmem2/devmem2.bb
> > > b/meta-oe/recipes-support/devmem2/devmem2.bb
> > > index ba7aad8ab..70d413521 100644
> > > --- a/meta-oe/recipes-support/devmem2/devmem2.bb
> > > +++ b/meta-oe/recipes-support/devmem2/devmem2.bb
> > > @@ -3,7 +3,7 @@ LICENSE = "GPL-2.0-or-later"
> > >  LIC_FILES_CHKSUM =
> > > "file://devmem2.c;endline=38;md5=a9eb9f3890384519f435aedf986297cf"
> > >  PR = "r7"
> > >
> > > -SRC_URI = "
> > > http://www.free-electrons.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c
> > > \
> > > +SRC_URI = "
> > > https://bootlin.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c \
> > >             file://devmem2-fixups-2.patch;apply=yes;striplevel=0 \
> > >
> > > file://0001-devmem.c-ensure-word-is-32-bit-and-add-support-for-6.patch \
> > >
> > > file://0001-devmem2-support-different-page-sizes-at-run-time.patch \
> > > --
> > > 2.25.1
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#97271): https://lists.openembedded.org/g/openembedded-devel/message/97271
> Mute This Topic: https://lists.openembedded.org/mt/91070560/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Martin Jansa May 25, 2022, 6:41 p.m. UTC | #5
buildroot removed it in 2019 and recommends to use busybox version instead:
https://github.com/buildroot/buildroot/commit/2b2579afebfc7a9b8a458af1f2d206101fbfa19c

"Use the the Busybox devmem utility, instead, which provides the same
functionality."

On Wed, May 25, 2022 at 8:32 PM Khem Raj <raj.khem@gmail.com> wrote:

> On Wed, May 25, 2022 at 11:08 AM Denys Dmytriyenko <denis@denix.org>
> wrote:
> >
> > Sure, I can do that and put it in the repo, since I've made few patches
> on top
> > of it... Before I do that, are there any objections? Bootlin?
>
> I would suggest to cross post with buildroot and see if there is
> interest in using it from
> a separate repository.
>
> >
> >
> > On Wed, May 25, 2022 at 08:03:58PM +0200, Martin Jansa wrote:
> > > Anyone willing to create a repo for this on github instead of patching
> this
> > > in metadata?
> > >
> > > This is another reproducer for do_patch issue described here
> > > https://lists.yoctoproject.org/g/yocto/message/56602
> > >
> > > On Fri, May 13, 2022 at 1:43 AM Denys Dmytriyenko <denis@denix.org>
> wrote:
> > >
> > > > From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > > >
> > > > http://www.free-electrons.com now redirects to https://bootlin.com
> > > >
> > > > Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > Signed-off-by: Denys Dmytriyenko <denis@denix.org>
> > > > ---
> > > >  meta-oe/recipes-support/devmem2/devmem2.bb | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta-oe/recipes-support/devmem2/devmem2.bb
> > > > b/meta-oe/recipes-support/devmem2/devmem2.bb
> > > > index ba7aad8ab..70d413521 100644
> > > > --- a/meta-oe/recipes-support/devmem2/devmem2.bb
> > > > +++ b/meta-oe/recipes-support/devmem2/devmem2.bb
> > > > @@ -3,7 +3,7 @@ LICENSE = "GPL-2.0-or-later"
> > > >  LIC_FILES_CHKSUM =
> > > > "file://devmem2.c;endline=38;md5=a9eb9f3890384519f435aedf986297cf"
> > > >  PR = "r7"
> > > >
> > > > -SRC_URI = "
> > > >
> http://www.free-electrons.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c
> > > > \
> > > > +SRC_URI = "
> > > >
> https://bootlin.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c \
> > > >             file://devmem2-fixups-2.patch;apply=yes;striplevel=0 \
> > > >
> > > >
> file://0001-devmem.c-ensure-word-is-32-bit-and-add-support-for-6.patch \
> > > >
> > > > file://0001-devmem2-support-different-page-sizes-at-run-time.patch \
> > > > --
> > > > 2.25.1
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#97271):
> https://lists.openembedded.org/g/openembedded-devel/message/97271
> > Mute This Topic: https://lists.openembedded.org/mt/91070560/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
Denys Dmytriyenko May 30, 2022, 4:31 p.m. UTC | #6
https://lists.openembedded.org/g/openembedded-devel/message/97339


On Mon, May 30, 2022 at 10:07:07AM -0400, Philip Balister wrote:
> On 5/25/22 14:41, Martin Jansa wrote:
> >buildroot removed it in 2019 and recommends to use busybox version instead:
> >https://github.com/buildroot/buildroot/commit/2b2579afebfc7a9b8a458af1f2d206101fbfa19c
> >
> >"Use the the Busybox devmem utility, instead, which provides the
> >same functionality."
> 
> I want to say there is an issue with the busybox devmem. As I recall
> (and this is an ancient memory), if you use busybox devmem to write,
> it does a readback. This is a bad thing if the address you write to
> is a hardware device that uses the read to reset state.
> 
> Philip
> 
> >
> >On Wed, May 25, 2022 at 8:32 PM Khem Raj <raj.khem@gmail.com
> ><mailto:raj.khem@gmail.com>> wrote:
> >
> >    On Wed, May 25, 2022 at 11:08 AM Denys Dmytriyenko <denis@denix.org
> >    <mailto:denis@denix.org>> wrote:
> >     >
> >     > Sure, I can do that and put it in the repo, since I've made few
> >    patches on top
> >     > of it... Before I do that, are there any objections? Bootlin?
> >
> >    I would suggest to cross post with buildroot and see if there is
> >    interest in using it from
> >    a separate repository.
> >
> >     >
> >     >
> >     > On Wed, May 25, 2022 at 08:03:58PM +0200, Martin Jansa wrote:
> >     > > Anyone willing to create a repo for this on github instead of
> >    patching this
> >     > > in metadata?
> >     > >
> >     > > This is another reproducer for do_patch issue described here
> >     > > https://lists.yoctoproject.org/g/yocto/message/56602

Patch

diff --git a/meta-oe/recipes-support/devmem2/devmem2.bb b/meta-oe/recipes-support/devmem2/devmem2.bb
index ba7aad8ab..70d413521 100644
--- a/meta-oe/recipes-support/devmem2/devmem2.bb
+++ b/meta-oe/recipes-support/devmem2/devmem2.bb
@@ -3,7 +3,7 @@  LICENSE = "GPL-2.0-or-later"
 LIC_FILES_CHKSUM = "file://devmem2.c;endline=38;md5=a9eb9f3890384519f435aedf986297cf"
 PR = "r7"
 
-SRC_URI = "http://www.free-electrons.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c \
+SRC_URI = "https://bootlin.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c \
            file://devmem2-fixups-2.patch;apply=yes;striplevel=0 \
            file://0001-devmem.c-ensure-word-is-32-bit-and-add-support-for-6.patch \
            file://0001-devmem2-support-different-page-sizes-at-run-time.patch \