[master,kirkstone,v2] create-spdx: delete virtual/kernel dependency to fix FreeRTOS build

Message ID 20220426134908.520502-1-davide.gardenal@huawei.com
State Accepted, archived
Commit 1c02b768a71ec88bfe1cc0c4443683de8b66056e
Headers show
Series [master,kirkstone,v2] create-spdx: delete virtual/kernel dependency to fix FreeRTOS build | expand

Commit Message

Davide Gardenal April 26, 2022, 1:49 p.m. UTC
When building FreeRTOS this dependency generates an error because
bitbake cannot find any provider for "virtual/kernel".
From a dependency analysis the task is executed indipendently from
this so it can be safely removed.

This patch has been discussed in this ML thread:
https://lists.openembedded.org/g/openembedded-core/topic/90602531

Signed-off-by: Davide Gardenal <davide.gardenal@huawei.com>
---
Updates:
 - v2: Reword of the commit message
---
 meta/classes/create-spdx.bbclass | 2 --
 1 file changed, 2 deletions(-)

Comments

Davide Gardenal April 29, 2022, 12:18 p.m. UTC | #1
I saw that this patch was not included in the kirkstone backport list. Could you consider to add it please?

Thanks!

Davide

CC: Steve Sakoman

> Il giorno 26 apr 2022, alle ore 15:49, Davide Gardenal <davidegarde2000@gmail.com> ha scritto:
> 
> When building FreeRTOS this dependency generates an error because
> bitbake cannot find any provider for "virtual/kernel".
> From a dependency analysis the task is executed indipendently from
> this so it can be safely removed.
> 
> This patch has been discussed in this ML thread:
> https://lists.openembedded.org/g/openembedded-core/topic/90602531
> 
> Signed-off-by: Davide Gardenal <davide.gardenal@huawei.com>
> ---
> Updates:
> - v2: Reword of the commit message
> ---
> meta/classes/create-spdx.bbclass | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/meta/classes/create-spdx.bbclass b/meta/classes/create-spdx.bbclass
> index 28fc449636..9979c1d70e 100644
> --- a/meta/classes/create-spdx.bbclass
> +++ b/meta/classes/create-spdx.bbclass
> @@ -35,8 +35,6 @@ SPDX_SUPPLIER[doc] = "The SPDX PackageSupplier field for SPDX packages created f
>     is the contact information for the person or organization who is doing the \
>     build."
> 
> -do_image_complete[depends] = "virtual/kernel:do_create_spdx"
> -
> def extract_licenses(filename):
>     import re
> 
> -- 
> 2.32.0
>
Steve Sakoman April 29, 2022, 2:14 p.m. UTC | #2
On Fri, Apr 29, 2022 at 2:18 AM Davide Gardenal
<davidegarde2000@gmail.com> wrote:
>
> I saw that this patch was not included in the kirkstone backport list. Could you consider to add it please?

It is in the set of patches currently under test.

Just as with dunfell, you can view the patches under test in the
<release>-nut branch on poky-contrib.

So for dunfell:

https://git.yoctoproject.org/poky-contrib/log/?h=stable/dunfell-nut

and kirkstone:

https://git.yoctoproject.org/poky-contrib/log/?h=stable/kirkstone-nut

Thanks for checking though, I don't want to miss anything!

Steve

> > Il giorno 26 apr 2022, alle ore 15:49, Davide Gardenal <davidegarde2000@gmail.com> ha scritto:
> >
> > When building FreeRTOS this dependency generates an error because
> > bitbake cannot find any provider for "virtual/kernel".
> > From a dependency analysis the task is executed indipendently from
> > this so it can be safely removed.
> >
> > This patch has been discussed in this ML thread:
> > https://lists.openembedded.org/g/openembedded-core/topic/90602531
> >
> > Signed-off-by: Davide Gardenal <davide.gardenal@huawei.com>
> > ---
> > Updates:
> > - v2: Reword of the commit message
> > ---
> > meta/classes/create-spdx.bbclass | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/meta/classes/create-spdx.bbclass b/meta/classes/create-spdx.bbclass
> > index 28fc449636..9979c1d70e 100644
> > --- a/meta/classes/create-spdx.bbclass
> > +++ b/meta/classes/create-spdx.bbclass
> > @@ -35,8 +35,6 @@ SPDX_SUPPLIER[doc] = "The SPDX PackageSupplier field for SPDX packages created f
> >     is the contact information for the person or organization who is doing the \
> >     build."
> >
> > -do_image_complete[depends] = "virtual/kernel:do_create_spdx"
> > -
> > def extract_licenses(filename):
> >     import re
> >
> > --
> > 2.32.0
> >
>

Patch

diff --git a/meta/classes/create-spdx.bbclass b/meta/classes/create-spdx.bbclass
index 28fc449636..9979c1d70e 100644
--- a/meta/classes/create-spdx.bbclass
+++ b/meta/classes/create-spdx.bbclass
@@ -35,8 +35,6 @@  SPDX_SUPPLIER[doc] = "The SPDX PackageSupplier field for SPDX packages created f
     is the contact information for the person or organization who is doing the \
     build."
 
-do_image_complete[depends] = "virtual/kernel:do_create_spdx"
-
 def extract_licenses(filename):
     import re