[0/5] Allow arm tunes which support only thumb

Submitted by Martin Jansa on April 25, 2014, 4:40 p.m.

Details

Message ID cover.1398443925.git.Martin.Jansa@gmail.com
State New
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib jansa/tune

Commit Message

Martin Jansa April 25, 2014, 4:40 p.m.
Now with 1.7 open for new changes can we please apply first 4 patches?

The following changes since commit 866d2854139e0b00063dde06bc3a34d635ae2fc8:

  build-appliance-image: Update to  head revision (2014-04-24 17:54:58 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib jansa/tune
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/tune

Andrei Gherzan (1):
  tune-cortexm3.inc: Cortex-M3 doesn't support ARM instructions

Martin Jansa (4):
  feature-arm-thumb.inc: Replace inner quotes with apostrophes
  feature-arm-thumb.inc, arch-armv4.inc: Add "arm" to TUNE_FEATURES
  tune-cortexr4.inc: Add thumb and arm to TUNE_FEATURES
  WIP: feature-arm-thumb.inc: respect ARM_INSTRUCTION_SET when adding
    thumb suffix

 meta/conf/machine/include/arm/arch-armv4.inc       |  3 +-
 meta/conf/machine/include/arm/arch-armv5.inc       |  2 +-
 meta/conf/machine/include/arm/arch-armv6.inc       |  2 +-
 meta/conf/machine/include/arm/arch-armv7a.inc      |  2 +-
 .../conf/machine/include/arm/feature-arm-thumb.inc | 36 ++++++++++++++++------
 meta/conf/machine/include/tune-cortexm3.inc        |  2 +-
 meta/conf/machine/include/tune-cortexr4.inc        |  2 +-
 7 files changed, 34 insertions(+), 15 deletions(-)

Comments

Mark Hatle April 25, 2014, 4:51 p.m.
On 4/25/14, 11:40 AM, Martin Jansa wrote:
> Now with 1.7 open for new changes can we please apply first 4 patches?
>
> The following changes since commit 866d2854139e0b00063dde06bc3a34d635ae2fc8:
>
>    build-appliance-image: Update to  head revision (2014-04-24 17:54:58 +0100)
>
> are available in the git repository at:
>
>    git://git.openembedded.org/openembedded-core-contrib jansa/tune
>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/tune
>
> Andrei Gherzan (1):
>    tune-cortexm3.inc: Cortex-M3 doesn't support ARM instructions
>
> Martin Jansa (4):
>    feature-arm-thumb.inc: Replace inner quotes with apostrophes
>    feature-arm-thumb.inc, arch-armv4.inc: Add "arm" to TUNE_FEATURES
>    tune-cortexr4.inc: Add thumb and arm to TUNE_FEATURES
>    WIP: feature-arm-thumb.inc: respect ARM_INSTRUCTION_SET when adding
>      thumb suffix

I looked these over and I do like what I see.

The last WIP item is what I originally wanted to implement.. but at the time was 
told not to do it that way... so I'm more then happy to support the package arch 
clearly indicating if thumb was enabled for compilation or not.

--Mark

>   meta/conf/machine/include/arm/arch-armv4.inc       |  3 +-
>   meta/conf/machine/include/arm/arch-armv5.inc       |  2 +-
>   meta/conf/machine/include/arm/arch-armv6.inc       |  2 +-
>   meta/conf/machine/include/arm/arch-armv7a.inc      |  2 +-
>   .../conf/machine/include/arm/feature-arm-thumb.inc | 36 ++++++++++++++++------
>   meta/conf/machine/include/tune-cortexm3.inc        |  2 +-
>   meta/conf/machine/include/tune-cortexr4.inc        |  2 +-
>   7 files changed, 34 insertions(+), 15 deletions(-)
>