[0/4] uclibc and related fixes

Submitted by Khem Raj on June 22, 2011, 3:57 p.m.

Details

Message ID 4E0210DF.1000200@gmail.com
State New, archived
Headers show

Commit Message

Khem Raj June 22, 2011, 3:57 p.m.
On 06/22/2011 08:42 AM, Richard Purdie wrote:
> On Tue, 2011-06-21 at 18:44 -0700, Khem Raj wrote:
>> Fix uclibc build for x86_64
>> gettext compile failed on uclibc so fix it and additionally
>> remove unused patches
>> Add required support for systemd to function with uclibc
>> Quash a parse warning where uclibc-initial and uclibc
>> both provided libsegfault
>>
>> The following changes since commit 78de64f58b98101f5be5778e9ecbdaae5ba32997:
>>
>>    binutils_2.21.bb: Fix ld segfault exposed by eglibc 2.14 on x86_64 (2011-06-21 17:58:06 -0700)
>>
>> are available in the git repository at:
>>    git://git.openembedded.org/openembedded-core-contrib kraj/uclibc
>>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/uclibc
>>
>> Khem Raj (4):
>>    uclibc.inc: libsegfault is only RPROVIDED by uclibc
>>    gettext-0.18.1.1: Remove unused patches
>>    uclibc/x86_64/uClibc.machine: Enable ARCH_USE_MMU
>>    uclibc: Add support for $ORIGIN
>
> Merged to master, thanks.
>
> I had reservations about the first one as hardcoding PN can have issues
> with BBCLASSEXTEND but looking at the recipe, there are bigger issues if
> we were ever to do that :/
>

in attached patch I moved it to uclibc recipe is that better ?


> Cheers,
>
> Richard
>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch hide | download patch | download mbox

From 28232ad0c9bea3133493e056e7d828958e74da66 Mon Sep 17 00:00:00 2001
From: Khem Raj <raj.khem@gmail.com>
Date: Sat, 11 Jun 2011 01:47:33 -0700
Subject: [PATCH] uclibc.inc: libsegfault is only RPROVIDED by uclibc

Using ${PN} also means that uclibc-initial gets to provide it
which we do not want so move this to uclibc recipe

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-core/uclibc/uclibc.inc    |    1 -
 meta/recipes-core/uclibc/uclibc_git.bb |    5 +++++
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-core/uclibc/uclibc.inc b/meta/recipes-core/uclibc/uclibc.inc
index 00f5e8d..13a6164 100644
--- a/meta/recipes-core/uclibc/uclibc.inc
+++ b/meta/recipes-core/uclibc/uclibc.inc
@@ -89,7 +89,6 @@  RPROVIDES_uclibc-dev += "libc-dev virtual-libc-dev"
 # uclibc does not really have libsegfault but then using the one from glibc is also not
 # going to work. So we pretend that we have it to make bitbake not pull other recipes
 # to satisfy this dependency for the images/tasks
-RPROVIDES_${PN} += "libsegfault"
 
 SRC_URI = "\
         http://www.uclibc.org/downloads/uClibc-${PV}.tar.bz2;name=uClibc-${PV} \
diff --git a/meta/recipes-core/uclibc/uclibc_git.bb b/meta/recipes-core/uclibc/uclibc_git.bb
index 6445243..d5b9e40 100644
--- a/meta/recipes-core/uclibc/uclibc_git.bb
+++ b/meta/recipes-core/uclibc/uclibc_git.bb
@@ -5,6 +5,11 @@  PV = "0.9.31+0.9.32rc3"
 PR = "${INC_PR}.4"
 PROVIDES += "virtual/${TARGET_PREFIX}libc-for-gcc"
 
+# uclibc does not really have libsegfault but then using the one from glibc is also not
+# going to work. So we pretend that we have it to make bitbake not pull other recipes
+# to satisfy this dependency for the images/tasks
+
+RPROVIDES_${PN} += "libsegfault"
 FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/uclibc-git' ], d)}"
 
 SRC_URI = "git://uclibc.org/uClibc.git;branch=master;protocol=git \
-- 
1.7.4.1


Comments

Richard Purdie June 22, 2011, 4:10 p.m.
On Wed, 2011-06-22 at 08:57 -0700, Khem Raj wrote:
> On 06/22/2011 08:42 AM, Richard Purdie wrote:
> > On Tue, 2011-06-21 at 18:44 -0700, Khem Raj wrote:
> >> Fix uclibc build for x86_64
> >> gettext compile failed on uclibc so fix it and additionally
> >> remove unused patches
> >> Add required support for systemd to function with uclibc
> >> Quash a parse warning where uclibc-initial and uclibc
> >> both provided libsegfault
> >>
> >> The following changes since commit 78de64f58b98101f5be5778e9ecbdaae5ba32997:
> >>
> >>    binutils_2.21.bb: Fix ld segfault exposed by eglibc 2.14 on x86_64 (2011-06-21 17:58:06 -0700)
> >>
> >> are available in the git repository at:
> >>    git://git.openembedded.org/openembedded-core-contrib kraj/uclibc
> >>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/uclibc
> >>
> >> Khem Raj (4):
> >>    uclibc.inc: libsegfault is only RPROVIDED by uclibc
> >>    gettext-0.18.1.1: Remove unused patches
> >>    uclibc/x86_64/uClibc.machine: Enable ARCH_USE_MMU
> >>    uclibc: Add support for $ORIGIN
> >
> > Merged to master, thanks.
> >
> > I had reservations about the first one as hardcoding PN can have issues
> > with BBCLASSEXTEND but looking at the recipe, there are bigger issues if
> > we were ever to do that :/
> >
> 
> in attached patch I moved it to uclibc recipe is that better ?

Its better, yes and its what I was going to suggest until I realised
there were other issues that BBCLASSEXTEND would have with the recipe.
Its certainly something to keep in mind in the future...

Cheers,

Richard