Added command used to add the signed-off-by line.

Message ID 20220404125435.8545-1-abongwabonalais@gmail.com
State New
Headers show
Series Added command used to add the signed-off-by line. | expand

Commit Message

Abongwa Bonalais April 4, 2022, 12:54 p.m. UTC
Signed-off-by: Abongwa Bonalais Amahnui <abongwabonalais@gmail.com>
---
 documentation/dev-manual/common-tasks.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Michael Opdenacker April 5, 2022, 11:22 a.m. UTC | #1
Hi Abongwa,

On 4/4/22 14:54, Abongwa Amahnui Bonalais wrote:
> Signed-off-by: Abongwa Bonalais Amahnui <abongwabonalais@gmail.com>
> ---
>  documentation/dev-manual/common-tasks.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
> index 9d4aaa5a6..4e4311021 100644
> --- a/documentation/dev-manual/common-tasks.rst
> +++ b/documentation/dev-manual/common-tasks.rst
> @@ -10595,7 +10595,8 @@ Preparing Changes for Submission
>     following these accepted conventions:
>  
>     -  Be sure to include a "Signed-off-by:" line in the same style as
> -      required by the Linux kernel. Adding this line signifies that you,
> +      required by the Linux kernel.This can be done by using the ``git commit -s`` command.
> +      Adding this line signifies that you,
>        the submitter, have agreed to the Developer's Certificate of
>        Origin 1.1 as follows:

Thanks for the patch.
I added a missing space and improved alignment. I also fixed the title
string... that's useful to clarify that the commit is part of the
documentation, because the commit ultimately ends up in the Poky
repository. That's useful to recognize the documentation commits then.

I also did that for the previous patch.

Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
... and merged into master-next.
Thanks!

Michael.
Abongwa Bonalais April 5, 2022, 5:15 p.m. UTC | #2
Thanks I will try hard to improve on my titles subsequently

Patch

diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
index 9d4aaa5a6..4e4311021 100644
--- a/documentation/dev-manual/common-tasks.rst
+++ b/documentation/dev-manual/common-tasks.rst
@@ -10595,7 +10595,8 @@  Preparing Changes for Submission
    following these accepted conventions:
 
    -  Be sure to include a "Signed-off-by:" line in the same style as
-      required by the Linux kernel. Adding this line signifies that you,
+      required by the Linux kernel.This can be done by using the ``git commit -s`` command.
+      Adding this line signifies that you,
       the submitter, have agreed to the Developer's Certificate of
       Origin 1.1 as follows: