| Message ID | 1383737461-15449-3-git-send-email-alex.gonzalez@digi.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Otavio Salvador |
| Headers | show |
diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin/remove-GST_INFO-in-mfw_gst_utils.h.patch b/recipes-multimedia/gst-plugins/gst-fsl-plugin/remove-GST_INFO-in-mfw_gst_utils.h.patch deleted file mode 100644 index c4dac2b..0000000 --- a/recipes-multimedia/gst-plugins/gst-fsl-plugin/remove-GST_INFO-in-mfw_gst_utils.h.patch +++ /dev/null @@ -1,40 +0,0 @@ -From 28ad25933dc51d8af13927a9943a353677c31a3a Mon Sep 17 00:00:00 2001 -From: Lyon Wang <lyon.wang@freescale.com> -Date: Tue, 22 Oct 2013 16:15:43 +0800 -Subject: [PATCH] remove GST_INFO in mfw_gst_utils.h - -GST_INFO() should not be used in the global header -or it will cause some macro definiation error. - -so comment the GST_INFO() in the mfw_gst_utils.h - -Upstream-Status: Backport [GIT] ---- - fsl_mm_linux/Multimedia/inc/plugin/mfw_gst_utils.h | 4 ++-- - 1 file changed, 2 insertions(+), 2 deletions(-) - -diff --git a/fsl_mm_linux/Multimedia/inc/plugin/mfw_gst_utils.h b/fsl_mm_linux/Multimedia/inc/plugin/mfw_gst_utils.h -index 366d50e..c1b6f90 100755 ---- a/fsl_mm_linux/Multimedia/inc/plugin/mfw_gst_utils.h -+++ b/fsl_mm_linux/Multimedia/inc/plugin/mfw_gst_utils.h -@@ -876,7 +876,7 @@ getChipCodeFromSocid (void) - } - fclose(fp); - -- GST_INFO("SOC is %s\n", soc_name); -+ //GST_INFO("SOC is %s\n", soc_name); - - int num = sizeof(soc_info) / sizeof(SOC_INFO); - int i; -@@ -913,7 +913,7 @@ getChipCode (void) - } - - kv = ((kv_major << 16) + (kv_minor << 8) + kv_rel); -- GST_INFO("kernel:%s, %d.%d.%d\n", sys_name.release, kv_major, kv_minor, kv_rel); -+ //GST_INFO("kernel:%s, %d.%d.%d\n", sys_name.release, kv_major, kv_minor, kv_rel); - - if (kv < KERN_VER(3, 10, 0)) - return getChipCodeFromCpuinfo(); --- -1.7.9.5 - diff --git a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.9.bb b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.9.bb index 4e26719..b95f576 100644 --- a/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.9.bb +++ b/recipes-multimedia/gst-plugins/gst-fsl-plugin_3.0.9.bb @@ -5,8 +5,7 @@ require gst-fsl-plugin.inc SRC_URI[md5sum] = "a338a5c25225c765ae5f44af82fe7413" SRC_URI[sha256sum] = "e809daa0cd60381f05a79f34a53305a5ee53bfed22192a1cda6d998acc84a6fd" -SRC_URI = "${FSL_MIRROR}/gst-fsl-plugins-3.10.9-1.0.0.tar.gz \ - file://remove-GST_INFO-in-mfw_gst_utils.h.patch" +SRC_URI = "${FSL_MIRROR}/gst-fsl-plugins-3.10.9-1.0.0.tar.gz" S = "${WORKDIR}/gst-fsl-plugins-3.10.9-1.0.0"
On Wed, Nov 6, 2013 at 9:31 AM, <alex.gonzalez@digi.com> wrote: > From: Alex Gonzalez <alex.gonzalez@digi.com> > > This patch was carried forward from 3.0.8 and it fails to apply. The patch > was meant to fix some macro definition errors which do not happen now. > > Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com> This patch is need for mx28evk; I pushed the master-next with the fixed patch.
On 06-11-2013 09:45, Otavio Salvador wrote: > On Wed, Nov 6, 2013 at 9:31 AM, <alex.gonzalez@digi.com> wrote: >> From: Alex Gonzalez <alex.gonzalez@digi.com> >> >> This patch was carried forward from 3.0.8 and it fails to apply. The patch >> was meant to fix some macro definition errors which do not happen now. >> >> Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com> > > This patch is need for mx28evk; I pushed the master-next with the fixed patch. > Where? Please, share me the link to commit on gitweb
Thanks Otavio. Just curious, why does the mx28evk need gst-fsl-plugin at all? It has no video hardware acceleration that gstreamer uses, has it? Alex -----Original Message----- From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf Of Otavio Salvador Sent: miércoles, 06 de noviembre de 2013 12:45 To: Gonzalez, Alex Cc: meta-freescale@yoctoproject.org Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 2/2] gst-fsl-plugin: Remove GST_INFO patch. On Wed, Nov 6, 2013 at 9:31 AM, <alex.gonzalez@digi.com> wrote: > From: Alex Gonzalez <alex.gonzalez@digi.com> > > This patch was carried forward from 3.0.8 and it fails to apply. The patch > was meant to fix some macro definition errors which do not happen now. > > Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com> This patch is need for mx28evk; I pushed the master-next with the fixed patch.
On Wed, Nov 6, 2013 at 9:51 AM, Daiane Angolini <daiane.angolini@freescale.com> wrote: > On 06-11-2013 09:45, Otavio Salvador wrote: >> >> On Wed, Nov 6, 2013 at 9:31 AM, <alex.gonzalez@digi.com> wrote: >>> >>> From: Alex Gonzalez <alex.gonzalez@digi.com> >>> >>> This patch was carried forward from 3.0.8 and it fails to apply. The >>> patch >>> was meant to fix some macro definition errors which do not happen now. >>> >>> Signed-off-by: Alex Gonzalez <alex.gonzalez@digi.com> >> >> >> This patch is need for mx28evk; I pushed the master-next with the fixed >> patch. >> > > Where? > Please, share me the link to commit on gitweb http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/diff/recipes-multimedia/gst-plugins/gst-fsl-plugin/remove-GST_INFO-in-mfw_gst_utils.h.patch?h=master-next&id=9135a32b50800cac2c3feb0bac1f19c3d6743add
On Wed, Nov 6, 2013 at 9:57 AM, Gonzalez, Alex <Alex.Gonzalez@digi.com> wrote: > Thanks Otavio. > > Just curious, why does the mx28evk need gst-fsl-plugin at all? It has no video hardware acceleration that gstreamer uses, has it? To use the FSL's software optimized codecs; in fact I am not sure it is a real gain but some customers want it and FSL's BSP has it so we support it.
On Wed, Nov 6, 2013 at 10:35 AM, Otavio Salvador <otavio@ossystems.com.br> wrote: > On Wed, Nov 6, 2013 at 9:57 AM, Gonzalez, Alex <Alex.Gonzalez@digi.com> wrote: >> Thanks Otavio. >> >> Just curious, why does the mx28evk need gst-fsl-plugin at all? It has no video hardware acceleration that gstreamer uses, has it? > > To use the FSL's software optimized codecs; in fact I am not sure it > is a real gain but some customers want it and FSL's BSP has it so we > support it. IMHO we should use the standard Gstreamer components on mx28 instead of gst-fsl-plugin. Last time I measured the difference in performance on MP3 decoding was close to nothing. Regards, Fabio Estevam
On Wed, Nov 6, 2013 at 1:09 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Wed, Nov 6, 2013 at 10:35 AM, Otavio Salvador > <otavio@ossystems.com.br> wrote: >> On Wed, Nov 6, 2013 at 9:57 AM, Gonzalez, Alex <Alex.Gonzalez@digi.com> wrote: >>> Thanks Otavio. >>> >>> Just curious, why does the mx28evk need gst-fsl-plugin at all? It has no video hardware acceleration that gstreamer uses, has it? >> >> To use the FSL's software optimized codecs; in fact I am not sure it >> is a real gain but some customers want it and FSL's BSP has it so we >> support it. > > IMHO we should use the standard Gstreamer components on mx28 instead > of gst-fsl-plugin. > > Last time I measured the difference in performance on MP3 decoding was > close to nothing. Personally I agree with you but I think we need to support the FSL codecs as well as it is how MX28 BSP is officially released. When/if FSL drops the official support to gst-fsl-plugin for MX28 then we should drop it as well.