psplash: Show psplash before X in reboot/shutdown process

Submitted by eu@felipetonello.com on Oct. 28, 2013, 6:22 p.m.

Details

Message ID 1382984521-22179-1-git-send-email-eu@felipetonello.com
State New
Headers show

Commit Message

eu@felipetonello.com Oct. 28, 2013, 6:22 p.m.
From: "Felipe F. Tonello" <eu@felipetonello.com>

This is interesting because if you shutdown/reboot a device the screen will
flicker because X will be killed and then psplash will take a while to run.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 meta/recipes-core/psplash/psplash_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-core/psplash/psplash_git.bb b/meta/recipes-core/psplash/psplash_git.bb
index 1cab296..539bf52 100644
--- a/meta/recipes-core/psplash/psplash_git.bb
+++ b/meta/recipes-core/psplash/psplash_git.bb
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://psplash.h;beginline=1;endline=16;md5=840fb2356b10a85b
 
 SRCREV = "afd4e228c606a9998feae44a3fed4474803240b7"
 PV = "0.1+git${SRCPV}"
-PR = "r15"
+PR = "r16"
 
 SRC_URI = "git://git.yoctoproject.org/${BPN} \
            file://psplash-init \
@@ -108,4 +108,4 @@  do_install_append() {
 FILES_${PN} += "/mnt/.psplash"
 
 INITSCRIPT_NAME = "psplash.sh"
-INITSCRIPT_PARAMS = "start 0 S . stop 20 0 1 6 ."
+INITSCRIPT_PARAMS = "start 0 S . stop 02 0 1 6 ."

Comments

Otavio Salvador Oct. 28, 2013, 6:31 p.m.
On Mon, Oct 28, 2013 at 4:22 PM,  <eu@felipetonello.com> wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> This is interesting because if you shutdown/reboot a device the screen will
> flicker because X will be killed and then psplash will take a while to run.
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
...
>  SRCREV = "afd4e228c606a9998feae44a3fed4474803240b7"
>  PV = "0.1+git${SRCPV}"
> -PR = "r15"
> +PR = "r16"
...

Please  don't do PR bumps.
eu@felipetonello.com Oct. 28, 2013, 6:40 p.m.
Ok. But wouldn't be necessary in this case?

Also, this patch is inappropriate without a patch for X. So I would
suggest to ignore this patch for now.

Felipe

On Mon, Oct 28, 2013 at 11:31 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Mon, Oct 28, 2013 at 4:22 PM,  <eu@felipetonello.com> wrote:
>> From: "Felipe F. Tonello" <eu@felipetonello.com>
>>
>> This is interesting because if you shutdown/reboot a device the screen will
>> flicker because X will be killed and then psplash will take a while to run.
>>
>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ...
>>  SRCREV = "afd4e228c606a9998feae44a3fed4474803240b7"
>>  PV = "0.1+git${SRCPV}"
>> -PR = "r15"
>> +PR = "r16"
> ...
>
> Please  don't do PR bumps.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Otavio Salvador Oct. 28, 2013, 6:44 p.m.
On Mon, Oct 28, 2013 at 4:40 PM, Felipe Tonello <eu@felipetonello.com> wrote:
> Ok. But wouldn't be necessary in this case?
>
> Also, this patch is inappropriate without a patch for X. So I would
> suggest to ignore this patch for now.

The PRServ ought to do the right thing here, so the PR bump is not
necessary and just complicates backporting and like.

So as this is not a complete solution I am NACKing it.

Please resend it in a series with all need patches.