[1/1] kernel-yocto: Add a missing '['

Submitted by Peter Kjellerstedt on Oct. 10, 2013, 8:52 a.m.

Details

Message ID 355273a51c66495b635703627d588940a9c9c7d4.1381395083.git.pkj@axis.com
State Accepted
Commit 68a7d9f0e19ed577854a04610efc902062a369a8
Headers show

Commit Message

Peter Kjellerstedt Oct. 10, 2013, 8:52 a.m.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
 meta/classes/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 97a5fa7..8f79932 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -298,7 +298,7 @@  do_validate_branches() {
 	set +e
 	# if SRCREV is AUTOREV it shows up as AUTOINC there's nothing to
 	# check and we can exit early
-	if [ "${SRCREV_machine}" = "AUTOINC" ] || "${SRCREV_machine}" = "INVALID" ] ||
+	if [ "${SRCREV_machine}" = "AUTOINC" ] || [ "${SRCREV_machine}" = "INVALID" ] ||
 	   [ "${SRCREV_machine}" = "" ]; then
 		return
 	fi

Comments

Bruce Ashfield Oct. 11, 2013, 2:31 a.m.
On Thu, Oct 10, 2013 at 4:52 AM, Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>

Ouch. And the worst part is that I've since changed this line in some pre 1.6
work and didn't notice the fat finger slip.

I'd merge this myself, but I'm out of the office, so I'll ack it here,
and RP/Saul
can hopefully pick it up directly.

Bruce

> ---
>  meta/classes/kernel-yocto.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> index 97a5fa7..8f79932 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -298,7 +298,7 @@ do_validate_branches() {
>         set +e
>         # if SRCREV is AUTOREV it shows up as AUTOINC there's nothing to
>         # check and we can exit early
> -       if [ "${SRCREV_machine}" = "AUTOINC" ] || "${SRCREV_machine}" = "INVALID" ] ||
> +       if [ "${SRCREV_machine}" = "AUTOINC" ] || [ "${SRCREV_machine}" = "INVALID" ] ||
>            [ "${SRCREV_machine}" = "" ]; then
>                 return
>         fi
> --
> 1.8.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core