[bitbake-devel] serv/db: Fix looping upon database locked issues

Submitted by Richard Purdie on Aug. 31, 2013, 10:41 p.m.


Message ID 1377988895.1059.130.camel@ted
State New
Headers show

Commit Message

Richard Purdie Aug. 31, 2013, 10:41 p.m.
If the database is locked we will get an immediate error indicating so,
there is no retry timeout. The looping code is therefore useless, the loop
count is near instantly exceeded.

Using a time based retry means we can wait a sensible time, then gracefully

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Patch hide | download patch | download mbox

diff --git a/bitbake/lib/prserv/db.py b/bitbake/lib/prserv/db.py
index 7bc1980..b7190ba 100644
--- a/bitbake/lib/prserv/db.py
+++ b/bitbake/lib/prserv/db.py
@@ -2,6 +2,7 @@  import logging
 import os.path
 import errno
 import prserv
+import time
     import sqlite3
@@ -32,13 +33,13 @@  class PRTable(object):
     def _execute(self, *query):
         """Execute a query, waiting to acquire a lock if necessary"""
-        count = 0
+        start = time.time()
+        end = start + 20
         while True:
                 return self.conn.execute(*query)
             except sqlite3.OperationalError as exc:
-                if 'is locked' in str(exc) and count < 500:
-                    count = count + 1
+                if 'is locked' in str(exc) and end > time.time():
                 raise exc