stat: fix the wrong return code

Submitted by Zhangle Yang on Aug. 22, 2013, 7:42 a.m.

Details

Message ID 1377157335-21262-1-git-send-email-zhangle.yang@windriver.com
State Accepted
Commit c10435025f5c51c4827d71af82a9a517f5f8f6d8
Headers show

Commit Message

Zhangle Yang Aug. 22, 2013, 7:42 a.m.
After stat -h is executed, the return code is 1.
This patch changes it to 0.

Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com>
---
 .../stat/stat-3.3/fix-error-return.patch           |   16 ++++++++++++++++
 meta/recipes-extended/stat/stat_3.3.bb             |    3 ++-
 2 files changed, 18 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-extended/stat/stat-3.3/fix-error-return.patch

Patch hide | download patch | download mbox

diff --git a/meta/recipes-extended/stat/stat-3.3/fix-error-return.patch b/meta/recipes-extended/stat/stat-3.3/fix-error-return.patch
new file mode 100644
index 0000000..032995d
--- /dev/null
+++ b/meta/recipes-extended/stat/stat-3.3/fix-error-return.patch
@@ -0,0 +1,16 @@ 
+This patch fixies the wrong return code of stat -h.
+
+Upstream-Status: Pending
+Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com>
+
+--- stat-3.3/stat.c.orig	2013-08-22 10:49:45.000000000 +0800
++++ stat-3.3/stat.c	2013-08-22 10:50:31.000000000 +0800
+@@ -845,7 +845,7 @@
+     fprintf(stderr, "\t\t%%S - Security ID in SE-Linux\n");
+     fprintf(stderr, "\t\t%%C - Security context in SE-Linux\n");
+     fprintf(stderr, "\t\t%%d - Free file nodes in file system\n");
+-    exit(1);
++    exit(0);
+ }
+   
+ 
diff --git a/meta/recipes-extended/stat/stat_3.3.bb b/meta/recipes-extended/stat/stat_3.3.bb
index 73e0873..1131bdf 100644
--- a/meta/recipes-extended/stat/stat_3.3.bb
+++ b/meta/recipes-extended/stat/stat_3.3.bb
@@ -8,7 +8,8 @@  BBCLASSEXTEND = "native"
 
 PR = "r0"
 
-SRC_URI = "ftp://metalab.unc.edu/pub/Linux/utils/file/stat-3.3.tar.gz"
+SRC_URI = "ftp://metalab.unc.edu/pub/Linux/utils/file/stat-3.3.tar.gz \
+           file://fix-error-return.patch"
 SRC_URI[md5sum] = "37e247e8e400ad9205f1b0500b728fd3"
 SRC_URI[sha256sum] = "7071f0384a423a938dd542c1f08547a02824f6359acd3ef3f944b2c4c2d1ee09"
 

Comments

Khem Raj Aug. 22, 2013, 8:25 a.m.
On Aug 22, 2013, at 12:42 AM, Zhangle Yang <zhangle.yang@windriver.com> wrote:

> After stat -h is executed, the return code is 1.
> This patch changes it to 0.


aside from the patch. why don't we use stat from coreutils or busybox and drop maintaining
this old version of stat. Are there some use cases where we don't have busy box or coreutils on box ?


> Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com>
> ---
> .../stat/stat-3.3/fix-error-return.patch           |   16 ++++++++++++++++
> meta/recipes-extended/stat/stat_3.3.bb             |    3 ++-
> 2 files changed, 18 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-extended/stat/stat-3.3/fix-error-return.patch
> 
> diff --git a/meta/recipes-extended/stat/stat-3.3/fix-error-return.patch b/meta/recipes-extended/stat/stat-3.3/fix-error-return.patch
> new file mode 100644
> index 0000000..032995d
> --- /dev/null
> +++ b/meta/recipes-extended/stat/stat-3.3/fix-error-return.patch
> @@ -0,0 +1,16 @@
> +This patch fixies the wrong return code of stat -h.
> +
> +Upstream-Status: Pending
> +Signed-off-by: Zhangle Yang <zhangle.yang@windriver.com>
> +
> +--- stat-3.3/stat.c.orig	2013-08-22 10:49:45.000000000 +0800
> ++++ stat-3.3/stat.c	2013-08-22 10:50:31.000000000 +0800
> +@@ -845,7 +845,7 @@
> +     fprintf(stderr, "\t\t%%S - Security ID in SE-Linux\n");
> +     fprintf(stderr, "\t\t%%C - Security context in SE-Linux\n");
> +     fprintf(stderr, "\t\t%%d - Free file nodes in file system\n");
> +-    exit(1);
> ++    exit(0);
> + }
> +   
> + 
> diff --git a/meta/recipes-extended/stat/stat_3.3.bb b/meta/recipes-extended/stat/stat_3.3.bb
> index 73e0873..1131bdf 100644
> --- a/meta/recipes-extended/stat/stat_3.3.bb
> +++ b/meta/recipes-extended/stat/stat_3.3.bb
> @@ -8,7 +8,8 @@ BBCLASSEXTEND = "native"
> 
> PR = "r0"
> 
> -SRC_URI = "ftp://metalab.unc.edu/pub/Linux/utils/file/stat-3.3.tar.gz"
> +SRC_URI = "ftp://metalab.unc.edu/pub/Linux/utils/file/stat-3.3.tar.gz \
> +           file://fix-error-return.patch"
> SRC_URI[md5sum] = "37e247e8e400ad9205f1b0500b728fd3"
> SRC_URI[sha256sum] = "7071f0384a423a938dd542c1f08547a02824f6359acd3ef3f944b2c4c2d1ee09"
> 
> -- 
> 1.7.4.1
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core