[oe-layersetup] configs: Switch github repos from git to https

Message ID 20220318172714.17656-1-nm@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series [oe-layersetup] configs: Switch github repos from git to https | expand

Commit Message

Nishanth Menon March 18, 2022, 5:27 p.m. UTC
github announced removal of support of unencrypted git:// last
year[1], However, we still use git:// in many of our configurations.
Switch them over to https://

[1] https://github.blog/2021-09-01-improving-git-protocol-security-github/

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Also interesting is why are'nt we hearing wide-spread "oh oh.. it fails
to build??" comments?

$ git clone git://github.com/meta-qt5/meta-qt5.git
Cloning into 'meta-qt5'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Also, should we start considering shifting all to https:// ?

 configs/arago-dunfell-config.txt      | 4 ++--
 configs/arago-dunfell-next-config.txt | 4 ++--
 configs/arago-master-config.txt       | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

Comments

Ryan Eatmon March 18, 2022, 5:37 p.m. UTC | #1
What about all of the other configs?


On 3/18/2022 12:27, Nishanth Menon wrote:
> github announced removal of support of unencrypted git:// last
> year[1], However, we still use git:// in many of our configurations.
> Switch them over to https://
> 
> [1] https://github.blog/2021-09-01-improving-git-protocol-security-github/
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> Also interesting is why are'nt we hearing wide-spread "oh oh.. it fails
> to build??" comments?
> 
> $ git clone git://github.com/meta-qt5/meta-qt5.git
> Cloning into 'meta-qt5'...
> fatal: remote error:
>    The unauthenticated git protocol on port 9418 is no longer supported.
> Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
> 
> Also, should we start considering shifting all to https:// ?
> 
>   configs/arago-dunfell-config.txt      | 4 ++--
>   configs/arago-dunfell-next-config.txt | 4 ++--
>   configs/arago-master-config.txt       | 4 ++--
>   3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/configs/arago-dunfell-config.txt b/configs/arago-dunfell-config.txt
> index 464b835b7a30..60cc72a8d86f 100644
> --- a/configs/arago-dunfell-config.txt
> +++ b/configs/arago-dunfell-config.txt
> @@ -3,9 +3,9 @@
>   
>   bitbake,git://git.openembedded.org/bitbake,1.46,HEAD
>   meta-arago,git://git.yoctoproject.org/meta-arago,dunfell,HEAD,layers=meta-arago-distro:meta-arago-extras
> -# meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
> +# meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
>   # meta-python2,git://git.openembedded.org/meta-python2,dunfell,HEAD,layers=
> -meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
> +meta-qt5,https://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
>   meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,HEAD,layers=
>   meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
>   meta-ti,git://git.yoctoproject.org/meta-ti,dunfell,HEAD,layers=
> diff --git a/configs/arago-dunfell-next-config.txt b/configs/arago-dunfell-next-config.txt
> index 9657a727fda1..e2eb2023fec5 100644
> --- a/configs/arago-dunfell-next-config.txt
> +++ b/configs/arago-dunfell-next-config.txt
> @@ -3,9 +3,9 @@
>   
>   bitbake,git://git.openembedded.org/bitbake,1.46,HEAD
>   meta-arago,git://git.yoctoproject.org/meta-arago,dunfell-next,HEAD,layers=meta-arago-distro:meta-arago-extras
> -# meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
> +# meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
>   # meta-python2,git://git.openembedded.org/meta-python2,dunfell,HEAD,layers=
> -meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
> +meta-qt5,https://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
>   meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,HEAD,layers=
>   meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
>   meta-ti,git://git.yoctoproject.org/meta-ti,dunfell-next,HEAD,layers=
> diff --git a/configs/arago-master-config.txt b/configs/arago-master-config.txt
> index e4c6d7f0070e..bd0ccec58e16 100644
> --- a/configs/arago-master-config.txt
> +++ b/configs/arago-master-config.txt
> @@ -3,8 +3,8 @@
>   
>   bitbake,git://git.openembedded.org/bitbake,master,HEAD
>   meta-arago,git://git.yoctoproject.org/meta-arago,master,HEAD,layers=meta-arago-distro:meta-arago-extras
> -#meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
> -meta-qt5,git://github.com/meta-qt5/meta-qt5.git,master,HEAD,layers=
> +#meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
> +meta-qt5,https://github.com/meta-qt5/meta-qt5.git,master,HEAD,layers=
>   meta-virtualization,git://git.yoctoproject.org/meta-virtualization,master,HEAD,layers=
>   meta-openembedded,git://git.openembedded.org/meta-openembedded,master,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
>   meta-ti,git://git.yoctoproject.org/meta-ti,master,HEAD,layers=
Nishanth Menon March 18, 2022, 5:48 p.m. UTC | #2
On 12:37-20220318, Ryan Eatmon wrote:
> 
> What about all of the other configs?

Did'nt want to touch the baseline configs. I am assuming folks will
probably need to do the following in ~/.gitconfig

[url "https://github.com"]
        insteadOf = git://github.com
Ryan Eatmon March 18, 2022, 7:26 p.m. UTC | #3
I have applied this patch, but I think we need to consider editing the 
other configs.


On 3/18/2022 12:48, Nishanth Menon wrote:
> On 12:37-20220318, Ryan Eatmon wrote:
>>
>> What about all of the other configs?
> 
> Did'nt want to touch the baseline configs. I am assuming folks will
> probably need to do the following in ~/.gitconfig
> 
> [url "https://github.com"]
>          insteadOf = git://github.com
>
Denys Dmytriyenko March 18, 2022, 7:45 p.m. UTC | #4
On Fri, Mar 18, 2022 at 12:27:14PM -0500, Nishanth Menon wrote:
> github announced removal of support of unencrypted git:// last
> year[1], However, we still use git:// in many of our configurations.
> Switch them over to https://
> 
> [1] https://github.blog/2021-09-01-improving-git-protocol-security-github/
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> Also interesting is why are'nt we hearing wide-spread "oh oh.. it fails
> to build??" comments?

Because the actual builds have been fixed long ago:
https://git.openembedded.org/openembedded-core/commit/?id=b37b61e9a1e448a34957db9ae39285d21352552e
https://git.yoctoproject.org/meta-ti/commit/?h=dunfell&id=4c6598f599ddd6e9678819449bd6be1fbdf338a7
https://git.yoctoproject.org/meta-arago/commit/?h=dunfell&id=ae7f4644a637e22db4585cd6dd379cbfe4360766

Bitbake even has a workaround (and a warning) for this:
https://git.openembedded.org/bitbake/commit/?id=f05e19135b3ddee509c0cb427b3b9376bb4738d1
https://git.openembedded.org/bitbake/commit/?id=42526a402357e04794f4cb6f21ac18f562220a9b

These are configs for the layer setup mechanism, which got missed accidentally. 
This is a not well standardized area and people use different setup processes. 


> $ git clone git://github.com/meta-qt5/meta-qt5.git
> Cloning into 'meta-qt5'...
> fatal: remote error:
>   The unauthenticated git protocol on port 9418 is no longer supported.
> Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
> 
> Also, should we start considering shifting all to https:// ?
> 
>  configs/arago-dunfell-config.txt      | 4 ++--
>  configs/arago-dunfell-next-config.txt | 4 ++--
>  configs/arago-master-config.txt       | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/configs/arago-dunfell-config.txt b/configs/arago-dunfell-config.txt
> index 464b835b7a30..60cc72a8d86f 100644
> --- a/configs/arago-dunfell-config.txt
> +++ b/configs/arago-dunfell-config.txt
> @@ -3,9 +3,9 @@
>  
>  bitbake,git://git.openembedded.org/bitbake,1.46,HEAD
>  meta-arago,git://git.yoctoproject.org/meta-arago,dunfell,HEAD,layers=meta-arago-distro:meta-arago-extras
> -# meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
> +# meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
>  # meta-python2,git://git.openembedded.org/meta-python2,dunfell,HEAD,layers=
> -meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
> +meta-qt5,https://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
>  meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,HEAD,layers=
>  meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
>  meta-ti,git://git.yoctoproject.org/meta-ti,dunfell,HEAD,layers=
> diff --git a/configs/arago-dunfell-next-config.txt b/configs/arago-dunfell-next-config.txt
> index 9657a727fda1..e2eb2023fec5 100644
> --- a/configs/arago-dunfell-next-config.txt
> +++ b/configs/arago-dunfell-next-config.txt
> @@ -3,9 +3,9 @@
>  
>  bitbake,git://git.openembedded.org/bitbake,1.46,HEAD
>  meta-arago,git://git.yoctoproject.org/meta-arago,dunfell-next,HEAD,layers=meta-arago-distro:meta-arago-extras
> -# meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
> +# meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
>  # meta-python2,git://git.openembedded.org/meta-python2,dunfell,HEAD,layers=
> -meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
> +meta-qt5,https://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
>  meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,HEAD,layers=
>  meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
>  meta-ti,git://git.yoctoproject.org/meta-ti,dunfell-next,HEAD,layers=
> diff --git a/configs/arago-master-config.txt b/configs/arago-master-config.txt
> index e4c6d7f0070e..bd0ccec58e16 100644
> --- a/configs/arago-master-config.txt
> +++ b/configs/arago-master-config.txt
> @@ -3,8 +3,8 @@
>  
>  bitbake,git://git.openembedded.org/bitbake,master,HEAD
>  meta-arago,git://git.yoctoproject.org/meta-arago,master,HEAD,layers=meta-arago-distro:meta-arago-extras
> -#meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
> -meta-qt5,git://github.com/meta-qt5/meta-qt5.git,master,HEAD,layers=
> +#meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
> +meta-qt5,https://github.com/meta-qt5/meta-qt5.git,master,HEAD,layers=
>  meta-virtualization,git://git.yoctoproject.org/meta-virtualization,master,HEAD,layers=
>  meta-openembedded,git://git.openembedded.org/meta-openembedded,master,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
>  meta-ti,git://git.yoctoproject.org/meta-ti,master,HEAD,layers=
> -- 
> 2.31.1
>
Denys Dmytriyenko March 18, 2022, 7:55 p.m. UTC | #5
On Fri, Mar 18, 2022 at 02:26:15PM -0500, Ryan Eatmon wrote:
> 
> I have applied this patch, but I think we need to consider editing
> the other configs.

The only remaining configs are for past SDK releases - those are pinned down 
and not rolling, unlike those updated by Nishanth. Many of those releases are 
out of support already... I'd say, owners of corresponding SDKs should take 
care of updating still-supported release configs.

E.g. configs/coresdk/coresdk-08.xx.xx.xx-config.txt ... wink wink :)


> On 3/18/2022 12:48, Nishanth Menon wrote:
> >On 12:37-20220318, Ryan Eatmon wrote:
> >>
> >>What about all of the other configs?
> >
> >Did'nt want to touch the baseline configs. I am assuming folks will
> >probably need to do the following in ~/.gitconfig
> >
> >[url "https://github.com"]
> >         insteadOf = git://github.com
> >

Patch

diff --git a/configs/arago-dunfell-config.txt b/configs/arago-dunfell-config.txt
index 464b835b7a30..60cc72a8d86f 100644
--- a/configs/arago-dunfell-config.txt
+++ b/configs/arago-dunfell-config.txt
@@ -3,9 +3,9 @@ 
 
 bitbake,git://git.openembedded.org/bitbake,1.46,HEAD
 meta-arago,git://git.yoctoproject.org/meta-arago,dunfell,HEAD,layers=meta-arago-distro:meta-arago-extras
-# meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
+# meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
 # meta-python2,git://git.openembedded.org/meta-python2,dunfell,HEAD,layers=
-meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
+meta-qt5,https://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
 meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,HEAD,layers=
 meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
 meta-ti,git://git.yoctoproject.org/meta-ti,dunfell,HEAD,layers=
diff --git a/configs/arago-dunfell-next-config.txt b/configs/arago-dunfell-next-config.txt
index 9657a727fda1..e2eb2023fec5 100644
--- a/configs/arago-dunfell-next-config.txt
+++ b/configs/arago-dunfell-next-config.txt
@@ -3,9 +3,9 @@ 
 
 bitbake,git://git.openembedded.org/bitbake,1.46,HEAD
 meta-arago,git://git.yoctoproject.org/meta-arago,dunfell-next,HEAD,layers=meta-arago-distro:meta-arago-extras
-# meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
+# meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
 # meta-python2,git://git.openembedded.org/meta-python2,dunfell,HEAD,layers=
-meta-qt5,git://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
+meta-qt5,https://github.com/meta-qt5/meta-qt5.git,dunfell,HEAD,layers=
 meta-virtualization,git://git.yoctoproject.org/meta-virtualization,dunfell,HEAD,layers=
 meta-openembedded,git://git.openembedded.org/meta-openembedded,dunfell,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
 meta-ti,git://git.yoctoproject.org/meta-ti,dunfell-next,HEAD,layers=
diff --git a/configs/arago-master-config.txt b/configs/arago-master-config.txt
index e4c6d7f0070e..bd0ccec58e16 100644
--- a/configs/arago-master-config.txt
+++ b/configs/arago-master-config.txt
@@ -3,8 +3,8 @@ 
 
 bitbake,git://git.openembedded.org/bitbake,master,HEAD
 meta-arago,git://git.yoctoproject.org/meta-arago,master,HEAD,layers=meta-arago-distro:meta-arago-extras
-#meta-browser,git://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
-meta-qt5,git://github.com/meta-qt5/meta-qt5.git,master,HEAD,layers=
+#meta-browser,https://github.com/OSSystems/meta-browser.git,master,5f365ef0f842ba4651efe88787cf9c63bc8b6cb3,layers=
+meta-qt5,https://github.com/meta-qt5/meta-qt5.git,master,HEAD,layers=
 meta-virtualization,git://git.yoctoproject.org/meta-virtualization,master,HEAD,layers=
 meta-openembedded,git://git.openembedded.org/meta-openembedded,master,HEAD,layers=meta-networking:meta-python:meta-oe:meta-gnome:meta-filesystems
 meta-ti,git://git.yoctoproject.org/meta-ti,master,HEAD,layers=