| Message ID | 1368518279-8029-1-git-send-email-jukka.rissanen@linux.intel.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb index 2ce9530..a73cd13 100644 --- a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb +++ b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb @@ -6,7 +6,7 @@ PRIORITY = "optional" LICENSE = "GPL-2.0+" LIC_FILES_CHKSUM = "file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33" DEPENDS = "libgcrypt" -RDEPENDS_${PN} = "kernel-module-tun" +RDEPENDS_${PN} = "kernel-module-tun perl-module-io-file" CFLAGS_append = ' -DVERSION=\\"${PV}\\"' LDFLAGS_append = " -lgcrypt -lgpg-error"
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 14-05-13 09:57, Jukka Rissanen schreef: > > Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> --- This > version now properly rdepends on perl-module-io-file instead of just the > perl package. > > Cheers, Jukka > > meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +- 1 file > changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb > b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb index > 2ce9530..a73cd13 100644 --- > a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb +++ > b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb @@ -6,7 +6,7 @@ > PRIORITY = "optional" LICENSE = "GPL-2.0+" LIC_FILES_CHKSUM = > "file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33" DEPENDS = > "libgcrypt" -RDEPENDS_${PN} = "kernel-module-tun" +RDEPENDS_${PN} = > "kernel-module-tun perl-module-io-file" R* variables go below do_install, they are ordered in next to the tasks they get used in, which is do_package for R* -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) Comment: GPGTools - http://gpgtools.org iD8DBQFRkfDHMkyGM64RGpERAjt0AJ9hsPHsYnaDCmM20ja/kcCuonJNygCfUPvz Hp448ff5MXm9XIlMZfkG/w0= =sFZm -----END PGP SIGNATURE-----
[[oe] [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing] On 13.05.14 (Tue 10:57) Jukka Rissanen wrote: > > Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> > --- > This version now properly rdepends on perl-module-io-file instead of > just the perl package. > > Cheers, > Jukka > > meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb > index 2ce9530..a73cd13 100644 > --- a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb > +++ b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb > @@ -6,7 +6,7 @@ PRIORITY = "optional" > LICENSE = "GPL-2.0+" > LIC_FILES_CHKSUM = "file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33" > DEPENDS = "libgcrypt" > -RDEPENDS_${PN} = "kernel-module-tun" > +RDEPENDS_${PN} = "kernel-module-tun perl-module-io-file" > > CFLAGS_append = ' -DVERSION=\\"${PV}\\"' > LDFLAGS_append = " -lgcrypt -lgpg-error" Given that I'd already merged your previous change (and Koen is absolutely right, I should've pushed back on it too since I completely agree with him) can you send out another version of this patch that addresses his suggestion about reordering the R* variables and is against the latest tree? This one won't apply as the tree stands now. Thanks.
Hi Joe, On 14.05.2013 15:25, Joe MacDonald wrote: > [[oe] [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing] On 13.05.14 (Tue 10:57) Jukka Rissanen wrote: > >> > Given that I'd already merged your previous change (and Koen is > absolutely right, I should've pushed back on it too since I completely > agree with him) can you send out another version of this patch that > addresses his suggestion about reordering the R* variables and is > against the latest tree? This one won't apply as the tree stands now. > > Thanks. Sure, a new patch is in its way. Cheers, Jukka
Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> --- This version now properly rdepends on perl-module-io-file instead of just the perl package. Cheers, Jukka meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)