| Message ID | 20220308155252.2454464-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] qemu: Depend on virtual/egl | expand |
On Tue, 8 Mar 2022 at 15:52, Khem Raj <raj.khem@gmail.com> wrote: > -PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/libgl" > +PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/egl" Either the packageconfig name is wrong, or this patch is wrong: GLX is explicitly big-GL not EGL. Ross
On Wed, Mar 9, 2022 at 4:30 AM Ross Burton <ross@burtonini.com> wrote: > > On Tue, 8 Mar 2022 at 15:52, Khem Raj <raj.khem@gmail.com> wrote: > > -PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/libgl" > > +PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/egl" > > Either the packageconfig name is wrong, or this patch is wrong: GLX is > explicitly big-GL not EGL. Neither seems to be wrong. see https://github.com/qemu/qemu/blob/master/configure#L2289-L2313 It's expecting epoxy with egl. So virtual/egl is a better representation. Maybe we should add epoxy to depends section of packageconfig separately. > > Ross
On Thu, 2022-03-17 at 08:29 -0700, Khem Raj wrote: > On Wed, Mar 9, 2022 at 4:30 AM Ross Burton <ross@burtonini.com> wrote: > > > > On Tue, 8 Mar 2022 at 15:52, Khem Raj <raj.khem@gmail.com> wrote: > > > -PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/libgl" > > > +PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/egl" > > > > Either the packageconfig name is wrong, or this patch is wrong: GLX is > > explicitly big-GL not EGL. > > Neither seems to be wrong. see > https://github.com/qemu/qemu/blob/master/configure#L2289-L2313 > > It's expecting epoxy with egl. So virtual/egl is a better > representation. Maybe we should > add epoxy to depends section of packageconfig separately. I think Ross' point is that the PACKAGECONFIG option could do with renaming since it isn't GLX at all... Cheers, Richard
diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc index cbbb99f611d..86bf2c1016f 100644 --- a/meta/recipes-devtools/qemu/qemu.inc +++ b/meta/recipes-devtools/qemu/qemu.inc @@ -163,7 +163,7 @@ PACKAGECONFIG[nettle] = "--enable-nettle,--disable-nettle,nettle" PACKAGECONFIG[libusb] = "--enable-libusb,--disable-libusb,libusb1" PACKAGECONFIG[fdt] = "--enable-fdt,--disable-fdt,dtc" PACKAGECONFIG[alsa] = "--audio-drv-list=default,,alsa-lib" -PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/libgl" +PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,virtual/egl" PACKAGECONFIG[lzo] = "--enable-lzo,--disable-lzo,lzo" PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl" PACKAGECONFIG[gnutls] = "--enable-gnutls,--disable-gnutls,gnutls"
This abstracts on GL/GLES implementations Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-devtools/qemu/qemu.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)