Message ID | 4DDD90F9.5030901@intel.com |
---|---|
State | New, archived |
Headers | show |
On Wed, 2011-05-25 at 16:30 -0700, Elizabeth Flanagan wrote: > This pull request is a consolidated pull of some changes to the license.bbclass > license parsing, some cleanup of existing licenses, and some additions to/ > modifications of various licenses kept in meta/files/common-licenses. > > I've modified the common-licenses by adding licenses from the Software Package > and Data Exchange group/OSI and using their naming convention for internal > parsing within license.bbclass. > > Licenses were retrieved from http://spdx.org/licenses/ or > in cases where text of the license was missing: > http://opensource.linux-mirror.org/licenses/ > > I've also modified some recipe's LICENSE field, either because the field was > unparsable or the LICENSE was factually incorrect. This was not an entire audit > of every LICENSE field but there were some errors that were obvious. > > And lastly, using python abstract syntax trees as a parser and an ast visitor > class, I've begun the first steps to being able to put some sanity to license > selection. > > One note. License modifiers have traditionally been limited to the "or greater" > modifier "+". I've added another modifier "with exceptions" for licenses that > have no generic ie common-licenses/GPL-2,0-with-GCC-exception > > The modifiers are ignored for now, but I'll be looking at the logic for them > next. I like the direction you are going with this. Good job. I have one minor niggle in patch 2 of the series. Also you could probably merge all of the license.bbclass changes into one patch with a liberal application of git rebase -i and the fixup flag. Cheers, Joshua
On Wed, 2011-05-25 at 16:30 -0700, Elizabeth Flanagan wrote: > This pull request is a consolidated pull of some changes to the license.bbclass > license parsing, some cleanup of existing licenses, and some additions to/ > modifications of various licenses kept in meta/files/common-licenses. > > I've modified the common-licenses by adding licenses from the Software Package > and Data Exchange group/OSI and using their naming convention for internal > parsing within license.bbclass. > > Licenses were retrieved from http://spdx.org/licenses/ or > in cases where text of the license was missing: > http://opensource.linux-mirror.org/licenses/ > > I've also modified some recipe's LICENSE field, either because the field was > unparsable or the LICENSE was factually incorrect. This was not an entire audit > of every LICENSE field but there were some errors that were obvious. > > And lastly, using python abstract syntax trees as a parser and an ast visitor > class, I've begun the first steps to being able to put some sanity to license > selection. > > One note. License modifiers have traditionally been limited to the "or greater" > modifier "+". I've added another modifier "with exceptions" for licenses that > have no generic ie common-licenses/GPL-2,0-with-GCC-exception > > The modifiers are ignored for now, but I'll be looking at the logic for them > next. > > One side note. The listserve seems to limit mail size, so some of these PATCH > requests may get slammed to /dev/null. > > The following changes since commit 5d56586a00350f2ec90a7143182a3f1294fb4c73: > > binutils: Add missing dependency on zlib-native (2011-05-25 23:53:47 +0100) > > are available in the git repository at: > git://git.pokylinux.org/poky-contrib eflanagan/common-licenses > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=eflanagan/common-licenses > > Beth Flanagan (5): > common-licenses: Adding new licenses and renaming > License Field Cleanup: Non-standard field names I took these two big ones before anything changed and we started seeing rejects. > license.bbclass: Sane Parsing of licenses > license.bbclass: Fixing X-MIT SPDX license mapping > license.bbclass: Fixing LICENSE modifiers. For these, Josh spotted some debug left in and I think you can squash these into one commit. Cheers, Richard