| Message ID | 20240417182459.102143-1-wltu@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | rust-target-config: fix featrue for vfpv4f16 | expand |
On Wed, Apr 17, 2024 at 11:25 AM Willy Tu via lists.openembedded.org <wltu= google.com@lists.openembedded.org> wrote: > Based on [1] which fixed the target for vfpv3d16. Adding the support for > vfpv4d16 with the same set of changes. > Lgtm > Tested with running tokio which hit coredump before the change. It > worked fine after this change. > > [1] https://lists.openembedded.org/g/openembedded-core/message/185702 > > Signed-off-by: Willy Tu <wltu@google.com> > --- > meta/classes-recipe/rust-target-config.bbclass | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/classes-recipe/rust-target-config.bbclass > b/meta/classes-recipe/rust-target-config.bbclass > index 926b0630b1..330ad8a3f5 100644 > --- a/meta/classes-recipe/rust-target-config.bbclass > +++ b/meta/classes-recipe/rust-target-config.bbclass > @@ -21,6 +21,9 @@ def llvm_features_from_tune(d): > > if 'vfpv4' in feat: > f.append("+vfp4") > + elif 'vfpv4d16' in feat: > + f.append("+vfp4") > + f.append("-d32") > elif 'vfpv3' in feat: > f.append("+vfp3") > elif 'vfpv3d16' in feat: > -- > 2.44.0.769.g3c40516874-goog > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#198473): > https://lists.openembedded.org/g/openembedded-core/message/198473 > Mute This Topic: https://lists.openembedded.org/mt/105583303/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta/classes-recipe/rust-target-config.bbclass b/meta/classes-recipe/rust-target-config.bbclass index 926b0630b1..330ad8a3f5 100644 --- a/meta/classes-recipe/rust-target-config.bbclass +++ b/meta/classes-recipe/rust-target-config.bbclass @@ -21,6 +21,9 @@ def llvm_features_from_tune(d): if 'vfpv4' in feat: f.append("+vfp4") + elif 'vfpv4d16' in feat: + f.append("+vfp4") + f.append("-d32") elif 'vfpv3' in feat: f.append("+vfp3") elif 'vfpv3d16' in feat:
Based on [1] which fixed the target for vfpv3d16. Adding the support for vfpv4d16 with the same set of changes. Tested with running tokio which hit coredump before the change. It worked fine after this change. [1] https://lists.openembedded.org/g/openembedded-core/message/185702 Signed-off-by: Willy Tu <wltu@google.com> --- meta/classes-recipe/rust-target-config.bbclass | 3 +++ 1 file changed, 3 insertions(+)