diff mbox series

[meta-gnome,2/2] gedit: update 46.1 -> 46.2

Message ID 20240219070140.149267-2-f_l_k@t-online.de
State Accepted
Headers show
Series [meta-gnome,1/2] libgedit-gtksourceview: update 299.0.5 -> 299.1.0 | expand

Commit Message

Markus Volk Feb. 19, 2024, 7:01 a.m. UTC
Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 meta-gnome/recipes-gnome/gedit/{gedit_46.1.bb => gedit_46.2.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta-gnome/recipes-gnome/gedit/{gedit_46.1.bb => gedit_46.2.bb} (92%)

Comments

Khem Raj Feb. 20, 2024, 3:51 a.m. UTC | #1
with clang (clang-18) I am seeing this error

https://errors.yoctoproject.org/Errors/Details/753847/

On Sun, Feb 18, 2024 at 11:01 PM Markus Volk <f_l_k@t-online.de> wrote:
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  meta-gnome/recipes-gnome/gedit/{gedit_46.1.bb => gedit_46.2.bb} | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename meta-gnome/recipes-gnome/gedit/{gedit_46.1.bb => gedit_46.2.bb} (92%)
>
> diff --git a/meta-gnome/recipes-gnome/gedit/gedit_46.1.bb b/meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
> similarity index 92%
> rename from meta-gnome/recipes-gnome/gedit/gedit_46.1.bb
> rename to meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
> index c0221b9a7..c073eb9b9 100644
> --- a/meta-gnome/recipes-gnome/gedit/gedit_46.1.bb
> +++ b/meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
> @@ -23,7 +23,7 @@ inherit gnomebase gsettings itstool gnome-help gobject-introspection gtk-doc get
>  def gnome_verdir(v):
>      return oe.utils.trim_version(v, 1)
>
> -SRC_URI[archive.sha256sum] = "a1a6e37f041765dff7227a1f5578b6f49faaf016b1e17e869caf5bfb94c6aa4e"
> +SRC_URI[archive.sha256sum] = "c0866412bad147ebace2d282ffcbb5a0e9a304b20fd55640bee21c81e6d501ef"
>
>  # gobject-introspection is mandatory and cannot be configured
>  REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#108844): https://lists.openembedded.org/g/openembedded-devel/message/108844
> Mute This Topic: https://lists.openembedded.org/mt/104442407/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Markus Volk Feb. 20, 2024, 5:35 a.m. UTC | #2
There is already an issue for this:
<https://gitlab.gnome.org/GNOME/gedit/-/issues/588>

Unlike gtksourceview, libgedit-gtksourceview seems to be missing 
gtk_source_style_copy().
I was able to fix the build by doing so, but perhaps it would be best 
to wait and see what the developers of gedit plan to do?

+++ plugins/quickhighlight/gedit-quick-highlight-plugin.c 2024-02-20 
06:28:14.583217602 +0100
@@ -90,11 +90,12 @@
  if (style_scheme != NULL)
  {
   style = gtk_source_style_scheme_get_style (style_scheme, 
"quick-highlight-match");
-
+#if 0
   if (style != NULL)
   {
    plugin->priv->style = gtk_source_style_copy (style);
   }
+#endif
  }
 }


On Mon, Feb 19 2024 at 07:51:43 PM -08:00:00, Khem Raj 
<raj.khem@gmail.com> wrote:
> with clang (clang-18) I am seeing this error
> 
> <https://errors.yoctoproject.org/Errors/Details/753847/>
> 
> On Sun, Feb 18, 2024 at 11:01 PM Markus Volk <f_l_k@t-online.de 
> <mailto:f_l_k@t-online.de>> wrote:
>> 
>>  Signed-off-by: Markus Volk <f_l_k@t-online.de 
>> <mailto:f_l_k@t-online.de>>
>>  ---
>>   meta-gnome/recipes-gnome/gedit/{gedit_46.1.bb => gedit_46.2.bb} | 
>> 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>   rename meta-gnome/recipes-gnome/gedit/{gedit_46.1.bb => 
>> gedit_46.2.bb} (92%)
>> 
>>  diff --git a/meta-gnome/recipes-gnome/gedit/gedit_46.1.bb 
>> b/meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
>>  similarity index 92%
>>  rename from meta-gnome/recipes-gnome/gedit/gedit_46.1.bb
>>  rename to meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
>>  index c0221b9a7..c073eb9b9 100644
>>  --- a/meta-gnome/recipes-gnome/gedit/gedit_46.1.bb
>>  +++ b/meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
>>  @@ -23,7 +23,7 @@ inherit gnomebase gsettings itstool gnome-help 
>> gobject-introspection gtk-doc get
>>   def gnome_verdir(v):
>>       return oe.utils.trim_version(v, 1)
>> 
>>  -SRC_URI[archive.sha256sum] = 
>> "a1a6e37f041765dff7227a1f5578b6f49faaf016b1e17e869caf5bfb94c6aa4e"
>>  +SRC_URI[archive.sha256sum] = 
>> "c0866412bad147ebace2d282ffcbb5a0e9a304b20fd55640bee21c81e6d501ef"
>> 
>>   # gobject-introspection is mandatory and cannot be configured
>>   REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
>>  --
>>  2.43.0
>> 
>> 
>>  -=-=-=-=-=-=-=-=-=-=-=-
>>  Links: You receive all messages sent to this group.
>>  View/Reply Online (#108844): 
>> <https://lists.openembedded.org/g/openembedded-devel/message/108844>
>>  Mute This Topic: 
>> <https://lists.openembedded.org/mt/104442407/1997914>
>>  Group Owner: openembedded-devel+owner@lists.openembedded.org 
>> <mailto:openembedded-devel+owner@lists.openembedded.org>
>>  Unsubscribe: 
>> <https://lists.openembedded.org/g/openembedded-devel/unsub> 
>> [raj.khem@gmail.com <mailto:raj.khem@gmail.com>]
>>  -=-=-=-=-=-=-=-=-=-=-=-
>>
Khem Raj Feb. 20, 2024, 6:30 a.m. UTC | #3
On Mon, Feb 19, 2024 at 9:35 PM <f_l_k@t-online.de> wrote:
>
> There is already an issue for this:
> https://gitlab.gnome.org/GNOME/gedit/-/issues/588
>
> Unlike gtksourceview, libgedit-gtksourceview seems to be missing gtk_source_style_copy().
> I was able to fix the build by doing so, but perhaps it would be best to wait and see what the developers of gedit plan to do?
>

Perhaps a workaround until then is better for CI

> +++ plugins/quickhighlight/gedit-quick-highlight-plugin.c 2024-02-20 06:28:14.583217602 +0100
> @@ -90,11 +90,12 @@
>   if (style_scheme != NULL)
>   {
>    style = gtk_source_style_scheme_get_style (style_scheme, "quick-highlight-match");
> -
> +#if 0
>    if (style != NULL)
>    {
>     plugin->priv->style = gtk_source_style_copy (style);
>    }
> +#endif
>   }
>  }
>
>
> On Mon, Feb 19 2024 at 07:51:43 PM -08:00:00, Khem Raj <raj.khem@gmail.com> wrote:
>
> with clang (clang-18) I am seeing this error https://errors.yoctoproject.org/Errors/Details/753847/ On Sun, Feb 18, 2024 at 11:01 PM Markus Volk <f_l_k@t-online.de> wrote:
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta-gnome/recipes-gnome/gedit/{gedit_46.1.bb => gedit_46.2.bb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename meta-gnome/recipes-gnome/gedit/{gedit_46.1.bb => gedit_46.2.bb} (92%) diff --git a/meta-gnome/recipes-gnome/gedit/gedit_46.1.bb b/meta-gnome/recipes-gnome/gedit/gedit_46.2.bb similarity index 92% rename from meta-gnome/recipes-gnome/gedit/gedit_46.1.bb rename to meta-gnome/recipes-gnome/gedit/gedit_46.2.bb index c0221b9a7..c073eb9b9 100644 --- a/meta-gnome/recipes-gnome/gedit/gedit_46.1.bb +++ b/meta-gnome/recipes-gnome/gedit/gedit_46.2.bb @@ -23,7 +23,7 @@ inherit gnomebase gsettings itstool gnome-help gobject-introspection gtk-doc get def gnome_verdir(v): return oe.utils.trim_version(v, 1) -SRC_URI[archive.sha256sum] = "a1a6e37f041765dff7227a1f5578b6f49faaf016b1e17e869caf5bfb94c6aa4e" +SRC_URI[archive.sha256sum] = "c0866412bad147ebace2d282ffcbb5a0e9a304b20fd55640bee21c81e6d501ef" # gobject-introspection is mandatory and cannot be configured REQUIRED_DISTRO_FEATURES = "gobject-introspection-data" -- 2.43.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#108844): https://lists.openembedded.org/g/openembedded-devel/message/108844 Mute This Topic: https://lists.openembedded.org/mt/104442407/1997914 Group Owner: openembedded-devel+owner@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] -=-=-=-=-=-=-=-=-=-=-=-
diff mbox series

Patch

diff --git a/meta-gnome/recipes-gnome/gedit/gedit_46.1.bb b/meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
similarity index 92%
rename from meta-gnome/recipes-gnome/gedit/gedit_46.1.bb
rename to meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
index c0221b9a7..c073eb9b9 100644
--- a/meta-gnome/recipes-gnome/gedit/gedit_46.1.bb
+++ b/meta-gnome/recipes-gnome/gedit/gedit_46.2.bb
@@ -23,7 +23,7 @@  inherit gnomebase gsettings itstool gnome-help gobject-introspection gtk-doc get
 def gnome_verdir(v):
     return oe.utils.trim_version(v, 1)
 
-SRC_URI[archive.sha256sum] = "a1a6e37f041765dff7227a1f5578b6f49faaf016b1e17e869caf5bfb94c6aa4e"
+SRC_URI[archive.sha256sum] = "c0866412bad147ebace2d282ffcbb5a0e9a304b20fd55640bee21c81e6d501ef"
 
 # gobject-introspection is mandatory and cannot be configured
 REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"