From patchwork Mon Feb 21 21:23:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Orling X-Patchwork-Id: 3961 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A59C433F5 for ; Mon, 21 Feb 2022 21:23:57 +0000 (UTC) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mx.groups.io with SMTP id smtpd.web10.4739.1645478635931711706 for ; Mon, 21 Feb 2022 13:23:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LvIa04bu; spf=pass (domain: gmail.com, ip: 209.85.210.176, mailfrom: ticotimo@gmail.com) Received: by mail-pf1-f176.google.com with SMTP id y11so9954510pfi.11 for ; Mon, 21 Feb 2022 13:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=nUf6X97Ek4VL0EejCWN6NUAzAqTs8+iwKe39Nizihto=; b=LvIa04buOvA9OKJZAM83ie9q7u/wOsEf06ZAvkALwfDQExbaIq02K1RpzuoUmMMbPJ NV1n6BtlzWZnSQJF/ORD8bz1qzzzg/fDYaiF4IhVbvhX6YC6ijQknCq6ahD4WQg+1LCh bMVpdxqMr0RxyfWkFxnQhIkBfpuP82WzeqDNahAunbqrUIx4gNcDCnMtiTfVWs0Z1ckZ XRxBewtUE3V0p4eYwUhMGjAtvSKFGK+0isU3OdelDP0UIieFhcHN3AIFAEBT90eorNhx wpaMYObvBnSNG/jqSKQ900A/Xzyuymc0oSlo+OW+CExPx/2knASSPj8NMNFtxJ2OOOZ1 cJ5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=nUf6X97Ek4VL0EejCWN6NUAzAqTs8+iwKe39Nizihto=; b=w3ZMz9VuObiNU2SmxyuqqGM94gZBuDh5gkH9NZNGtoRzLocBBhb5y+t24IBXyLoPTY nKKhFaDz7vCu1jXPxrfbo0tgosWZSMXjVRGkTY0zShKbp+pzVqcFC/JzEZNhnR09jRqQ hRGiqGjuYNKhQZtS4kfmVPKfJDrrm09h/Q6Hu5G36n6WM6EuOy5HD5xr04fJ/8cdDa6j p+IC9nyCRJvCGsixos0+tRz7gE/Vc0VSRaT0uMkfk4IS7LyLx2xMHY9khrWym1BT+8IX YkGQTaGYRVVlyLH9weQ8FFMrznAM4/Tl0GZtO9e2wJuzrq3rAWZGmZpMAWdKlDifEVxk PBvQ== X-Gm-Message-State: AOAM5330qinXiSxIgiNuUszDDTjEdbqZvcVZw4W7WIyjOLfoWBdZ764W B8plSAa03/eaHWwwCGHELKTceZ2bnRBfFA== X-Google-Smtp-Source: ABdhPJznHfGPm1n7KbMzAzPcj4JaGEO1H09AwtXquTfew+MagJHKDAnV5HqaH9NN3YHFh9M8wZxtgw== X-Received: by 2002:a63:64c5:0:b0:34d:3d6c:31d2 with SMTP id y188-20020a6364c5000000b0034d3d6c31d2mr17333562pgb.499.1645478634551; Mon, 21 Feb 2022 13:23:54 -0800 (PST) Received: from nereus.hsd1.or.comcast.net ([2601:1c0:6000:1b20:d01c:96b7:6393:8c56]) by smtp.gmail.com with ESMTPSA id n85sm14081529pfd.142.2022.02.21.13.23.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 13:23:54 -0800 (PST) From: Tim Orling X-Google-Original-From: Tim Orling To: openembedded-core@lists.openembedded.org Subject: [PATCH v2 00/32] Python PEP-517: build wheels and install with pip Date: Mon, 21 Feb 2022 13:23:15 -0800 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 21 Feb 2022 21:23:57 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/162076 Upstream Python is moving to pyproject.toml rather than setup.py and wheels rather than eggs. The main place this is documented is in PEP-517[1]. Installing packages with setup.py install is deprecated. We have a choice with the 'kirkstone' LTS release of introducing this series (and fixing any fall out during the stabilization period) or living with deprecated Python packaging for the duration of the LTS (at a minimum 2 years). This seems to be a compelling enough reason to bring in this series, even if it results in a slight slip of the 'feature freeze', which is officially tomorrow, Monday 21 Feb, 2022. This series bootstraps python3-setuptools-native, python3-flit-core-native, python3-wheel-native and python3-pip-native, simply unzipping the wheel into PYTHON_SITEPACKAGES_DIR. This allows all other recipes to be installed with pip, as intended by upstream. Three new classes are introduced: (1) flit_core which builds PEP-517 compliant packages which use flit_core.buildapi as their build-backend. (2) setuptools_build_meta which builds PEP-517 compliant packages which use setuptools_build_meta as their build-backend. (3) pip_install_wheel, which simply installs wheels built by other classes. The original setuptools3.bbclass do_compile is modified to 'setup.py bdist_wheel' (from python3-wheel-native) rather than the deprecated 'setup.py build' mechanism. The original setuptools3.bbclass do_install is modified to use the pip_install_wheel.bbclass to install wheels with pip rather than the deprecated 'setup.py install' mechanism. For pip install, we disable dependency checking (--no-deps) because it proves to be brittle in our environment without providing full wheel cache that seems like overhead that we do not need. We also disable fetching wheels from pypi (--no-index). This is no different than our normal workflow of requiring dependencies to be defined in a recipe. Missing from this series is documentation of the new features, classes and variables (this will be done under separate cover). Also desired and previously discussed in YP meetings is a helper function to warn that a recipe which currently inherits setuptools3 but has a pyproject.toml and defines a build-system.build-backend should instead use of the new PEP-517 classes. This function is still in progress. During testing, recipes which use python3-setuptools-scm are failing to determine the version of the python package, For several recipes, the fix was to use pyproject.toml and PEP-517 build backends. To be sure, other recipes are still going to fail for the short term, until the root cause can be determined. This was not seen again in v2 builds. Another PEP-517 build-backend, poetry.core.masonry.api has been identified in recipes in meta-python, but not in oe-core. The python3-poetry-core recipe is WIP, but brings in a number of dependencies that are perhaps not worth it to bring into oe-core at this time. Rather we can support these recipes in meta-python? Fixes in v2 include passing --root=${D} to pip install (rather than --target) and also passing --prefix so that scripts are (usually) installed in the proper location. pip install also 'helpfully' overwrites python3 intepreter with nativepython3 in #!, so add a fix to return the values to what is actually correct (similar to what is done in setuptools3.bbclass). Also several recipes still needed PIP_INSTALL_PACKAGE defined. Also added self as maintainer of new recipes. [YOCTO #14638] [1] https://www.python.org/dev/peps/pep-0517/ The following changes since commit 41ae26ecab731f2fb6593df143476c94183be209: releases: update to include 3.4.2 (2022-02-21 16:46:22 +0000) are available in the Git repository at: git://git.yoctoproject.org/git/poky-contrib timo/bootstrap-wheels http://git.yoctoproject.org/cgit.cgi/git/poky-contrib/log/?h=timo/bootstrap-wheels Tim Orling (32): python3-wheel: move 0.37.0 from meta-python python3-flit-core: add recipe for 3.6.0 flit_core.bbclass: add helper for newer python packaging python3-wheel: inherit flit_core pip_install_wheel.bbclass: add helper class setuptools_build_meta.bbclass: add helper class python3-pip: inherit setuptools_build_meta python3-attrs: inherit setuptools_build_meta python3-git: inherit setuptools_build_meta python3-pytest: inherit setuptools_build_meta python3-setuptools-scm: inherit setuptools_build_meta python3-zipp: inherit setuptools_build_meta python3-iniconfig: inherit setuptools_build_meta python3-py: inherit setuptools_build_meta python3-pluggy: inherit setuptools_build_meta python3-setuptools: inherit setuptools_base_meta setuptools3.bbclass: refactor for wheels python3-more-itertools: set PIP_INSTALL_PACKAGE meson: inherit setuptools_build_meta python3-libarchive-d: set PIP_INSTALL_PACKAGE python3-smartypants: patch hash bang to python3 python3-scons: merge -native recipe python3-subunit: merge inc; set PIP_INSTALL_PACKAGE python3-magic: set PIP_INSTALL_PACKAGE bmap-tools: set PIP_INSTALL_PACKAGE, BASEVER asciidoc: set PIP_INSTALL_PACKAGE gi-docgen: set PIP_INSTALL_PACKAGE numpy: set PIP_INSTALL_PACKAGE python3-dbusmock: set PIP_INSTALL_PACKAGE python3-mako: inherit setuptools_build_meta python3-packaging: inherit setuptools_build_meta python3-nose: drop recipe meta/classes/flit_core.bbclass | 16 +++ meta/classes/pip_install_wheel.bbclass | 37 +++++++ meta/classes/setuptools3.bbclass | 20 ++-- meta/classes/setuptools_build_meta.bbclass | 18 ++++ meta/conf/distro/include/maintainers.inc | 3 +- meta/recipes-devtools/meson/meson_0.61.2.bb | 4 +- meta/recipes-devtools/python/python-nose.inc | 18 ---- .../python/python-subunit.inc | 14 --- .../python/python3-attrs_21.4.0.bb | 2 +- .../python/python3-dbusmock_0.25.0.bb | 1 + .../python/python3-flit-core_3.6.0.bb | 41 +++++++ .../python/python3-git_3.1.26.bb | 2 +- .../python/python3-iniconfig_1.1.1.bb | 4 +- .../python/python3-libarchive-c_4.0.bb | 2 + .../python/python3-magic_0.4.25.bb | 1 + .../python/python3-mako_1.1.6.bb | 2 +- .../python/python3-more-itertools_8.12.0.bb | 2 + .../python/python3-nose_1.3.7.bb | 2 - .../python/python3-numpy_1.22.2.bb | 1 + .../python/python3-packaging_21.3.bb | 2 +- .../python/python3-pip_22.0.3.bb | 19 +++- .../python/python3-pluggy_1.0.0.bb | 2 +- .../python/python3-py_1.11.0.bb | 2 +- .../python/python3-pytest_7.0.1.bb | 4 +- .../python/python3-scons-native_4.3.0.bb | 7 -- .../python/python3-scons_4.3.0.bb | 13 ++- .../python/python3-setuptools-scm_6.4.2.bb | 2 +- .../python/python3-setuptools_59.5.0.bb | 19 +++- .../0001-Change-hash-bang-to-python3.patch | 47 ++++++++ .../python/python3-smartypants_2.0.0.bb | 1 + ...001-setup.py-use-vendored-_distutils.patch | 27 +++++ .../python/python3-strict-rfc3339_0.7.bb | 4 +- .../python/python3-subunit_1.4.0.bb | 17 ++- ...roject.toml-from-flit-backend-branch.patch | 100 ++++++++++++++++++ .../python/python3-wheel_0.37.1.bb | 24 +++++ .../python/python3-zipp_3.7.0.bb | 2 +- .../asciidoc/asciidoc_10.1.1.bb | 1 + meta/recipes-gnome/gi-docgen/gi-docgen_git.bb | 1 + .../{bmap-tools_3.6.bb => bmap-tools_git.bb} | 6 +- 39 files changed, 412 insertions(+), 78 deletions(-) create mode 100644 meta/classes/flit_core.bbclass create mode 100644 meta/classes/pip_install_wheel.bbclass create mode 100644 meta/classes/setuptools_build_meta.bbclass delete mode 100644 meta/recipes-devtools/python/python-nose.inc delete mode 100644 meta/recipes-devtools/python/python-subunit.inc create mode 100644 meta/recipes-devtools/python/python3-flit-core_3.6.0.bb delete mode 100644 meta/recipes-devtools/python/python3-nose_1.3.7.bb delete mode 100644 meta/recipes-devtools/python/python3-scons-native_4.3.0.bb create mode 100644 meta/recipes-devtools/python/python3-smartypants/0001-Change-hash-bang-to-python3.patch create mode 100644 meta/recipes-devtools/python/python3-strict-rfc3339/0001-setup.py-use-vendored-_distutils.patch create mode 100644 meta/recipes-devtools/python/python3-wheel/0001-Backport-pyproject.toml-from-flit-backend-branch.patch create mode 100644 meta/recipes-devtools/python/python3-wheel_0.37.1.bb rename meta/recipes-support/bmap-tools/{bmap-tools_3.6.bb => bmap-tools_git.bb} (86%)