[for-denzil] gconf: Disable gtk support

Submitted by Franklin S. Cooper Jr on Oct. 4, 2012, 2:46 a.m.

Details

Message ID 1349318775-17939-1-git-send-email-fcooper@ti.com
State New
Headers show

Commit Message

Franklin S. Cooper Jr Oct. 4, 2012, 2:46 a.m.
From: Richard Purdie <richard.purdie@linuxfoundation.org>

There are only a couple of helper utilities within gconf that need gtk+ as a
dependency and those are unused and pretty useless. We might as well drop
the dependency on gtk and allow more parallel builds by reducing dependency
bottlenecks.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-gnome/gnome/gconf_3.2.3.bb |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-gnome/gnome/gconf_3.2.3.bb b/meta/recipes-gnome/gnome/gconf_3.2.3.bb
index ccbc24e..1da7203 100644
--- a/meta/recipes-gnome/gnome/gconf_3.2.3.bb
+++ b/meta/recipes-gnome/gnome/gconf_3.2.3.bb
@@ -6,10 +6,10 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605"
 POLKIT = "polkit"
 POLKIT_libc-uclibc = ""
 
-DEPENDS = "glib-2.0 gtk+ dbus dbus-glib libxml2 intltool-native ${POLKIT}"
+DEPENDS = "glib-2.0 dbus dbus-glib libxml2 intltool-native ${POLKIT}"
 DEPENDS_virtclass-native = "glib-2.0-native dbus-native dbus-glib-native libxml2-native intltool-native gnome-common-native"
 
-PR = "r8"
+PR = "r9"
 
 inherit gnomebase
 
@@ -26,10 +26,8 @@  POLKIT_OECONF = "--enable-defaults-service"
 POLKIT_OECONF_virtclass-native = "--disable-defaults-service"
 POLKIT_OECONF_libc-uclibc = "--disable-default-service"
 
-GTKOECONF = "--with-gtk=2.0 --enable-gtk"
-GTKOECONF_virtclass-native = "--disable-gtk"
 EXTRA_OECONF = "--disable-gtk-doc --enable-shared --disable-static --enable-debug=yes \
-                --disable-introspection --disable-orbit --with-openldap=no ${POLKIT_OECONF} ${GTKOECONF}"
+                --disable-introspection --disable-orbit --with-openldap=no ${POLKIT_OECONF} --disable-gtk"
 
 do_configure_prepend () {
 	touch gtk-doc.make

Comments

Koen Kooi Oct. 5, 2012, 6:26 a.m.
Op 4 okt. 2012, om 04:46 heeft Franklin S. Cooper Jr <fcooperjr27@gmail.com> het volgende geschreven:

> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> There are only a couple of helper utilities within gconf that need gtk+ as a
> dependency and those are unused and pretty useless. We might as well drop
> the dependency on gtk and allow more parallel builds by reducing dependency
> bottlenecks.

Except that gnome needs gconf-sanity-check, which is one of those "useless" binaries
Ross Burton Oct. 7, 2012, 6:06 a.m.
On Friday, 5 October 2012 at 07:26, Koen Kooi wrote:
> > There are only a couple of helper utilities within gconf that need gtk+ as a
> > dependency and those are unused and pretty useless. We might as well drop
> > the dependency on gtk and allow more parallel builds by reducing dependency
> > bottlenecks.
> 
> 
> 
> Except that gnome needs gconf-sanity-check, which is one of those "useless" binaries
From gnome-session:

/* This probably means gconf-sanity-check wasn't found, which
 * really shouldn't happen, but we'll just ignore it for now as
 * long as gconf seems to be working later on... */ 

It's not needed - you'll get a console warning that it can't be found and that is all.  Fixing the spawn to handle the error case where the sanity check cannot be found to not even produce that console warning would be a good upstreamable fix.

Ross