diff mbox series

[yocto-autobuilder-helper,v2] config.json: add "package-management" to images

Message ID 20231222131907.816564-1-michael.opdenacker@bootlin.com
State New
Headers show
Series [yocto-autobuilder-helper,v2] config.json: add "package-management" to images | expand

Commit Message

Michael Opdenacker Dec. 22, 2023, 1:19 p.m. UTC
From: Michael Opdenacker <michael.opdenacker@bootlin.com>

For the binary distro effort, we want to implement a test that generates a feed
of packages, typically from the tip of a release branch (or master), and then
try to use this feed to update an image generated for the latest tag (release
or milestone) on this branch.

This patch makes it possible to use the images produced for releases
at https://downloads.yoctoproject.org/releases/yocto/, as they currently
don't have package management enabled.

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
CC: Alexander Kanavin <alex.kanavin@gmail.com>

---
Note: could not test this change!

Changes in V2:
- Add context to the commit message
---
 config.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Alexander Kanavin Dec. 22, 2023, 2:13 p.m. UTC | #1
Thanks for explaining - I would instead make a 'poky-binary-distro'
distro configuration in meta-poky, and collect all needed settings in
there.

Placing this in config.json significantly changes how all of the
images on autobuilder are assembled and tested, particularly there is
no testing of images without package management anymore.

I would in general want to avoid adding any further 'global tweaks'
that override oe-core or poky defaults.

Alex

On Fri, 22 Dec 2023 at 14:19, <michael.opdenacker@bootlin.com> wrote:
>
> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
>
> For the binary distro effort, we want to implement a test that generates a feed
> of packages, typically from the tip of a release branch (or master), and then
> try to use this feed to update an image generated for the latest tag (release
> or milestone) on this branch.
>
> This patch makes it possible to use the images produced for releases
> at https://downloads.yoctoproject.org/releases/yocto/, as they currently
> don't have package management enabled.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> CC: Alexander Kanavin <alex.kanavin@gmail.com>
>
> ---
> Note: could not test this change!
>
> Changes in V2:
> - Add context to the commit message
> ---
>  config.json | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/config.json b/config.json
> index d504d07..bd0135e 100644
> --- a/config.json
> +++ b/config.json
> @@ -74,7 +74,8 @@
>              "BB_LOG_HOST_STAT_ON_FAILURE = '1'",
>              "BB_LOG_HOST_STAT_CMDS_FAILURE = 'oe-time-dd-test.sh -l'",
>              "SDK_TOOLCHAIN_LANGS += 'rust'",
> -            "BB_SERVER_TIMEOUT = '60'"
> +            "BB_SERVER_TIMEOUT = '60'",
> +            "EXTRA_IMAGE_FEATURES += 'package-management'",
>          ]
>      },
>      "templates" : {
> --
> 2.34.1
>
Michael Opdenacker Dec. 22, 2023, 3:24 p.m. UTC | #2
Hi Alex,

On 22.12.23 at 15:13, Alexander Kanavin wrote:
> Thanks for explaining - I would instead make a 'poky-binary-distro'
> distro configuration in meta-poky, and collect all needed settings in
> there.
>
> Placing this in config.json significantly changes how all of the
> images on autobuilder are assembled and tested, particularly there is
> no testing of images without package management anymore.
>
> I would in general want to avoid adding any further 'global tweaks'
> that override oe-core or poky defaults.

Thanks for your advice! Actually, I wasn't sure how to make the change.

If I understand correctly, even after I define a new 
'poky-binary-distro' distro in meta-poky (if agreed), I'll still have to 
add a new image to config.json, but indeed not touching existing ones.

Richard, would you be open to this suggestion?
Cheers
Michael.
Alexander Kanavin Dec. 22, 2023, 4:04 p.m. UTC | #3
On Fri, 22 Dec 2023 at 16:24, Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
> If I understand correctly, even after I define a new
> 'poky-binary-distro' distro in meta-poky (if agreed), I'll still have to
> add a new image to config.json, but indeed not touching existing ones.

You don't need new images, but you would have to define a new builder
entry in config.json that would set DISTRO to poky-binary-distro, and
then build exiting images, and do additional steps (e.g. publish the
package feeds).

Alex
Michael Opdenacker Dec. 22, 2023, 6:46 p.m. UTC | #4
Hi Alex,

On 22.12.23 at 17:04, Alexander Kanavin wrote:
> On Fri, 22 Dec 2023 at 16:24, Michael Opdenacker
> <michael.opdenacker@bootlin.com> wrote:
>> If I understand correctly, even after I define a new
>> 'poky-binary-distro' distro in meta-poky (if agreed), I'll still have to
>> add a new image to config.json, but indeed not touching existing ones.
> You don't need new images, but you would have to define a new builder
> entry in config.json that would set DISTRO to poky-binary-distro, and
> then build exiting images, and do additional steps (e.g. publish the
> package feeds).


Thanks for these clarifications, that helps!
However, if the same images are built, but with different distro 
settings, I still need to figure out where they will be generated, 
unlike the images on https://downloads.yoctoproject.org/releases/yocto/.

Thanks again
Michael.
diff mbox series

Patch

diff --git a/config.json b/config.json
index d504d07..bd0135e 100644
--- a/config.json
+++ b/config.json
@@ -74,7 +74,8 @@ 
             "BB_LOG_HOST_STAT_ON_FAILURE = '1'",
             "BB_LOG_HOST_STAT_CMDS_FAILURE = 'oe-time-dd-test.sh -l'",
             "SDK_TOOLCHAIN_LANGS += 'rust'",
-            "BB_SERVER_TIMEOUT = '60'"
+            "BB_SERVER_TIMEOUT = '60'",
+            "EXTRA_IMAGE_FEATURES += 'package-management'",
         ]
     },
     "templates" : {