From patchwork Wed Dec 13 11:50:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: harsimransingh.tungal@arm.com X-Patchwork-Id: 36153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A3EC4167B for ; Wed, 13 Dec 2023 11:51:02 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.34388.1702468254552187847 for ; Wed, 13 Dec 2023 03:50:54 -0800 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: harsimransingh.tungal@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 31062C15; Wed, 13 Dec 2023 03:51:40 -0800 (PST) Received: from e132995.cambridge.arm.com (e132995.arm.com [10.1.28.34]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 178EA3F762; Wed, 13 Dec 2023 03:50:52 -0800 (PST) From: harsimransingh.tungal@arm.com To: meta-arm@lists.yoctoproject.org, Ross.Burton@arm.com Cc: nd@arm.com, Harsimran Singh Tungal Subject: [PATCH 1/1] corstone1000:arm-bsp/tftf: Fix tftf tests on mps3 Date: Wed, 13 Dec 2023 11:50:41 +0000 Message-Id: <20231213115041.1417809-2-harsimransingh.tungal@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231213115041.1417809-1-harsimransingh.tungal@arm.com> References: <20231213115041.1417809-1-harsimransingh.tungal@arm.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 13 Dec 2023 11:51:02 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arm/message/5306 From: Harsimran Singh Tungal The tftf tests were getting crashed on the MPS3 and two issues were found during investigation. This change set provide fix for those issues: 1. The tftf tests were getting crashed on the MPS3 when compiled with LOG_LEVEL=50. So, reducing the log level and aligning it with the TF-A allows us to get rid of the crash. 2. Once the above crash got resolved, it has been found that tftf tests were getting asserted while reading the value of the register GICD_ITARGETSR. The reason for the crash is that the value of this register is zero. As per the GIC documentation, this register is RAZ/WI for uniprocessor implementation and corstone1000 is uniprocessor implementation for FPGA. So, this change compiles the tftf tests in release mode which allows us to compile out the assert definitions. Signed-off-by: Harsimran Singh Tungal --- .../recipes-bsp/trusted-firmware-a/tf-a-tests_%.bbappend | 3 +++ .../recipes-bsp/trusted-firmware-a/tf-a-tests_2.8.0.bb | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/tf-a-tests_%.bbappend b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/tf-a-tests_%.bbappend index 074bc683..eef21b93 100644 --- a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/tf-a-tests_%.bbappend +++ b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/tf-a-tests_%.bbappend @@ -2,5 +2,8 @@ COMPATIBLE_MACHINE:corstone1000 = "corstone1000" SRCREV:corstone1000 = "5f591f67738a1bbe6b262c53d9dad46ed8bbcd67" +EXTRA_OEMAKE:append:corstone1000 = " DEBUG=0" +EXTRA_OEMAKE:append:corstone1000 = " LOG_LEVEL=30" +TFTF_MODE:corstone1000 = "release" COMPATIBLE_MACHINE:n1sdp = "n1sdp" diff --git a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/tf-a-tests_2.8.0.bb b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/tf-a-tests_2.8.0.bb index ed3b3499..160ada67 100644 --- a/meta-arm-bsp/recipes-bsp/trusted-firmware-a/tf-a-tests_2.8.0.bb +++ b/meta-arm-bsp/recipes-bsp/trusted-firmware-a/tf-a-tests_2.8.0.bb @@ -19,6 +19,9 @@ EXTRA_OEMAKE += "USE_NVM=0" EXTRA_OEMAKE += "SHELL_COLOR=1" EXTRA_OEMAKE += "DEBUG=1" +# Modify mode based on debug or release mode +TFTF_MODE ?= "debug" + # Platform must be set for each machine TFA_PLATFORM ?= "invalid" @@ -45,7 +48,7 @@ SYSROOT_DIRS += "/firmware" do_install() { install -d -m 755 ${D}/firmware - install -m 0644 ${B}/${TFA_PLATFORM}/debug/tftf.bin ${D}/firmware/tftf.bin + install -m 0644 ${B}/${TFA_PLATFORM}/${TFTF_MODE}/tftf.bin ${D}/firmware/tftf.bin } do_deploy() {