[bitbake-devel] hob: print message when DISPLAY is not set

Submitted by Cristiana Voicu on Sept. 7, 2012, noon

Details

Message ID 1347019211-24363-1-git-send-email-cristiana.voicu@intel.com
State New
Headers show

Commit Message

Cristiana Voicu Sept. 7, 2012, noon
If DISPLAY wasn't set, launching hob has printed a traceback

Patch hide | download patch | download mbox

difficult to understand. Now, the exception is caught and it
shows a human message.

[YOCTO #2596]

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/builder.py |   13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py
index 7de4798..f9e54a8 100755
--- a/bitbake/lib/bb/ui/crumbs/builder.py
+++ b/bitbake/lib/bb/ui/crumbs/builder.py
@@ -28,6 +28,7 @@  import subprocess
 import shlex
 import re
 import logging
+import sys
 from bb.ui.crumbs.template import TemplateMgr
 from bb.ui.crumbs.imageconfigurationpage import ImageConfigurationPage
 from bb.ui.crumbs.recipeselectionpage import RecipeSelectionPage
@@ -457,8 +458,14 @@  class Builder(gtk.Window):
         self.set_title("Hob")
         self.set_icon_name("applications-development")
         self.set_resizable(True)
-        window_width = self.get_screen().get_width()
-        window_height = self.get_screen().get_height()
+
+        try:
+            window_width = self.get_screen().get_width()
+            window_height = self.get_screen().get_height()
+        except AttributeError:
+            print "Please set DISPLAY variable before running Hob."
+            sys.exit(1)
+
         if window_width >= hwc.MAIN_WIN_WIDTH:
             window_width = hwc.MAIN_WIN_WIDTH
             window_height = hwc.MAIN_WIN_HEIGHT
@@ -1334,4 +1341,4 @@  class Builder(gtk.Window):
             format = bb.msg.BBLogFormatter("%(levelname)s: %(message)s")
             self.consolelog.setFormatter(format)
 
-            self.logger.addHandler(self.consolelog)
\ No newline at end of file
+            self.logger.addHandler(self.consolelog)

Comments

Richard Purdie Sept. 7, 2012, 1:47 p.m.
On Fri, 2012-09-07 at 15:00 +0300, Cristiana Voicu wrote:
> If DISPLAY wasn't set, launching hob has printed a traceback
> difficult to understand. Now, the exception is caught and it
> shows a human message.
> 
> [YOCTO #2596]
> 
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/builder.py |   13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

Merged to master, thanks.

> diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py
> index 7de4798..f9e54a8 100755
> --- a/bitbake/lib/bb/ui/crumbs/builder.py
> +++ b/bitbake/lib/bb/ui/crumbs/builder.py
> @@ -1334,4 +1341,4 @@ class Builder(gtk.Window):
>              format = bb.msg.BBLogFormatter("%(levelname)s: %(message)s")
>              self.consolelog.setFormatter(format)
>  
> -            self.logger.addHandler(self.consolelog)
> \ No newline at end of file
> +            self.logger.addHandler(self.consolelog)

I keep seeing this piece in your patches which doesn't seem to want to
apply and the line ending looks correct in the main repository. Can you
see if there is some problem locally?

Cheers,

Richard