| Message ID | 20231122220508.3148727-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | init-manager-mdev-busybox: Keep sysvinit distro feature on | expand |
From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Khem Raj via lists.openembedded.org > The rcS script that busybox-init provides is able to run scripts that > are available as part of sysvinit, therefore its fine to keep sysvinit > distro feature enabled so that we can build complex systems with > busybox as init system. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/conf/distro/include/init-manager-mdev-busybox.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/conf/distro/include/init-manager-mdev-busybox.inc b/meta/conf/distro/include/init-manager-mdev-busybox.inc > index 12091cba68c..a5a61bbe4d2 100644 > --- a/meta/conf/distro/include/init-manager-mdev-busybox.inc > +++ b/meta/conf/distro/include/init-manager-mdev-busybox.inc > @@ -1,5 +1,6 @@ > # enable mdev/busybox for init > -DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd sysvinit" > +DISTRO_FEATURES:append = " sysvinit" I don't think that this append is a good idea. I want a small, lean, controllable init system, not a complex one. This probably belongs to distro or to a new INIT_MANAGER type. > +DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd" > VIRTUAL-RUNTIME_dev_manager ??= "busybox-mdev" > VIRTUAL-RUNTIME_init_manager ??= "busybox" > VIRTUAL-RUNTIME_initscripts ??= "initscripts" > -- > 2.43.0
On Wed, Nov 22, 2023 at 2:59 PM Marko, Peter <Peter.Marko@siemens.com> wrote: > > From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Khem Raj via lists.openembedded.org > > > The rcS script that busybox-init provides is able to run scripts that > > are available as part of sysvinit, therefore its fine to keep sysvinit > > distro feature enabled so that we can build complex systems with > > busybox as init system. > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta/conf/distro/include/init-manager-mdev-busybox.inc | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/meta/conf/distro/include/init-manager-mdev-busybox.inc b/meta/conf/distro/include/init-manager-mdev-busybox.inc > > index 12091cba68c..a5a61bbe4d2 100644 > > --- a/meta/conf/distro/include/init-manager-mdev-busybox.inc > > +++ b/meta/conf/distro/include/init-manager-mdev-busybox.inc > > @@ -1,5 +1,6 @@ > > # enable mdev/busybox for init > > -DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd sysvinit" > > +DISTRO_FEATURES:append = " sysvinit" > > I don't think that this append is a good idea. > I want a small, lean, controllable init system, not a complex one. > This probably belongs to distro or to a new INIT_MANAGER type. That's fair. Although one can easily build a full system just with busybox-init like this perhaps it should be a separate INIT_MANAGER perhaps eudev-busybox or some such. > > > +DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd" > > VIRTUAL-RUNTIME_dev_manager ??= "busybox-mdev" > > VIRTUAL-RUNTIME_init_manager ??= "busybox" > > VIRTUAL-RUNTIME_initscripts ??= "initscripts" > > -- > > 2.43.0 >
diff --git a/meta/conf/distro/include/init-manager-mdev-busybox.inc b/meta/conf/distro/include/init-manager-mdev-busybox.inc index 12091cba68c..a5a61bbe4d2 100644 --- a/meta/conf/distro/include/init-manager-mdev-busybox.inc +++ b/meta/conf/distro/include/init-manager-mdev-busybox.inc @@ -1,5 +1,6 @@ # enable mdev/busybox for init -DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd sysvinit" +DISTRO_FEATURES:append = " sysvinit" +DISTRO_FEATURES_BACKFILL_CONSIDERED:append = " systemd" VIRTUAL-RUNTIME_dev_manager ??= "busybox-mdev" VIRTUAL-RUNTIME_init_manager ??= "busybox" VIRTUAL-RUNTIME_initscripts ??= "initscripts"
The rcS script that busybox-init provides is able to run scripts that are available as part of sysvinit, therefore its fine to keep sysvinit distro feature enabled so that we can build complex systems with busybox as init system. Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/conf/distro/include/init-manager-mdev-busybox.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)