[honister] insane.bbclass: Correct package_qa_check_empty_dirs()

Message ID 20220208154731.10107-1-pkj@axis.com
State New
Headers show
Series [honister] insane.bbclass: Correct package_qa_check_empty_dirs() | expand

Commit Message

Peter Kjellerstedt Feb. 8, 2022, 3:47 p.m. UTC
The oe.qa.add_message() method is not available in Honister, use
package_qa_add_message() instead.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
 meta/classes/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin Jansa Feb. 8, 2022, 3:50 p.m. UTC | #1
This should be sent to oe-core ML.

On Tue, Feb 8, 2022 at 4:47 PM Peter Kjellerstedt <
peter.kjellerstedt@axis.com> wrote:

> The oe.qa.add_message() method is not available in Honister, use
> package_qa_add_message() instead.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
>  meta/classes/insane.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index bfaf2577d0..2c8f5338e5 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -945,7 +945,7 @@ def package_qa_check_empty_dirs(pkg, d, messages):
>              recommendation = (d.getVar('QA_EMPTY_DIRS_RECOMMENDATION:' +
> dir) or
>                                "but it is expected to be empty")
>              msg = "%s installs files in %s, %s" % (pkg, dir,
> recommendation)
> -            oe.qa.add_message(messages, "empty-dirs", msg)
> +            package_qa_add_message(messages, "empty-dirs", msg)
>
>  def package_qa_check_encoding(keys, encode, d):
>      def check_encoding(key, enc):
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#95264):
> https://lists.openembedded.org/g/openembedded-devel/message/95264
> Mute This Topic: https://lists.openembedded.org/mt/88999081/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Peter Kjellerstedt Feb. 8, 2022, 3:53 p.m. UTC | #2
Actually, it shouldn’t have been sent at all as I had already sent it to the oe-core list.

//Peter

From: Martin Jansa <martin.jansa@gmail.com>
Sent: den 8 februari 2022 16:50
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [honister][PATCH] insane.bbclass: Correct package_qa_check_empty_dirs()

This should be sent to oe-core ML.

On Tue, Feb 8, 2022 at 4:47 PM Peter Kjellerstedt <peter.kjellerstedt@axis.com<mailto:peter.kjellerstedt@axis.com>> wrote:
The oe.qa.add_message() method is not available in Honister, use
package_qa_add_message() instead.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com<mailto:peter.kjellerstedt@axis.com>>
---
 meta/classes/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index bfaf2577d0..2c8f5338e5 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -945,7 +945,7 @@ def package_qa_check_empty_dirs(pkg, d, messages):
             recommendation = (d.getVar('QA_EMPTY_DIRS_RECOMMENDATION:' + dir) or
                               "but it is expected to be empty")
             msg = "%s installs files in %s, %s" % (pkg, dir, recommendation)
-            oe.qa.add_message(messages, "empty-dirs", msg)
+            package_qa_add_message(messages, "empty-dirs", msg)

 def package_qa_check_encoding(keys, encode, d):
     def check_encoding(key, enc):

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#95264): https://lists.openembedded.org/g/openembedded-devel/message/95264
Mute This Topic: https://lists.openembedded.org/mt/88999081/3617156
Group Owner: openembedded-devel+owner@lists.openembedded.org<mailto:openembedded-devel%2Bowner@lists.openembedded.org>
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [Martin.Jansa@gmail.com<mailto:Martin.Jansa@gmail.com>]
-=-=-=-=-=-=-=-=-=-=-=-

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index bfaf2577d0..2c8f5338e5 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -945,7 +945,7 @@  def package_qa_check_empty_dirs(pkg, d, messages):
             recommendation = (d.getVar('QA_EMPTY_DIRS_RECOMMENDATION:' + dir) or
                               "but it is expected to be empty")
             msg = "%s installs files in %s, %s" % (pkg, dir, recommendation)
-            oe.qa.add_message(messages, "empty-dirs", msg)
+            package_qa_add_message(messages, "empty-dirs", msg)
 
 def package_qa_check_encoding(keys, encode, d):
     def check_encoding(key, enc):