| Message ID | 1295710776-10995-1-git-send-email-lm@larsmichelsen.com |
|---|---|
| State | Superseded |
| Headers | show |
diff --git a/recipes/python/python-caldav_0.1.6.bb b/recipes/python/python-caldav_0.1.6.bb new file mode 100644 index 0000000..ecf8e39 --- /dev/null +++ b/recipes/python/python-caldav_0.1.6.bb @@ -0,0 +1,16 @@ +DESCRIPTION = "This project is a CalDAV (RFC4791) client library for Python." +SECTION = "devel/python" +PRIORITY = "optional" +LICENSE = "GPL" +HOMEPAGE = "http://bitbucket.org/cyrilrbt/caldav" +SRCNAME = "caldav" +PR = "r0" +DEPENDS = "python python-lxml python-vobject" + +SRC_URI = "http://pypi.python.org/packages/source/c/${SRCNAME}/${SRCNAME}-${PV}.tar.gz" +S = "${WORKDIR}/${SRCNAME}-${PV}" + +inherit setuptools + +SRC_URI[md5sum] = "e5eace7a3b6b7f511a1929a539e6a15d" +SRC_URI[sha256sum] = "4a3b1855000feb8023ab05f8c9e0cfa1648a9abab9ca65ad3e933c22bab61310"
Am Samstag, den 22.01.2011, 16:39 +0100 schrieb Lars Michelsen: > This patch adds a new reciep for the python caldav client library module. s/reciep/recipe/ (also in commit summary) It is not policy, but I like also to have a note in the commit message, what distribution and architecture this recipe was build tested with. And if it was tested. > Signed-off-by: Lars Michelsen <lm@larsmichelsen.com> > --- > recipes/python/python-caldav_0.1.6.bb | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > create mode 100644 recipes/python/python-caldav_0.1.6.bb > > diff --git a/recipes/python/python-caldav_0.1.6.bb b/recipes/python/python-caldav_0.1.6.bb > new file mode 100644 > index 0000000..ecf8e39 > --- /dev/null > +++ b/recipes/python/python-caldav_0.1.6.bb > @@ -0,0 +1,16 @@ > +DESCRIPTION = "This project is a CalDAV (RFC4791) client library for Python." > +SECTION = "devel/python" > +PRIORITY = "optional" > +LICENSE = "GPL" > +HOMEPAGE = "http://bitbucket.org/cyrilrbt/caldav" > +SRCNAME = "caldav" > +PR = "r0" > +DEPENDS = "python python-lxml python-vobject" > + > +SRC_URI = "http://pypi.python.org/packages/source/c/${SRCNAME}/${SRCNAME}-${PV}.tar.gz" > +S = "${WORKDIR}/${SRCNAME}-${PV}" I did not know of `${SRCNAME}` before. I think `${PN}` is more common (since it is shorter?). Now I see that you defined it in the beginning. You can use `${PN}`. > +inherit setuptools > + > +SRC_URI[md5sum] = "e5eace7a3b6b7f511a1929a539e6a15d" > +SRC_URI[sha256sum] = "4a3b1855000feb8023ab05f8c9e0cfa1648a9abab9ca65ad3e933c22bab61310" I think these are put right below the first occurrence of `SRC_URI`. But the style guide [1] does not mention it explicitly. Thanks, Paul [1] http://wiki.openembedded.org/index.php/Styleguide
Hello Paul, thanks for your review. On 22/01/11 16:59, Paul Menzel wrote: > Am Samstag, den 22.01.2011, 16:39 +0100 schrieb Lars Michelsen: >> This patch adds a new reciep for the python caldav client library module. > > s/reciep/recipe/ (also in commit summary) > > It is not policy, but I like also to have a note in the commit message, > what distribution and architecture this recipe was build tested with. > And if it was tested. Ok, will add those notes in the next patches. > I did not know of `${SRCNAME}` before. I think `${PN}` is more common > (since it is shorter?). Now I see that you defined it in the beginning. > You can use `${PN}`. I just copied most parts from other python-* recipes. The most of them seem to use SRCNAME. PN containes the whole package name, right? Means 'python-caldav' in this case while SRCNAME only contains the module name 'caldav'. > >> +inherit setuptools >> + >> +SRC_URI[md5sum] = "e5eace7a3b6b7f511a1929a539e6a15d" >> +SRC_URI[sha256sum] = "4a3b1855000feb8023ab05f8c9e0cfa1648a9abab9ca65ad3e933c22bab61310" > > I think these are put right below the first occurrence of `SRC_URI`. But > the style guide [1] does not mention it explicitly. Same here. Seam a lot of python-* packages have it at the end of the file. While creating/editing such a file it is more intuitive to have these definitions right below SRC_URI. So I aggree with you and will move these lines. I just posted a 2nd version of the patch. Thanks & Regards, Lars
This patch adds a new reciep for the python caldav client library module. Signed-off-by: Lars Michelsen <lm@larsmichelsen.com> --- recipes/python/python-caldav_0.1.6.bb | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 recipes/python/python-caldav_0.1.6.bb