diff mbox series

[meta-yocto-bsp] machine: drop obsolete SERIAL_CONSOLES_CHECK

Message ID 20231102103648.3681280-1-chee.yang.lee@intel.com (mailing list archive)
State New
Headers show
Series [meta-yocto-bsp] machine: drop obsolete SERIAL_CONSOLES_CHECK | expand

Commit Message

Lee, Chee Yang Nov. 2, 2023, 10:36 a.m. UTC
From: Lee Chee Yang <chee.yang.lee@intel.com>

Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com>
---
 meta-yocto-bsp/conf/machine/beaglebone-yocto.conf | 1 -
 meta-yocto-bsp/conf/machine/genericx86-64.conf    | 1 -
 2 files changed, 2 deletions(-)

Comments

Michael Opdenacker Nov. 2, 2023, 1:28 p.m. UTC | #1
Hi Lee,

On 02.11.23 at 11:36, Lee Chee Yang wrote:
> From: Lee Chee Yang <chee.yang.lee@intel.com>
>
> Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com>
> ---
>   meta-yocto-bsp/conf/machine/beaglebone-yocto.conf | 1 -
>   meta-yocto-bsp/conf/machine/genericx86-64.conf    | 1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
> index 8b67cefef7..9f389711b3 100644
> --- a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
> +++ b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
> @@ -18,7 +18,6 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-image kernel-devicetree"
>   do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot virtual/bootloader:do_deploy"
>   
>   SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyO0 115200;ttyAMA0"
> -SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
>   
>   PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto"
>   PREFERRED_VERSION_linux-yocto ?= "6.1%"
> diff --git a/meta-yocto-bsp/conf/machine/genericx86-64.conf b/meta-yocto-bsp/conf/machine/genericx86-64.conf
> index 14913ea1f1..f19a1c1527 100644
> --- a/meta-yocto-bsp/conf/machine/genericx86-64.conf
> +++ b/meta-yocto-bsp/conf/machine/genericx86-64.conf
> @@ -6,6 +6,5 @@ DEFAULTTUNE ?= "core2-64"
>   require conf/machine/include/x86/tune-core2.inc
>   require conf/machine/include/genericx86-common.inc
>   
> -SERIAL_CONSOLES_CHECK = "ttyS0"
>   #For runqemu
>   QB_SYSTEM_NAME = "qemu-system-x86_64"


Many thanks for this change (now in master).
What about another patch to remove it from meta/conf/documentation.conf too?
Thanks again
Michael.
Lee, Chee Yang Nov. 3, 2023, 5:40 a.m. UTC | #2
> -----Original Message-----
> From: poky@lists.yoctoproject.org <poky@lists.yoctoproject.org> On Behalf Of
> Michael Opdenacker via lists.yoctoproject.org
> Sent: Thursday, November 2, 2023 9:29 PM
> To: Lee, Chee Yang <chee.yang.lee@intel.com>
> Cc: poky@lists.yoctoproject.org
> Subject: Re: [poky] [meta-yocto-bsp][PATCH] machine: drop obsolete
> SERIAL_CONSOLES_CHECK
> 
> Hi Lee,
> 
> On 02.11.23 at 11:36, Lee Chee Yang wrote:
> > From: Lee Chee Yang <chee.yang.lee@intel.com>
> >
> > Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com>
> > ---
> >   meta-yocto-bsp/conf/machine/beaglebone-yocto.conf | 1 -
> >   meta-yocto-bsp/conf/machine/genericx86-64.conf    | 1 -
> >   2 files changed, 2 deletions(-)
> >
> > diff --git a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf b/meta-
> yocto-bsp/conf/machine/beaglebone-yocto.conf
> > index 8b67cefef7..9f389711b3 100644
> > --- a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
> > +++ b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
> > @@ -18,7 +18,6 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-
> image kernel-devicetree"
> >   do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-
> native:do_populate_sysroot virtual/bootloader:do_deploy"
> >
> >   SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyO0 115200;ttyAMA0"
> > -SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
> >
> >   PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto"
> >   PREFERRED_VERSION_linux-yocto ?= "6.1%"
> > diff --git a/meta-yocto-bsp/conf/machine/genericx86-64.conf b/meta-yocto-
> bsp/conf/machine/genericx86-64.conf
> > index 14913ea1f1..f19a1c1527 100644
> > --- a/meta-yocto-bsp/conf/machine/genericx86-64.conf
> > +++ b/meta-yocto-bsp/conf/machine/genericx86-64.conf
> > @@ -6,6 +6,5 @@ DEFAULTTUNE ?= "core2-64"
> >   require conf/machine/include/x86/tune-core2.inc
> >   require conf/machine/include/genericx86-common.inc
> >
> > -SERIAL_CONSOLES_CHECK = "ttyS0"
> >   #For runqemu
> >   QB_SYSTEM_NAME = "qemu-system-x86_64"
> 
> 
> Many thanks for this change (now in master).
> What about another patch to remove it from meta/conf/documentation.conf too?[] 

I missed this. Will send separate patch to Oe-core mailing list.

> Thanks again
> Michael.
> 
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
diff mbox series

Patch

diff --git a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
index 8b67cefef7..9f389711b3 100644
--- a/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
+++ b/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
@@ -18,7 +18,6 @@  MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-image kernel-devicetree"
 do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot virtual/bootloader:do_deploy"
 
 SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyO0 115200;ttyAMA0"
-SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
 
 PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto"
 PREFERRED_VERSION_linux-yocto ?= "6.1%"
diff --git a/meta-yocto-bsp/conf/machine/genericx86-64.conf b/meta-yocto-bsp/conf/machine/genericx86-64.conf
index 14913ea1f1..f19a1c1527 100644
--- a/meta-yocto-bsp/conf/machine/genericx86-64.conf
+++ b/meta-yocto-bsp/conf/machine/genericx86-64.conf
@@ -6,6 +6,5 @@  DEFAULTTUNE ?= "core2-64"
 require conf/machine/include/x86/tune-core2.inc
 require conf/machine/include/genericx86-common.inc
 
-SERIAL_CONSOLES_CHECK = "ttyS0"
 #For runqemu
 QB_SYSTEM_NAME = "qemu-system-x86_64"