diff mbox series

trusted-firmware-a: fix build error when using ccache

Message ID 20231007223019.2557075-1-javier.tia@linaro.org
State New
Headers show
Series trusted-firmware-a: fix build error when using ccache | expand

Commit Message

Javier Tia Oct. 7, 2023, 10:30 p.m. UTC
When ccache is enabled trusted-firmware-a recipe fails with this
error message:

    make: *** No rule to make target 'aarch64-poky-linux-gcc'. Stop.

ccache prefix CC variable with 'ccache' word before compiler. Because
there are no quotes assigned to CC, only 'ccache' is assigned. The
compiler becomes a make target, producing the build error.

Add single quotes to LD is a good measure to prevent this kind of error.

Signed-off-by: Javier Tia <javier.tia@linaro.org>
---
 .../recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jon Mason Oct. 13, 2023, 4:03 p.m. UTC | #1
On Sat, 07 Oct 2023 16:30:19 -0600, Javier Tia wrote:
> When ccache is enabled trusted-firmware-a recipe fails with this
> error message:
> 
>     make: *** No rule to make target 'aarch64-poky-linux-gcc'. Stop.
> 
> ccache prefix CC variable with 'ccache' word before compiler. Because
> there are no quotes assigned to CC, only 'ccache' is assigned. The
> compiler becomes a make target, producing the build error.
> 
> [...]

Applied, thanks!

[1/1] trusted-firmware-a: fix build error when using ccache
      commit: f2efb2a45610216cb6c2d72bdb5d5e61b990064a

Best regards,
diff mbox series

Patch

diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
index 4d3b0bad..2bdf2211 100644
--- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
+++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
@@ -103,9 +103,9 @@  def remove_options_tail (in_string):
     from itertools import takewhile
     return ' '.join(takewhile(lambda x: not x.startswith('-'), in_string.split(' ')))
 
-EXTRA_OEMAKE += "LD=${@remove_options_tail(d.getVar('LD'))}"
+EXTRA_OEMAKE += "LD='${@remove_options_tail(d.getVar('LD'))}'"
 
-EXTRA_OEMAKE += "CC=${@remove_options_tail(d.getVar('CC'))}"
+EXTRA_OEMAKE += "CC='${@remove_options_tail(d.getVar('CC'))}'"
 
 # Verbose builds, no -Werror
 EXTRA_OEMAKE += "V=1 E=0"