[0/3] perf-scripting/perf-tui features, v2

Submitted by Tom Zanussi on July 6, 2012, 8:29 p.m.

Details

Message ID cover.1341606068.git.tom.zanussi@intel.com
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2

Commit Message

Tom Zanussi July 6, 2012, 8:29 p.m.
From: Tom Zanussi <tom.zanussi@intel.com>

This patchset adds perf-scriping and perf-tui features as
a per-arch thing rather than per-machine, as suggested by
Richard Purdie.

I just started testing this, it works so far, but thought
I'd put it out there now in case there were comments before
putting too much effort into that, and possibly giving other
people a chance to try it out.

The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
  Robert P. J. Day (1):
        bitbake: usermanual: Fix missing markup

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
  http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2

Tom Zanussi (3):
  perf: add perf.inc
  perf: add arch-specific perf-scripting feature
  perf: add arch-specific perf-tui feature

 meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
 meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
 2 files changed, 45 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-kernel/perf/perf.inc

Comments

Tom Zanussi July 8, 2012, 5:18 a.m.
On Fri, 2012-07-06 at 15:29 -0500, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> This patchset adds perf-scriping and perf-tui features as
> a per-arch thing rather than per-machine, as suggested by
> Richard Purdie.
> 
> I just started testing this, it works so far, but thought
> I'd put it out there now in case there were comments before
> putting too much effort into that, and possibly giving other
> people a chance to try it out.
> 

Looks fine after more build-testing: qemux86, qemux86-64, crownbay,
sugarbay, qemuarm and qemuppc both with and without perf-scripting and
perf-tui, and builds without perf as well all build fine here.

Tom

> The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
>   Robert P. J. Day (1):
>         bitbake: usermanual: Fix missing markup
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
>   http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2
> 
> Tom Zanussi (3):
>   perf: add perf.inc
>   perf: add arch-specific perf-scripting feature
>   perf: add arch-specific perf-tui feature
> 
>  meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
>  meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
>  2 files changed, 45 insertions(+), 3 deletions(-)
>  create mode 100644 meta/recipes-kernel/perf/perf.inc
>
Saul Wold July 9, 2012, 7:55 a.m.
On 07/07/2012 10:18 PM, Tom Zanussi wrote:
> On Fri, 2012-07-06 at 15:29 -0500, tom.zanussi@intel.com wrote:
>> From: Tom Zanussi <tom.zanussi@intel.com>
>>
>> This patchset adds perf-scriping and perf-tui features as
>> a per-arch thing rather than per-machine, as suggested by
>> Richard Purdie.
>>
>> I just started testing this, it works so far, but thought
>> I'd put it out there now in case there were comments before
>> putting too much effort into that, and possibly giving other
>> people a chance to try it out.
>>
>
> Looks fine after more build-testing: qemux86, qemux86-64, crownbay,
> sugarbay, qemuarm and qemuppc both with and without perf-scripting and
> perf-tui, and builds without perf as well all build fine here.
>
Tom, I am sorry, I am not sure how else to say this, I have tested 
master with the only the following change and I am still getting the
the setup.py failure mentioned.

I am not sure what else to suspect at this point, this is Master plus 3 
commits, please help me understand where I have gone wrong.

This is the branch I have tested, which is 3 commits pasted Master:

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgw/fail

Thanks
	Sau!

> Tom
>
>> The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
>>    Robert P. J. Day (1):
>>          bitbake: usermanual: Fix missing markup
>>
>> are available in the git repository at:
>>
>>    git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
>>    http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2
>>
>> Tom Zanussi (3):
>>    perf: add perf.inc
>>    perf: add arch-specific perf-scripting feature
>>    perf: add arch-specific perf-tui feature
>>
>>   meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
>>   meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
>>   2 files changed, 45 insertions(+), 3 deletions(-)
>>   create mode 100644 meta/recipes-kernel/perf/perf.inc
>>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
Tom Zanussi July 9, 2012, 1:47 p.m.
On Mon, 2012-07-09 at 00:55 -0700, Saul Wold wrote:
> On 07/07/2012 10:18 PM, Tom Zanussi wrote:
> > On Fri, 2012-07-06 at 15:29 -0500, tom.zanussi@intel.com wrote:
> >> From: Tom Zanussi <tom.zanussi@intel.com>
> >>
> >> This patchset adds perf-scriping and perf-tui features as
> >> a per-arch thing rather than per-machine, as suggested by
> >> Richard Purdie.
> >>
> >> I just started testing this, it works so far, but thought
> >> I'd put it out there now in case there were comments before
> >> putting too much effort into that, and possibly giving other
> >> people a chance to try it out.
> >>
> >
> > Looks fine after more build-testing: qemux86, qemux86-64, crownbay,
> > sugarbay, qemuarm and qemuppc both with and without perf-scripting and
> > perf-tui, and builds without perf as well all build fine here.
> >
> Tom, I am sorry, I am not sure how else to say this, I have tested 
> master with the only the following change and I am still getting the
> the setup.py failure mentioned.
> 
> I am not sure what else to suspect at this point, this is Master plus 3 
> commits, please help me understand where I have gone wrong.
> 
> This is the branch I have tested, which is 3 commits pasted Master:
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgw/fail
> 

Saul,

It's because your kernel hasn't advanced the SRCREVs to include the new
commits - the above patches won't work without the associated kernel
changes.  So if you're build-testing qemux86-64 for instance, you'd want
to change the following line in linux_yocto_3.4.bb from: 

SRCREV_machine_qemux86-64 ?= "d345461f0d52d1a82553c2edd845a8bee908923f"

to include the last commit of the associated kernel patch series i.e.the
top of the common-pc-64 branch:

SRCREV_machine_qemux86-64 ?= "49f1599b2ce0288599805b5364b895f5a9febb3e"

That should get the kernel changes associated with the patchset into
your kernel and everything should build nicely...

Tom

> Thanks
> 	Sau!
> 
> > Tom
> >
> >> The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
> >>    Robert P. J. Day (1):
> >>          bitbake: usermanual: Fix missing markup
> >>
> >> are available in the git repository at:
> >>
> >>    git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
> >>    http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2
> >>
> >> Tom Zanussi (3):
> >>    perf: add perf.inc
> >>    perf: add arch-specific perf-scripting feature
> >>    perf: add arch-specific perf-tui feature
> >>
> >>   meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
> >>   meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
> >>   2 files changed, 45 insertions(+), 3 deletions(-)
> >>   create mode 100644 meta/recipes-kernel/perf/perf.inc
> >>
> >
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> >
> >
>
Bruce Ashfield July 9, 2012, 1:51 p.m.
On Mon, Jul 9, 2012 at 9:47 AM, Tom Zanussi <tom.zanussi@intel.com> wrote:
> On Mon, 2012-07-09 at 00:55 -0700, Saul Wold wrote:
>> On 07/07/2012 10:18 PM, Tom Zanussi wrote:
>> > On Fri, 2012-07-06 at 15:29 -0500, tom.zanussi@intel.com wrote:
>> >> From: Tom Zanussi <tom.zanussi@intel.com>
>> >>
>> >> This patchset adds perf-scriping and perf-tui features as
>> >> a per-arch thing rather than per-machine, as suggested by
>> >> Richard Purdie.
>> >>
>> >> I just started testing this, it works so far, but thought
>> >> I'd put it out there now in case there were comments before
>> >> putting too much effort into that, and possibly giving other
>> >> people a chance to try it out.
>> >>
>> >
>> > Looks fine after more build-testing: qemux86, qemux86-64, crownbay,
>> > sugarbay, qemuarm and qemuppc both with and without perf-scripting and
>> > perf-tui, and builds without perf as well all build fine here.
>> >
>> Tom, I am sorry, I am not sure how else to say this, I have tested
>> master with the only the following change and I am still getting the
>> the setup.py failure mentioned.
>>
>> I am not sure what else to suspect at this point, this is Master plus 3
>> commits, please help me understand where I have gone wrong.
>>
>> This is the branch I have tested, which is 3 commits pasted Master:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgw/fail
>>
>
> Saul,
>
> It's because your kernel hasn't advanced the SRCREVs to include the new
> commits - the above patches won't work without the associated kernel
> changes.  So if you're build-testing qemux86-64 for instance, you'd want
> to change the following line in linux_yocto_3.4.bb from:
>
> SRCREV_machine_qemux86-64 ?= "d345461f0d52d1a82553c2edd845a8bee908923f"
>
> to include the last commit of the associated kernel patch series i.e.the
> top of the common-pc-64 branch:
>
> SRCREV_machine_qemux86-64 ?= "49f1599b2ce0288599805b5364b895f5a9febb3e"

.. and I'm about to send a new set of SRCREVs that have this and
some more. I was just waiting to see how these conversations played out.

Cheers,

Bruce

>
> That should get the kernel changes associated with the patchset into
> your kernel and everything should build nicely...
>
> Tom
>
>> Thanks
>>       Sau!
>>
>> > Tom
>> >
>> >> The following changes since commit 5051e9837fa698e03d0a7a8a918ee7aa98409ce1:
>> >>    Robert P. J. Day (1):
>> >>          bitbake: usermanual: Fix missing markup
>> >>
>> >> are available in the git repository at:
>> >>
>> >>    git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-scripting-v2
>> >>    http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-scripting-v2
>> >>
>> >> Tom Zanussi (3):
>> >>    perf: add perf.inc
>> >>    perf: add arch-specific perf-scripting feature
>> >>    perf: add arch-specific perf-tui feature
>> >>
>> >>   meta/recipes-kernel/perf/perf.inc    |   30 ++++++++++++++++++++++++++++++
>> >>   meta/recipes-kernel/perf/perf_3.4.bb |   18 +++++++++++++++---
>> >>   2 files changed, 45 insertions(+), 3 deletions(-)
>> >>   create mode 100644 meta/recipes-kernel/perf/perf.inc
>> >>
>> >
>> >
>> >
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core@lists.openembedded.org
>> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>> >
>> >
>>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core