diff mbox series

[meta-oe] collectd: build with rrdcached plugin

Message ID DB4PR02MB9598929FA2C57B34DAC69283B8E4A@DB4PR02MB9598.eurprd02.prod.outlook.com
State New
Headers show
Series [meta-oe] collectd: build with rrdcached plugin | expand

Commit Message

Aikaterini Voulgari Sept. 1, 2023, 2:43 p.m. UTC
From cd8b1febe5b333a1d38a839ebb904c768c194c61 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=CE=92=CE=BF=CF=8D=CE=BB=CE=B3=CE=B1=CF=81=CE=B7=20=CE=91?=
=?UTF-8?q?=CE=B9=CE=BA=CE=B1=CF=84=CE=B5=CF=81=CE=AF=CE=BD=CE=B7?=
aikaterini.voulgari@softcom-int.com<mailto:aikaterini.voulgari@softcom-int.com>
Date: Fri, 1 Sep 2023 17:40:13 +0300
Subject: [PATCH] collectd: build with rrdcached plugin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

rrdcached package is provided by rrdtool recipe. The build dependency in PACKAGECONFIG is changed to rrdtool.
    The error was:
     Nothing PROVIDES 'rrdcached' but ../collectd_5.12.0.bb DEPENDS on or otherwise requires it). Close matches:
      rrdtool RPROVIDES rrdcached
    ERROR: Required build target 'collectd' has no buildable providers.
    Missing or unbuildable dependency chain was: ['collectd', 'rrdcached']

    With the patch, collectd builds with no errors and the final image I tested includes collectd with rrdcached plugin.
    Tested on custom image with collectd_5.12.0.

Signed-off-by: Βούλγαρη Αικατερίνη aikaterini.voulgari@softcom-int.com<mailto:aikaterini.voulgari@softcom-int.com>
---
meta-oe/recipes-extended/collectd/collectd_5.12.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj Sept. 1, 2023, 3:43 p.m. UTC | #1
On 9/1/23 7:43 AM, Aikaterini Voulgari wrote:
>  From cd8b1febe5b333a1d38a839ebb904c768c194c61 Mon Sep 17 00:00:00 2001
> 
> From: =?UTF-8?q?=CE=92=CE=BF=CF=8D=CE=BB=CE=B3=CE=B1=CF=81=CE=B7=20=CE=91?=
> 
> =?UTF-8?q?=CE=B9=CE=BA=CE=B1=CF=84=CE=B5=CF=81=CE=AF=CE=BD=CE=B7?=
> 


Thanks for the patch and trying to make OE better, sadly this patch does 
not apply

(Stripping trailing CRs from patch; use --binary to disable.)
patching file meta-oe/recipes-extended/collectd/collectd_5.12.0.bb
patch: **** malformed patch at line 171: ,libmnl"

Please generate it with git format-patch and send it using git 
send-email for best results of it not being altered by your emailer.

> aikaterini.voulgari@softcom-int.com 
> <mailto:aikaterini.voulgari@softcom-int.com>
> 
> Date: Fri, 1 Sep 2023 17:40:13 +0300
> 
> Subject: [PATCH] collectd: build with rrdcached plugin
> 
> MIME-Version: 1.0
> 
> Content-Type: text/plain; charset=UTF-8
> 
> Content-Transfer-Encoding: 8bit
> 
> rrdcached package is provided by rrdtool recipe. The build dependency in 
> PACKAGECONFIG is changed to rrdtool.
> 
>      The error was:
> 
>       Nothing PROVIDES 'rrdcached' but ../collectd_5.12.0.bb DEPENDS on 
> or otherwise requires it). Close matches:
> 
>        rrdtool RPROVIDES rrdcached
> 
>      ERROR: Required build target 'collectd' has no buildable providers.
> 
>      Missing or unbuildable dependency chain was: ['collectd', 'rrdcached']
> 
>      With the patch, collectd builds with no errors and the final image 
> I tested includes collectd with rrdcached plugin.
> 
>      Tested on custom image with collectd_5.12.0.
> 
> Signed-off-by: Βούλγαρη Αικατερίνη aikaterini.voulgari@softcom-int.com 
> <mailto:aikaterini.voulgari@softcom-int.com>
> 
> ---
> 
> meta-oe/recipes-extended/collectd/collectd_5.12.0.bb | 2 +-
> 
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-extended/collectd/collectd_5.12.0.bb 
> b/meta-oe/recipes-extended/collectd/collectd_5.12.0.bb
> 
> index 5dc64588d..479c12d6a 100644
> 
> --- a/meta-oe/recipes-extended/collectd/collectd_5.12.0.bb
> 
> +++ b/meta-oe/recipes-extended/collectd/collectd_5.12.0.bb
> 
> @@ -50,7 +50,7 @@ PACKAGECONFIG[libmnl] = 
> "--with-libmnl,--without-libmnl,libmnl"
> 
> PACKAGECONFIG[libatasmart] = 
> "--with-libatasmart,--without-libatasmart,libatasmart"
> 
> PACKAGECONFIG[ldap] = "--enable-openldap 
> --with-libldap,--disable-openldap --without-libldap, openldap"
> 
> PACKAGECONFIG[rrdtool] = "--enable-rrdtool,--disable-rrdtool,rrdtool"
> 
> -PACKAGECONFIG[rrdcached] = 
> "--enable-rrdcached,--disable-rrdcached,rrdcached"
> 
> +PACKAGECONFIG[rrdcached] = "--enable-rrdcached,--disable-rrdcached,rrdtool"
> 
> PACKAGECONFIG[python] = "--enable-python,--disable-python"
> 
>   EXTRA_OECONF = " \
> 
> -- 
> 
> 2.34.1
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#104691): https://lists.openembedded.org/g/openembedded-devel/message/104691
> Mute This Topic: https://lists.openembedded.org/mt/101096634/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-extended/collectd/collectd_5.12.0.bb b/meta-oe/recipes-extended/collectd/collectd_5.12.0.bb
index 5dc64588d..479c12d6a 100644
--- a/meta-oe/recipes-extended/collectd/collectd_5.12.0.bb
+++ b/meta-oe/recipes-extended/collectd/collectd_5.12.0.bb
@@ -50,7 +50,7 @@  PACKAGECONFIG[libmnl] = "--with-libmnl,--without-libmnl,libmnl"
PACKAGECONFIG[libatasmart] = "--with-libatasmart,--without-libatasmart,libatasmart"
PACKAGECONFIG[ldap] = "--enable-openldap --with-libldap,--disable-openldap --without-libldap, openldap"
PACKAGECONFIG[rrdtool] = "--enable-rrdtool,--disable-rrdtool,rrdtool"
-PACKAGECONFIG[rrdcached] = "--enable-rrdcached,--disable-rrdcached,rrdcached"
+PACKAGECONFIG[rrdcached] = "--enable-rrdcached,--disable-rrdcached,rrdtool"
PACKAGECONFIG[python] = "--enable-python,--disable-python"
 EXTRA_OECONF = " \
--
2.34.1