diff mbox series

[oe,1/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

Message ID 20230827080953.2005190-2-max.oss.09@gmail.com
State New
Headers show
Series Revert "bin_package.bbclass: Inhibit the default dependencies" | expand

Commit Message

Max Krummenacher Aug. 27, 2023, 8:09 a.m. UTC
From: Max Krummenacher <max.krummenacher@toradex.com>

This reverts commit d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727.

The commit not only removes the dependencies on the cross compiler
but also does not depend on e.g. virtual/${TARGET_PREFIX}compilerlibs
and virtual/libc which in turn makes the file-rdeps qa check fail
if installing binaries linked against e.g. libc or libstdc++.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 meta/classes-recipe/bin_package.bbclass | 3 ---
 1 file changed, 3 deletions(-)

Comments

Peter Kjellerstedt Oct. 27, 2023, 8:13 p.m. UTC | #1
*ping* This needs to be applied to both master and nanbield.

//Peter

> -----Original Message-----
> From: Max Krummenacher <max.oss.09@gmail.com>
> Sent: den 27 augusti 2023 10:10
> To: openembedded-core@lists.openembedded.org; Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: Max Krummenacher <max.krummenacher@toradex.com>; Randolph Sapp <rs@ti.com>
> Subject: [oe][OE-core][Patch 1/1] Revert "bin_package.bbclass: Inhibit the default dependencies"
> 
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> This reverts commit d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727.
> 
> The commit not only removes the dependencies on the cross compiler
> but also does not depend on e.g. virtual/${TARGET_PREFIX}compilerlibs
> and virtual/libc which in turn makes the file-rdeps qa check fail
> if installing binaries linked against e.g. libc or libstdc++.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> ---
>  meta/classes-recipe/bin_package.bbclass | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/meta/classes-recipe/bin_package.bbclass b/meta/classes-recipe/bin_package.bbclass
> index 9dd2489725..3a1befc29c 100644
> --- a/meta/classes-recipe/bin_package.bbclass
> +++ b/meta/classes-recipe/bin_package.bbclass
> @@ -20,9 +20,6 @@
>  # they would be in ${WORKDIR}.
>  #
> 
> -# Nothing is being built so there is no need for the cross-compiler.
> -INHIBIT_DEFAULT_DEPS = "1"
> -
>  # Skip the unwanted steps
>  do_configure[noexec] = "1"
>  do_compile[noexec] = "1"
> --
> 2.35.3
diff mbox series

Patch

diff --git a/meta/classes-recipe/bin_package.bbclass b/meta/classes-recipe/bin_package.bbclass
index 9dd2489725..3a1befc29c 100644
--- a/meta/classes-recipe/bin_package.bbclass
+++ b/meta/classes-recipe/bin_package.bbclass
@@ -20,9 +20,6 @@ 
 # they would be in ${WORKDIR}.
 #
 
-# Nothing is being built so there is no need for the cross-compiler.
-INHIBIT_DEFAULT_DEPS = "1"
-
 # Skip the unwanted steps
 do_configure[noexec] = "1"
 do_compile[noexec] = "1"