[2/2] task-core-basic: drop portmap

Submitted by Christopher Larson on June 2, 2012, 2:24 a.m.

Details

Message ID acae76c50ae66d8167038782cc623f5de64e1365.1338603853.git.kergoth@gmail.com
State Accepted
Commit f63add40c6bdfb3a19e59ac28f7d2ae5597f5bfd
Headers show

Commit Message

Christopher Larson June 2, 2012, 2:24 a.m.
Both rpcbind and portmap are RPC port mappers. Having both is redundant. Chose
rpcbind over portmap as rpcbind supports ipv6, nfs4, and builds without the
glibc rpc headers, which have been obsoleted in glibc 2.14.

Signed-off-by: Christopher Larson <kergoth@gmail.com>
---
 meta/recipes-extended/tasks/task-core-basic.bb |    1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-extended/tasks/task-core-basic.bb b/meta/recipes-extended/tasks/task-core-basic.bb
index 8bab0db..a810d37 100644
--- a/meta/recipes-extended/tasks/task-core-basic.bb
+++ b/meta/recipes-extended/tasks/task-core-basic.bb
@@ -148,7 +148,6 @@  RDEPENDS_task-core-sys-services = "\
     nfs-utils \
     pciutils \
     libpcre \
-    portmap \
     rpcbind \
     sysfsutils \
     tcp-wrappers \

Comments

Paul Eggleton Aug. 28, 2012, 10:54 a.m.
On Friday 01 June 2012 19:24:54 Christopher Larson wrote:
> Both rpcbind and portmap are RPC port mappers. Having both is redundant.
> Chose rpcbind over portmap as rpcbind supports ipv6, nfs4, and builds
> without the glibc rpc headers, which have been obsoleted in glibc 2.14.
> 
> Signed-off-by: Christopher Larson <kergoth@gmail.com>
> ---
>  meta/recipes-extended/tasks/task-core-basic.bb |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/tasks/task-core-basic.bb
> b/meta/recipes-extended/tasks/task-core-basic.bb index 8bab0db..a810d37
> 100644
> --- a/meta/recipes-extended/tasks/task-core-basic.bb
> +++ b/meta/recipes-extended/tasks/task-core-basic.bb
> @@ -148,7 +148,6 @@ RDEPENDS_task-core-sys-services = "\
>      nfs-utils \
>      pciutils \
>      libpcre \
> -    portmap \
>      rpcbind \
>      sysfsutils \
>      tcp-wrappers \

I came across this while digging back through the history in master. Does this 
mean we ought to be switching to rpcbind in our other tasks which currently 
bring in portmap (e.g. task-base-nfs, task-core-apps-console)?

Cheers,
Paul
Koen Kooi Aug. 28, 2012, 3:22 p.m.
Op 2 jun. 2012, om 04:24 heeft Christopher Larson <kergoth@gmail.com> het volgende geschreven:

> Both rpcbind and portmap are RPC port mappers. Having both is redundant. Chose
> rpcbind over portmap as rpcbind supports ipv6, nfs4, and builds without the
> glibc rpc headers, which have been obsoleted in glibc 2.14.
> 
> Signed-off-by: Christopher Larson <kergoth@gmail.com>
> ---
> meta/recipes-extended/tasks/task-core-basic.bb |    1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/tasks/task-core-basic.bb b/meta/recipes-extended/tasks/task-core-basic.bb
> index 8bab0db..a810d37 100644
> --- a/meta/recipes-extended/tasks/task-core-basic.bb
> +++ b/meta/recipes-extended/tasks/task-core-basic.bb
> @@ -148,7 +148,6 @@ RDEPENDS_task-core-sys-services = "\
>     nfs-utils \
>     pciutils \
>     libpcre \
> -    portmap \
>     rpcbind \
>     sysfsutils \
>     tcp-wrappers \
> -- 

Missing PR bump
Paul Eggleton Aug. 28, 2012, 4 p.m.
On Tuesday 28 August 2012 17:22:02 Koen Kooi wrote:
> Op 2 jun. 2012, om 04:24 heeft Christopher Larson <kergoth@gmail.com> het 
volgende geschreven:
> > Both rpcbind and portmap are RPC port mappers. Having both is redundant.
> > Chose rpcbind over portmap as rpcbind supports ipv6, nfs4, and builds
> > without the glibc rpc headers, which have been obsoleted in glibc 2.14.
> > 
> > Signed-off-by: Christopher Larson <kergoth@gmail.com>
> > ---
> > meta/recipes-extended/tasks/task-core-basic.bb |    1 -
> > 1 file changed, 1 deletion(-)
> > 
> > diff --git a/meta/recipes-extended/tasks/task-core-basic.bb
> > b/meta/recipes-extended/tasks/task-core-basic.bb index 8bab0db..a810d37
> > 100644
> > --- a/meta/recipes-extended/tasks/task-core-basic.bb
> > +++ b/meta/recipes-extended/tasks/task-core-basic.bb
> > @@ -148,7 +148,6 @@ RDEPENDS_task-core-sys-services = "\
> > 
> >     nfs-utils \
> >     pciutils \
> >     libpcre \
> > 
> > -    portmap \
> > 
> >     rpcbind \
> >     sysfsutils \
> >     tcp-wrappers \
> 
> Missing PR bump

The patch you're replying to was posted ages ago and has already been 
merged...

Cheers,
Paul
Khem Raj Aug. 28, 2012, 8:37 p.m.
On Tue, Aug 28, 2012 at 3:54 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
>>      libpcre \
>> -    portmap \
>>      rpcbind \
>>      sysfsutils \
>>      tcp-wrappers \
>
> I came across this while digging back through the history in master. Does this
> mean we ought to be switching to rpcbind in our other tasks which currently
> bring in portmap (e.g. task-base-nfs, task-core-apps-console)?
>

I guess yes because rpcbind is more featureful than portmap. its
better to use rpcbind as default portmapper. Things like ipv6, nfsv4
Christopher Larson Aug. 29, 2012, 5:27 p.m.
On Tue, Aug 28, 2012 at 1:37 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Tue, Aug 28, 2012 at 3:54 AM, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
>>>      libpcre \
>>> -    portmap \
>>>      rpcbind \
>>>      sysfsutils \
>>>      tcp-wrappers \
>>
>> I came across this while digging back through the history in master. Does this
>> mean we ought to be switching to rpcbind in our other tasks which currently
>> bring in portmap (e.g. task-base-nfs, task-core-apps-console)?
>>
>
> I guess yes because rpcbind is more featureful than portmap. its
> better to use rpcbind as default portmapper. Things like ipv6, nfsv4

Yeah, I think that would be best. It is worth noting that task-base
and portmap are in recipes-core, while rpcbind is, iirc, in
recipes-support, so such a change would probably be best done when
also swapping the locations of the two recipes.