| Message ID | 20230811022046.7829-1-yang.xu@mediatek.com |
|---|---|
| State | Accepted, archived |
| Commit | bfc53b190bd2530c2bfcea0690127d7eff620f45 |
| Headers | show |
| Series | server/process: fix sig handle | expand |
On Fri, 2023-08-11 at 02:20 +0000, yang.xu@mediatek.com wrote: > From: Yang Xu <yang.xu@mediatek.com> > > process.signal_received is a list for signum and not iterable, > change a suitable method to handle sig. > > Signed-off-by: Yang Xu <yang.xu@mediatek.com> > --- > lib/bb/server/process.py | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py > index 4d4fa6d1..f62faed0 100644 > --- a/lib/bb/server/process.py > +++ b/lib/bb/server/process.py > @@ -860,11 +860,10 @@ class ConnectionWriter(object): > process.queue_signals = True > self._send(obj) > process.queue_signals = False > - try: > - for sig in process.signal_received.pop(): > - process.handle_sig(sig, None) > - except IndexError: > - pass > + > + while len(process.signal_received) > 0: > + sig = process.signal_received.pop() > + process.handle_sig(sig, None) > else: > self._send(obj) > Well spotted, thanks! Cheers, Richard
diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py index 4d4fa6d1..f62faed0 100644 --- a/lib/bb/server/process.py +++ b/lib/bb/server/process.py @@ -860,11 +860,10 @@ class ConnectionWriter(object): process.queue_signals = True self._send(obj) process.queue_signals = False - try: - for sig in process.signal_received.pop(): - process.handle_sig(sig, None) - except IndexError: - pass + + while len(process.signal_received) > 0: + sig = process.signal_received.pop() + process.handle_sig(sig, None) else: self._send(obj)