diff mbox series

kas/: pass through DISPLAY from environment

Message ID 20230809092418.2918762-1-ross.burton@arm.com
State New
Headers show
Series kas/: pass through DISPLAY from environment | expand

Commit Message

Ross Burton Aug. 9, 2023, 9:24 a.m. UTC 
From: Ross Burton <ross.burton@arm.com>

If a user does eg "kas shell kas/corstone1000-base.yml" and then calls
runfvp, the spawned xterms don't have a valid DISPLAY set.

Add DISPLAY to the preserved environment variables and DISPLAY will be
passed into the shell, and the xterms will start correctly.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 kas/corstone1000-base.yml      | 3 +++
 kas/corstone500.yml            | 3 +++
 kas/fvp-baser-aemv8r64-bsp.yml | 3 +++
 3 files changed, 9 insertions(+)

Comments

Jon Mason Aug. 11, 2023, 11:20 p.m. UTC | #1 
On Wed, 09 Aug 2023 10:24:18 +0100, ross.burton@arm.com wrote:
> If a user does eg "kas shell kas/corstone1000-base.yml" and then calls
> runfvp, the spawned xterms don't have a valid DISPLAY set.
> 
> Add DISPLAY to the preserved environment variables and DISPLAY will be
> passed into the shell, and the xterms will start correctly.
> 
> 
> [...]

Applied, thanks!

[1/1] kas/: pass through DISPLAY from environment
      commit: a209895b94029e067ccd8359e25279fb35a2c52c

Best regards,
diff mbox series

Patch

diff --git a/kas/corstone1000-base.yml b/kas/corstone1000-base.yml
index 85706dc0..161312fb 100644
--- a/kas/corstone1000-base.yml
+++ b/kas/corstone1000-base.yml
@@ -1,6 +1,9 @@ 
 header:
   version: 11
 
+env:
+  DISPLAY: ""
+
 distro: poky-tiny
 
 defaults:
diff --git a/kas/corstone500.yml b/kas/corstone500.yml
index d40b59df..c27cb5f5 100644
--- a/kas/corstone500.yml
+++ b/kas/corstone500.yml
@@ -3,6 +3,9 @@  header:
   includes:
     - kas/fvp-eula.yml
 
+env:
+  DISPLAY: ""
+
 distro: poky-tiny
 
 defaults:
diff --git a/kas/fvp-baser-aemv8r64-bsp.yml b/kas/fvp-baser-aemv8r64-bsp.yml
index 9f16a3f9..366ab87e 100644
--- a/kas/fvp-baser-aemv8r64-bsp.yml
+++ b/kas/fvp-baser-aemv8r64-bsp.yml
@@ -3,6 +3,9 @@  header:
   includes:
     - kas/fvp-eula.yml
 
+env:
+  DISPLAY: ""
+
 distro: poky
 machine: fvp-baser-aemv8r64